Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Enable CheckJavaStyle on MacOS (#35036)" (#35191)

Browse Source 
This reverts commit b328992aac.

This check fails on MacOS CIs. The failure error is:

Evaluation of CheckJavaStyle failed: [Errno 2] No such file or directory: '/<reducted>/src/third_party/jdk/current/bin/java'.

Upstream's DEPS does not check out third_party/jdk on MacOS based on the
condition:

  'src/third_party/jdk/current': {
      ...
      # Needed on Linux for use on chromium_presubmit (for checkstyle).
      'condition': '(checkout_android or checkout_linux) and non_git_source',
      ...
This commit is contained in:
Max Karolinskiy
2026-04-01 22:41:10 -04:00
committed by GitHub
parent 580287db03
commit 00f7ff63b4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PRESUBMIT.py
+2 -2
View File
@@ -593,8 +593,8 @@ def CheckJavaStyle(_original_check, input_api, output_api):
for f in input_api.AffectedFiles()):
return []
# Android toolchain is only available on Linux and MacOS.
if not sys.platform.startswith(('linux', 'darwin')):
# Android toolchain is only available on Linux.
if not sys.platform.startswith('linux'):
return []
with brave_chromium_utils.sys_path('//tools/android/checkstyle'):