Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr148][Android] Changes around BottomBarHostManager

Browse Source 
New arg bottomBarHostManager at:
- HubManagerImpl.ctor
- TabbedRootUiCoordinator.ctor
- ToolbarManager.ctor

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/9be4e7a3e1f68c9a7405c62e06cbe8b4ed8832d5

commit 9be4e7a3e1f68c9a7405c62e06cbe8b4ed8832d5
Author: Calder Kitagawa <ckitagawa@chromium.org>
Date:   Tue Mar 17 16:49:31 2026 -0700

    [BottomBar] handle view ownership transfer

    Bug: 491509787
    Change-Id: Ia8baf8095c55fe9580d718bb8806deab9fd0f5e1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7667562
    Reviewed-by: Madhav Pruthi <madhavpruthi@google.com>
    Reviewed-by: Dan Polanco <polardz@google.com>
    Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1600877}
This commit is contained in:
AlexeyBarabash
2026-04-27 12:00:49 +01:00
committed by Claudio DeSouza
parent ca04e711f9
commit 055edd76d8
5 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedRootUiCoordinator.java
+5 -2
View File
@@ -53,6 +53,7 @@ import org.chromium.chrome.browser.toolbar.ToolbarIntentMetadata;
import org.chromium.chrome.browser.ui.BraveAdaptiveToolbarUiCoordinator;
import org.chromium.chrome.browser.ui.appmenu.AppMenuBlocker;
import org.chromium.chrome.browser.ui.appmenu.AppMenuDelegate;
import org.chromium.chrome.browser.ui.bottombar.BottomBarHostManager;
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeController;
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeUtils;
import org.chromium.chrome.browser.ui.edge_to_edge.TopInsetProvider;
@@ -135,7 +136,8 @@ public class BraveTabbedRootUiCoordinator extends TabbedRootUiCoordinator {
EdgeToEdgeManager edgeToEdgeManager,
MonotonicObservableSupplier<BookmarkManagerOpener> bookmarkManagerOpenerSupplier,
NonNullObservableSupplier<Boolean> xrSpaceModeObservableSupplier,
OneshotSupplier<ChromeInactivityTracker> inactivityTrackerSupplier) {
OneshotSupplier<ChromeInactivityTracker> inactivityTrackerSupplier,
@Nullable BottomBarHostManager bottomBarHostManager) {
super(
activity,
onOmniboxFocusChangedListener,
@@ -189,7 +191,8 @@ public class BraveTabbedRootUiCoordinator extends TabbedRootUiCoordinator {
edgeToEdgeManager,
bookmarkManagerOpenerSupplier,
xrSpaceModeObservableSupplier,
inactivityTrackerSupplier);
inactivityTrackerSupplier,
bottomBarHostManager);
mBraveActivity = activity;
mHubManagerSupplier = hubManagerSupplier;
android/java/org/chromium/chrome/browser/toolbar/BraveToolbarManager.java
+5 -2
View File
@@ -92,6 +92,7 @@ import org.chromium.chrome.browser.toolbar.top.ToolbarLayout;
import org.chromium.chrome.browser.toolbar.top.TopToolbarCoordinator;
import org.chromium.chrome.browser.ui.appmenu.AppMenuCoordinator;
import org.chromium.chrome.browser.ui.appmenu.AppMenuDelegate;
import org.chromium.chrome.browser.ui.bottombar.BottomBarHostManager;
import org.chromium.chrome.browser.ui.browser_window.ChromeAndroidTask;
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeController;
import org.chromium.chrome.browser.ui.edge_to_edge.TopInsetProvider;
@@ -231,7 +232,8 @@ public class BraveToolbarManager extends ToolbarManager
NonNullObservableSupplier<Boolean> xrSpaceModeObservableSupplier,
PageZoomManager pageZoomManager,
SnackbarManager snackbarManager,
@Nullable OmniboxChipManager omniboxChipManager) {
@Nullable OmniboxChipManager omniboxChipManager,
@Nullable BottomBarHostManager bottomBarHostManager) {
super(
activity,
bottomControlsStacker,
@@ -287,7 +289,8 @@ public class BraveToolbarManager extends ToolbarManager
xrSpaceModeObservableSupplier,
pageZoomManager,
snackbarManager,
omniboxChipManager);
omniboxChipManager,
bottomBarHostManager);
mOmniboxFocusStateSupplier = omniboxFocusStateSupplier;
mLayoutStateProviderSupplier = layoutStateProviderSupplier;