From 08ae20ee599afa5e6682311032cd63e428db39f5 Mon Sep 17 00:00:00 2001 From: samartnik Date: Thu, 28 Jan 2021 17:41:06 -0500 Subject: [PATCH] [Android] Temporarily force non-component builds This fixes current crash for debug builds. Fix will come from upstream. --- build/commands/lib/config.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/build/commands/lib/config.js b/build/commands/lib/config.js index 5c2882c6285..06263a059ce 100755 --- a/build/commands/lib/config.js +++ b/build/commands/lib/config.js @@ -321,6 +321,10 @@ Config.prototype.buildArgs = function () { if (this.buildConfig !== 'Release') { // treat non-release builds like Debug builds args.treat_warnings_as_errors = false + // TODO(samartnik): component builds crash at the moment on Android. + // We will need to revert this change once this fix is landed in upstream + // https://bugs.chromium.org/p/chromium/issues/detail?id=1166748#c14 + args.is_component_build = false } else { // otherwise there is build error // ld.lld: error: output file too large: 5861255936 bytes