From 0d5789efa1dc3759d017d414eda68d870bebbfb2 Mon Sep 17 00:00:00 2001
From: Sujit Acharya <sujitacharya2005@gmail.com>
Date: Wed, 5 Oct 2022 13:15:06 +0530
Subject: [PATCH] udate review comments

---
 .../BraveStatsBottomSheetDialogFragment.java  |  6 +++---
 .../drawable/stats_bottomsheet_background.xml |  1 -
 .../brave_stats_notification_permission.xml   | 19 ++++++++++---------
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/android/java/org/chromium/chrome/browser/brave_stats/BraveStatsBottomSheetDialogFragment.java b/android/java/org/chromium/chrome/browser/brave_stats/BraveStatsBottomSheetDialogFragment.java
index a214c8ac90e..c1e7cab7b1f 100644
--- a/android/java/org/chromium/chrome/browser/brave_stats/BraveStatsBottomSheetDialogFragment.java
+++ b/android/java/org/chromium/chrome/browser/brave_stats/BraveStatsBottomSheetDialogFragment.java
@@ -206,10 +206,10 @@ public class BraveStatsBottomSheetDialogFragment extends BottomSheetDialogFragme
     @Override
     public void onResume() {
         super.onResume();
-        if (!hasPermission(getActivity(), PermissionConstants.NOTIFICATION_PERMISSION)) {
-            statsNotificationView.setVisibility(View.VISIBLE);
-        } else {
+        if (hasPermission(getActivity(), PermissionConstants.NOTIFICATION_PERMISSION)) {
             statsNotificationView.setVisibility(View.GONE);
+        } else {
+            statsNotificationView.setVisibility(View.VISIBLE);
         }
     }
 
diff --git a/android/java/res/drawable/stats_bottomsheet_background.xml b/android/java/res/drawable/stats_bottomsheet_background.xml
index 789c7fda53d..7e1eb000f48 100644
--- a/android/java/res/drawable/stats_bottomsheet_background.xml
+++ b/android/java/res/drawable/stats_bottomsheet_background.xml
@@ -2,7 +2,6 @@
 <shape xmlns:android="http://schemas.android.com/apk/res/android">
 
     <solid android:color="@color/brave_stats_bg_color" />
-    
 
     <corners
         android:topLeftRadius="24dp"
diff --git a/android/java/res/layout/brave_stats_notification_permission.xml b/android/java/res/layout/brave_stats_notification_permission.xml
index 6aa345d6ce5..c7543c0d58f 100644
--- a/android/java/res/layout/brave_stats_notification_permission.xml
+++ b/android/java/res/layout/brave_stats_notification_permission.xml
@@ -1,14 +1,15 @@
-<?xml version="1.0" encoding="utf-8"?><!--* Copyright (c) 2022 The Brave Authors. All rights reserved.
+<?xml version="1.0" encoding="utf-8"?>
+<!--* Copyright (c) 2022 The Brave Authors. All rights reserved.
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+
 <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
-    android:layout_height="152dp"
-    android:layout_marginStart="20dp"
-    android:layout_marginEnd="20dp"
+    android:layout_height="wrap_content"
+    android:layout_marginHorizontal="20dp"
     android:layout_marginBottom="32dp"
     android:background="@drawable/ic_stats_notification_background">
 
@@ -23,7 +24,6 @@
         android:src="@drawable/ic_baseline_close_24"
         android:contentDescription="@null" />
         
-
     <ImageView
         android:id="@+id/imageView"
         android:layout_width="wrap_content"
@@ -44,7 +44,7 @@
         android:fontFamily="sans-serif-medium"
         android:text="@string/stats_notification_privacy_updates_description"
         android:textColor="@android:color/white"
-        android:textSize="17sp"
+        android:textSize="16sp"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toEndOf="@+id/imageView"
         app:layout_constraintTop_toTopOf="@+id/imageView" />
@@ -53,12 +53,13 @@
         android:id="@+id/notification_on_button"
         android:layout_width="0dp"
         android:layout_height="44dp"
-        android:layout_marginStart="24dp"
+        android:layout_marginHorizontal="24dp"
         android:layout_marginTop="16dp"
-        android:layout_marginEnd="24dp"
+        android:layout_marginBottom="24dp"
         android:background="@drawable/stats_notification_on_button_bg"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
+        app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintTop_toBottomOf="@+id/imageView">
 
         <TextView
@@ -72,4 +73,4 @@
             android:textColor="@android:color/white" />
     </FrameLayout>
 
-</androidx.constraintlayout.widget.ConstraintLayout>
\ No newline at end of file
+</androidx.constraintlayout.widget.ConstraintLayout>