From 10f4a6eefef4529109b62d0efa5ec3525dfaaaed Mon Sep 17 00:00:00 2001
From: Terry Mancey <terry.mancey@icloud.com>
Date: Mon, 19 Sep 2022 18:53:11 -0500
Subject: [PATCH] Cleanup delegates

---
 .../internal/account/confirmations/confirmations_delegate.h  | 5 +++--
 .../src/bat/ads/internal/account/issuers/issuers_delegate.h  | 5 +++--
 .../redeem_unblinded_payment_tokens_delegate.h               | 5 +++--
 .../redeem_unblinded_token/redeem_unblinded_token_delegate.h | 5 +++--
 .../refill_unblinded_tokens_delegate.h                       | 5 +++--
 5 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/vendor/bat-native-ads/src/bat/ads/internal/account/confirmations/confirmations_delegate.h b/vendor/bat-native-ads/src/bat/ads/internal/account/confirmations/confirmations_delegate.h
index f57d4bba0df..a5c97e539b3 100644
--- a/vendor/bat-native-ads/src/bat/ads/internal/account/confirmations/confirmations_delegate.h
+++ b/vendor/bat-native-ads/src/bat/ads/internal/account/confirmations/confirmations_delegate.h
@@ -12,13 +12,14 @@ struct ConfirmationInfo;
 
 class ConfirmationsDelegate {
  public:
-  virtual ~ConfirmationsDelegate() = default;
-
   // Invoked to tell the delegate that the |confirmation| was successfully sent.
   virtual void OnDidConfirm(const ConfirmationInfo& confirmation) {}
 
   // Invoked to tell the delegate that we failed to send the |confirmation|.
   virtual void OnFailedToConfirm(const ConfirmationInfo& confirmation) {}
+
+ protected:
+  virtual ~ConfirmationsDelegate() = default;
 };
 
 }  // namespace ads
diff --git a/vendor/bat-native-ads/src/bat/ads/internal/account/issuers/issuers_delegate.h b/vendor/bat-native-ads/src/bat/ads/internal/account/issuers/issuers_delegate.h
index 96b7e72792a..732dd893053 100644
--- a/vendor/bat-native-ads/src/bat/ads/internal/account/issuers/issuers_delegate.h
+++ b/vendor/bat-native-ads/src/bat/ads/internal/account/issuers/issuers_delegate.h
@@ -14,8 +14,6 @@ struct IssuersInfo;
 
 class IssuersDelegate {
  public:
-  virtual ~IssuersDelegate() = default;
-
   // Invoked to tell the delegate we successfully fetched the |issuers|.
   virtual void OnDidFetchIssuers(const IssuersInfo& issuers) {}
 
@@ -28,6 +26,9 @@ class IssuersDelegate {
 
   // Invoked to tell the delegate we retried fetching the issuers.
   virtual void OnDidRetryFetchingIssuers() {}
+
+ protected:
+  virtual ~IssuersDelegate() = default;
 };
 
 }  // namespace ads
diff --git a/vendor/bat-native-ads/src/bat/ads/internal/account/utility/redeem_unblinded_payment_tokens/redeem_unblinded_payment_tokens_delegate.h b/vendor/bat-native-ads/src/bat/ads/internal/account/utility/redeem_unblinded_payment_tokens/redeem_unblinded_payment_tokens_delegate.h
index 2a1f7e97856..323aa559d33 100644
--- a/vendor/bat-native-ads/src/bat/ads/internal/account/utility/redeem_unblinded_payment_tokens/redeem_unblinded_payment_tokens_delegate.h
+++ b/vendor/bat-native-ads/src/bat/ads/internal/account/utility/redeem_unblinded_payment_tokens/redeem_unblinded_payment_tokens_delegate.h
@@ -13,8 +13,6 @@ namespace ads {
 
 class RedeemUnblindedPaymentTokensDelegate {
  public:
-  virtual ~RedeemUnblindedPaymentTokensDelegate() = default;
-
   // Invoked to tell the delegate that the |unblinded_payment_tokens| were
   // successfully redeemed.
   virtual void OnDidRedeemUnblindedPaymentTokens(
@@ -37,6 +35,9 @@ class RedeemUnblindedPaymentTokensDelegate {
   // Invoked to tell the delegate that we retried redeeming unblinded payment
   // tokens.
   virtual void OnDidRetryRedeemingUnblindedPaymentTokens() {}
+
+ protected:
+  virtual ~RedeemUnblindedPaymentTokensDelegate() = default;
 };
 
 }  // namespace ads
diff --git a/vendor/bat-native-ads/src/bat/ads/internal/account/utility/redeem_unblinded_token/redeem_unblinded_token_delegate.h b/vendor/bat-native-ads/src/bat/ads/internal/account/utility/redeem_unblinded_token/redeem_unblinded_token_delegate.h
index 6e6e77c5321..96175179e73 100644
--- a/vendor/bat-native-ads/src/bat/ads/internal/account/utility/redeem_unblinded_token/redeem_unblinded_token_delegate.h
+++ b/vendor/bat-native-ads/src/bat/ads/internal/account/utility/redeem_unblinded_token/redeem_unblinded_token_delegate.h
@@ -16,8 +16,6 @@ struct ConfirmationInfo;
 
 class RedeemUnblindedTokenDelegate {
  public:
-  virtual ~RedeemUnblindedTokenDelegate() = default;
-
   // Invoked to tell the delegate the |confirmation| was successfully sent.
   virtual void OnDidSendConfirmation(const ConfirmationInfo& confirmation) {}
 
@@ -39,6 +37,9 @@ class RedeemUnblindedTokenDelegate {
       const ConfirmationInfo& confirmation,
       const bool should_retry,
       const bool should_backoff) {}
+
+ protected:
+  virtual ~RedeemUnblindedTokenDelegate() = default;
 };
 
 }  // namespace ads
diff --git a/vendor/bat-native-ads/src/bat/ads/internal/account/utility/refill_unblinded_tokens/refill_unblinded_tokens_delegate.h b/vendor/bat-native-ads/src/bat/ads/internal/account/utility/refill_unblinded_tokens/refill_unblinded_tokens_delegate.h
index d8a62ae76ce..3a64aef96e6 100644
--- a/vendor/bat-native-ads/src/bat/ads/internal/account/utility/refill_unblinded_tokens/refill_unblinded_tokens_delegate.h
+++ b/vendor/bat-native-ads/src/bat/ads/internal/account/utility/refill_unblinded_tokens/refill_unblinded_tokens_delegate.h
@@ -14,8 +14,6 @@ namespace ads {
 
 class RefillUnblindedTokensDelegate {
  public:
-  virtual ~RefillUnblindedTokensDelegate() = default;
-
   // Invoked to tell the delegate we successfully refilled the unblinded tokens.
   virtual void OnDidRefillUnblindedTokens() {}
 
@@ -34,6 +32,9 @@ class RefillUnblindedTokensDelegate {
   // with the given |captcha_id| before we can refill the unblinded tokens.
   virtual void OnCaptchaRequiredToRefillUnblindedTokens(
       const std::string& captcha_id) {}
+
+ protected:
+  virtual ~RefillUnblindedTokensDelegate() = default;
 };
 
 }  // namespace ads