diff --git a/components/brave_rewards/browser/rewards_p3a.cc b/components/brave_rewards/browser/rewards_p3a.cc index 737a5dead6f..5891924bb85 100644 --- a/components/brave_rewards/browser/rewards_p3a.cc +++ b/components/brave_rewards/browser/rewards_p3a.cc @@ -45,7 +45,7 @@ void RecordWalletState(const WalletState& state) { answer = 1; } } - UMA_HISTOGRAM_EXACT_LINEAR("Brave.Rewards.WalletState", answer, 5); + UMA_HISTOGRAM_EXACT_LINEAR("Brave.Rewards.WalletState", answer, 6); } void RecordWalletBalance(bool wallet_created, bool rewards_enabled, size_t b) { @@ -54,15 +54,17 @@ void RecordWalletBalance(bool wallet_created, bool rewards_enabled, size_t b) { answer = 1; } else if (rewards_enabled) { DCHECK(wallet_created); - if (b < 10) { + if (b == 0) { answer = 2; - } else if (10 <= b && b < 50) { + } else if (b < 10) { answer = 3; - } else if (50 <= b) { + } else if (10 <= b && b < 50) { answer = 4; + } else if (50 <= b) { + answer = 5; } } - UMA_HISTOGRAM_EXACT_LINEAR("Brave.Rewards.WalletBalance.2", answer, 4); + UMA_HISTOGRAM_EXACT_LINEAR("Brave.Rewards.WalletBalance.3", answer, 6); } void RecordAutoContributionsState(AutoContributionsState state, int count) { @@ -93,7 +95,7 @@ void RecordAutoContributionsState(AutoContributionsState state, int count) { NOTREACHED(); } UMA_HISTOGRAM_EXACT_LINEAR("Brave.Rewards.AutoContributionsState.2", answer, - 5); + 6); } void RecordTipsState(bool wallet_created, @@ -118,7 +120,7 @@ void RecordTipsState(bool wallet_created, answer = 4; } } - UMA_HISTOGRAM_EXACT_LINEAR("Brave.Rewards.TipsState.2", answer, 5); + UMA_HISTOGRAM_EXACT_LINEAR("Brave.Rewards.TipsState.2", answer, 6); } void RecordAdsState(AdsState state) { diff --git a/components/brave_rewards/browser/test/rewards_p3a_browsertest.cc b/components/brave_rewards/browser/test/rewards_p3a_browsertest.cc index e900436f7e0..aeea2a70411 100644 --- a/components/brave_rewards/browser/test/rewards_p3a_browsertest.cc +++ b/components/brave_rewards/browser/test/rewards_p3a_browsertest.cc @@ -173,7 +173,7 @@ IN_PROC_BROWSER_TEST_F(RewardsP3ABrowserTest, RewardsDisabled) { WaitForRewardsInitialization(); - histogram_tester_->ExpectBucketCount("Brave.Rewards.WalletBalance.2", 1, 1); + histogram_tester_->ExpectBucketCount("Brave.Rewards.WalletBalance.3", 1, 1); histogram_tester_->ExpectBucketCount("Brave.Rewards.AutoContributionsState.2", 1, 1); histogram_tester_->ExpectBucketCount("Brave.Rewards.TipsState.2", 1, 1); @@ -338,6 +338,23 @@ IN_PROC_BROWSER_TEST_F(RewardsP3ABrowserTest, histogram_tester_->ExpectBucketCount("Brave.Rewards.WalletState", 5, 1); } +IN_PROC_BROWSER_TEST_F(RewardsP3ABrowserTest, WalletBalanceZeroBAT) { + response_->SetUserFundsBalance(0.0); + + rewards_browsertest_util::StartProcess(rewards_service_); + rewards_browsertest_util::CreateWallet(rewards_service_); + + context_helper_->LoadURL(rewards_browsertest_util::GetRewardsUrl()); + + rewards_service_->SetAutoContributeEnabled(true); + rewards_service_->SetAdsEnabled(true); + + FetchBalance(); + + EXPECT_GT( + histogram_tester_->GetBucketCount("Brave.Rewards.WalletBalance.3", 2), 0); +} + IN_PROC_BROWSER_TEST_F(RewardsP3ABrowserTest, WalletBalanceLessThan10BAT) { response_->SetUserFundsBalance(9.0); @@ -352,7 +369,7 @@ IN_PROC_BROWSER_TEST_F(RewardsP3ABrowserTest, WalletBalanceLessThan10BAT) { FetchBalance(); EXPECT_GT( - histogram_tester_->GetBucketCount("Brave.Rewards.WalletBalance.2", 2), 0); + histogram_tester_->GetBucketCount("Brave.Rewards.WalletBalance.3", 3), 0); } IN_PROC_BROWSER_TEST_F(RewardsP3ABrowserTest, WalletBalanceLessThan50BAT) { @@ -369,7 +386,7 @@ IN_PROC_BROWSER_TEST_F(RewardsP3ABrowserTest, WalletBalanceLessThan50BAT) { FetchBalance(); EXPECT_GT( - histogram_tester_->GetBucketCount("Brave.Rewards.WalletBalance.2", 3), 0); + histogram_tester_->GetBucketCount("Brave.Rewards.WalletBalance.3", 4), 0); } IN_PROC_BROWSER_TEST_F(RewardsP3ABrowserTest, WalletBalanceMoreThan50BAT) { @@ -386,7 +403,7 @@ IN_PROC_BROWSER_TEST_F(RewardsP3ABrowserTest, WalletBalanceMoreThan50BAT) { FetchBalance(); EXPECT_GT( - histogram_tester_->GetBucketCount("Brave.Rewards.WalletBalance.2", 4), 0); + histogram_tester_->GetBucketCount("Brave.Rewards.WalletBalance.3", 5), 0); } } // namespace rewards_browsertest diff --git a/components/p3a/brave_p3a_service.cc b/components/p3a/brave_p3a_service.cc index cf4c71baeb0..2a5a26262ee 100644 --- a/components/p3a/brave_p3a_service.cc +++ b/components/p3a/brave_p3a_service.cc @@ -84,7 +84,7 @@ constexpr const char* kCollectedHistograms[] = { "Brave.Rewards.AutoContributionsState.2", "Brave.Rewards.TipsState.2", "Brave.Rewards.EnabledDuration", - "Brave.Rewards.WalletBalance.2", + "Brave.Rewards.WalletBalance.3", "Brave.Rewards.WalletState", "Brave.Savings.BandwidthSavingsMB", "Brave.Search.DefaultEngine.4",