From 58c18ba327d4af7cdde990f5c7f2ebffc8b2f49e Mon Sep 17 00:00:00 2001 From: mkarolin Date: Tue, 8 Aug 2023 20:48:49 -0400 Subject: [PATCH 1/2] Extend obsolete OS version infobar to macOS. --- app/brave_generated_resources.grd | 11 ++++++++++- browser/ui/BUILD.gn | 4 ++-- .../chrome/browser/ui/startup/infobar_utils.cc | 6 +++--- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/app/brave_generated_resources.grd b/app/brave_generated_resources.grd index b23e7aa9f14..ccb70948fec 100644 --- a/app/brave_generated_resources.grd +++ b/app/brave_generated_resources.grd @@ -629,14 +629,23 @@ Or change later at $2brave://settings/ext No thanks - + Don't show again + + By clicking OK, you acknowledge that your installation of Brave will NOT receive critical security fixes until you update to Windows 10 or later. This warning will NOT show again. + + + By clicking OK, you acknowledge that your installation of Brave will NOT receive critical security fixes until you update to macOS 10.15 or later. This warning will NOT show again. + + + + Remove from list diff --git a/browser/ui/BUILD.gn b/browser/ui/BUILD.gn index 1f3f3f0a71a..509aebbba26 100644 --- a/browser/ui/BUILD.gn +++ b/browser/ui/BUILD.gn @@ -425,8 +425,8 @@ source_set("ui") { ] } - # brave's obsolete infobar is only used on Windows now. - if (is_win) { + # brave's obsolete infobar is only used on Windows and Mac now. + if (is_win || is_mac) { sources += [ "startup/brave_obsolete_system_infobar_delegate.cc", "startup/brave_obsolete_system_infobar_delegate.h", diff --git a/chromium_src/chrome/browser/ui/startup/infobar_utils.cc b/chromium_src/chrome/browser/ui/startup/infobar_utils.cc index 705933d1a48..fb7c1573ad6 100644 --- a/chromium_src/chrome/browser/ui/startup/infobar_utils.cc +++ b/chromium_src/chrome/browser/ui/startup/infobar_utils.cc @@ -9,7 +9,7 @@ #include "chrome/browser/ui/startup/google_api_keys_infobar_delegate.h" #include "components/infobars/content/content_infobar_manager.h" -#if BUILDFLAG(IS_WIN) +#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC) #include "chrome/browser/ui/startup/obsolete_system_infobar_delegate.h" #endif @@ -23,13 +23,13 @@ class BraveGoogleKeysInfoBarDelegate { #define ShowIfNotOffTheRecordProfile ShowIfNotOffTheRecordProfileBrave #define GoogleApiKeysInfoBarDelegate BraveGoogleKeysInfoBarDelegate -#if BUILDFLAG(IS_WIN) +#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC) #define ObsoleteSystemInfoBarDelegate BraveObsoleteSystemInfoBarDelegate #endif #include "src/chrome/browser/ui/startup/infobar_utils.cc" -#if BUILDFLAG(IS_WIN) +#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC) #undef ObsoleteSystemInfoBarDelegate #endif From 91717c3f292a281113742a0838337e5c77569ee7 Mon Sep 17 00:00:00 2001 From: mkarolin Date: Wed, 9 Aug 2023 20:36:48 -0400 Subject: [PATCH 2/2] Updates obsolete OS version infobar Learn more link for macOS. --- chromium_src/chrome/common/url_constants.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chromium_src/chrome/common/url_constants.cc b/chromium_src/chrome/common/url_constants.cc index d15f02ab741..0f94e9ca30d 100644 --- a/chromium_src/chrome/common/url_constants.cc +++ b/chromium_src/chrome/common/url_constants.cc @@ -246,7 +246,7 @@ const char kChromeEnterpriseSignInLearnMoreURL[] = const char kMacOsObsoleteURL[] = "https://support.brave.com/hc/en-us/articles/" - "360025390311-How-do-I-download-and-install-Brave-"; + "18347246446733-Changes-to-macOS-desktop-browser-requirements"; #endif #if BUILDFLAG(IS_WIN)