From 3b0f99edcfd35da2c8fb6808aafbe5b7589762b8 Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Fri, 10 Apr 2026 12:30:50 +0100 Subject: [PATCH] [cr149] Rely on `//chrome/browser/ui/test:dialog` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This the componentisation of these files, we do not need anymore to include these sources ourselves in `brave_browser_tests`. Chromium changes: https://chromium.googlesource.com/chromium/src/+/e0cd9afb25e911c62c8c096ef55816bd9e3b665e commit e0cd9afb25e911c62c8c096ef55816bd9e3b665e Author: Tiago Vignatti Date: Thu Apr 9 07:28:31 2026 -0700 Componentize chrome/browser/ui/test/ This changes create chrome/browser/ui/test/BUILD.gn with dedicated targets for all test files in this directory, which were previously scattered across chrome/test/BUILD.gn and chrome/browser/ui/BUILD.gn. Some of the files were duplicated in multiple targets, and has now fixed. New targets: - :dialog — moved from //chrome/test:test_support and de-duplicated from browser_tests/interactive_ui_tests - :closed_waiter — moved from //chrome/test:test_support_ui - :test_support — de-duplicated and moved from browser_tests, interactive_ui_tests, and //chrome/browser/ui:test_support - :confirm_bubble — moved from //chrome/browser/ui:test_support - :browser_tests — browser test files - :interactive_ui_tests — interactive UI test files - :app_window — moved from //chrome/browser/ui:test_support Bug: 353332589 Change-Id: I602615d0b8a96af88af82cf1caaf75a3a2184d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7704138 Reviewed-by: Darryl James Commit-Queue: Tiago Vignatti Cr-Commit-Position: refs/heads/main@{#1612208} --- android/android_browser_tests.gni | 4 ---- test/BUILD.gn | 4 ---- 2 files changed, 8 deletions(-) diff --git a/android/android_browser_tests.gni b/android/android_browser_tests.gni index a649cca7ecb..47bbaa1e124 100644 --- a/android/android_browser_tests.gni +++ b/android/android_browser_tests.gni @@ -50,10 +50,6 @@ android_test_exception_sources = [ "//chrome/browser/extensions/extension_browsertest.h", "//chrome/browser/media/media_browsertest.cc", "//chrome/browser/media/media_browsertest.h", - "//chrome/browser/ui/test/test_browser_dialog.cc", - "//chrome/browser/ui/test/test_browser_dialog.h", - "//chrome/browser/ui/test/test_browser_ui.cc", - "//chrome/browser/ui/test/test_browser_ui.h", ] if (enable_brave_wallet) { diff --git a/test/BUILD.gn b/test/BUILD.gn index 7343c435d86..d9056cbc372 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -939,10 +939,6 @@ test("brave_browser_tests") { "//chrome/browser/extensions/extension_browsertest.h", "//chrome/browser/media/media_browsertest.cc", "//chrome/browser/media/media_browsertest.h", - "//chrome/browser/ui/test/test_browser_dialog.cc", - "//chrome/browser/ui/test/test_browser_dialog.h", - "//chrome/browser/ui/test/test_browser_ui.cc", - "//chrome/browser/ui/test/test_browser_ui.h", ] deps = [