From 3caaa1e17f85be9bdc282c8e53dedd28e4642ec5 Mon Sep 17 00:00:00 2001
From: Emerick Rogul <erogul@brave.com>
Date: Thu, 15 Jan 2026 15:04:57 -0500
Subject: [PATCH] [cr145] Fix warnings about redefining computed properties in
 delete browsing data dialog

As upstream continues to work on rearchitecting the delete browsing data dialog,
we encountered the following warnings when visiting the dialog in cr145:

  polymer_bundled.min.js:1 Cannot redefine computed property 'isSyncPaused_'.
  polymer_bundled.min.js:1 Cannot redefine computed property 'hasPassphraseError_'.
  polymer_bundled.min.js:1 Cannot redefine computed property 'hasOtherSyncError_'.
  polymer_bundled.min.js:1 Cannot redefine computed property 'googleSearchHistoryString_'.

This is because we override `properties()` using a spread of the base class
properties, which ends up redefining them.

Remove the spread of base class properties and initialize Brave-specific fields
in the constructor instead. This avoids redeclaring inherited computed
properties, which caused runtime Polymer errors, while keeping TypeScript type
checking happy. The change ensures new instance properties are added safely
without breaking inherited behavior.
---
 ...rave_clear_browsing_data_dialog_behavior.ts | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/browser/resources/settings/brave_clear_browsing_data_dialog/brave_clear_browsing_data_dialog_behavior.ts b/browser/resources/settings/brave_clear_browsing_data_dialog/brave_clear_browsing_data_dialog_behavior.ts
index afb278656fc..4d9076154a5 100644
--- a/browser/resources/settings/brave_clear_browsing_data_dialog/brave_clear_browsing_data_dialog_behavior.ts
+++ b/browser/resources/settings/brave_clear_browsing_data_dialog/brave_clear_browsing_data_dialog_behavior.ts
@@ -35,18 +35,12 @@ extends SettingsClearBrowsingDataDialogElement {
 
   private saveOnExitSettingsCallback_: (() => void) | null = null
 
-  static override get properties() {
-    return {
-      ...SettingsClearBrowsingDataDialogElement.properties,
-      braveRewardsEnabled_: {
-        type: Boolean,
-        value: false,
-      },
-      onClearBraveAdsDataClickHandler_: {
-        type: Function,
-        value: () => {},
-      },
-    }
+  constructor() {
+    super()
+
+    // Initialize new properties
+    this.braveRewardsEnabled_ = false
+    this.onClearBraveAdsDataClickHandler_ = () => {}
   }
 
   override ready() {