Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #19930 from brave/app_links_settings_update

Browse Source 
enable app links for all users
This commit is contained in:
Deep Pandya
2023-08-29 23:10:26 -04:00
committed by GitHub
parent 526ad8f3de c938282775
commit 4e721fb2fa
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/app/BraveActivity.java
+12
View File
@@ -1080,6 +1080,18 @@ public abstract class BraveActivity extends ChromeActivity
&& UrlUtilities.isNTPUrl(getActivityTab().getUrl().getSpec())) {
showSearchBoxTooltip();
}
// Added to reset app links settings for upgrade case
if (!PackageUtils.isFirstInstall(this)
&& !SharedPreferencesManager.getInstance().readBoolean(
BravePrivacySettings.PREF_APP_LINKS, true)
&& SharedPreferencesManager.getInstance().readBoolean(
BravePrivacySettings.PREF_APP_LINKS_RESET, true)) {
SharedPreferencesManager.getInstance().writeBoolean(
BravePrivacySettings.PREF_APP_LINKS, true);
SharedPreferencesManager.getInstance().writeBoolean(
BravePrivacySettings.PREF_APP_LINKS_RESET, false);
}
}
private void handleDeepLinkVpn() {
android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java
+3 -1
View File
@@ -86,6 +86,7 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
private static final String PREF_BRAVE_STATS_USAGE_PING = "brave_stats_usage_ping";
private static final String PREF_SEARCH_SUGGESTIONS = "search_suggestions";
public static final String PREF_APP_LINKS = "app_links";
public static final String PREF_APP_LINKS_RESET = "app_links_reset";
private static final String PREF_SHOW_AUTOCOMPLETE_IN_ADDRESS_BAR =
"show_autocomplete_in_address_bar";
private static final String PREF_AUTOCOMPLETE_TOP_SITES = "autocomplete_top_sites";
@@ -347,7 +348,6 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
mAppLinks = (ChromeSwitchPreference) findPreference(PREF_APP_LINKS);
mAppLinks.setOnPreferenceChangeListener(this);
// Added mainly for upgrade case
boolean isAppLinksAllowed =
SharedPreferencesManager.getInstance().readBoolean(PREF_APP_LINKS, true);
mAppLinks.setChecked(isAppLinksAllowed);
@@ -589,6 +589,8 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
sharedPreferencesEditor.putBoolean(PREF_CLEAR_ON_EXIT, (boolean) newValue);
} else if (PREF_APP_LINKS.equals(key)) {
sharedPreferencesEditor.putBoolean(PREF_APP_LINKS, (boolean) newValue);
SharedPreferencesManager.getInstance().writeBoolean(
BravePrivacySettings.PREF_APP_LINKS_RESET, false);
} else if (PREF_BLOCK_TRACKERS_ADS.equals(key)) {
if (newValue instanceof String) {
final String newStringValue = String.valueOf(newValue);