From 3ac74c1e44593e6c71c04ec61e685cc6f0559448 Mon Sep 17 00:00:00 2001 From: Sujit Acharya Date: Thu, 27 Oct 2022 21:02:17 +0530 Subject: [PATCH 1/2] Tipping banner UI issue fix for tablet --- android/java/res/layout/brave_rewards_creator_panel.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/java/res/layout/brave_rewards_creator_panel.xml b/android/java/res/layout/brave_rewards_creator_panel.xml index 4a88fc09357..6189494ea78 100644 --- a/android/java/res/layout/brave_rewards_creator_panel.xml +++ b/android/java/res/layout/brave_rewards_creator_panel.xml @@ -3,7 +3,7 @@ xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" - android:layout_height="wrap_content" + android:layout_height="match_parent" android:background="@drawable/creator_background" android:paddingStart="36dp" android:paddingTop="36dp" From 5ef642d82624db36d7a50ecd9d004f003f6b4666 Mon Sep 17 00:00:00 2001 From: Sujit Acharya Date: Fri, 28 Oct 2022 16:18:08 +0530 Subject: [PATCH 2/2] Text update Monthly tip case show Tip amount --- .../browser/rewards/BraveRewardsTipConfirmationFragment.java | 2 ++ browser/ui/android/strings/android_brave_strings.grd | 3 +++ 2 files changed, 5 insertions(+) diff --git a/android/java/org/chromium/chrome/browser/rewards/BraveRewardsTipConfirmationFragment.java b/android/java/org/chromium/chrome/browser/rewards/BraveRewardsTipConfirmationFragment.java index a9dfde9fd55..e577a16a31c 100644 --- a/android/java/org/chromium/chrome/browser/rewards/BraveRewardsTipConfirmationFragment.java +++ b/android/java/org/chromium/chrome/browser/rewards/BraveRewardsTipConfirmationFragment.java @@ -99,6 +99,8 @@ public class BraveRewardsTipConfirmationFragment extends Fragment implements Bra mNextTipDateValue = view.findViewById(R.id.next_tip_date_value); if (monthlyContribution) { + TextView tipAmountText = view.findViewById(R.id.tip_amount_text); + tipAmountText.setText(R.string.tip_amount_text); tipTypeDescriptionTextView.setText( getResources().getString(R.string.your_monthly_tip_has_been_sent)); } else { diff --git a/browser/ui/android/strings/android_brave_strings.grd b/browser/ui/android/strings/android_brave_strings.grd index cbd8fb0fb9b..205da862cdc 100644 --- a/browser/ui/android/strings/android_brave_strings.grd +++ b/browser/ui/android/strings/android_brave_strings.grd @@ -143,6 +143,9 @@ This file contains all "about" strings. It is set to NOT be translated, in tran + + Tip amount: + Enable/Disable Brave Shields