From 59661f743b1ecef845b7bf2fe8fdec9a8475f512 Mon Sep 17 00:00:00 2001
From: Mihai PLESA <mplesa@brave.com>
Date: Mon, 4 Aug 2025 15:06:13 +0100
Subject: [PATCH] allow nodejs v24 (#30405)

* allow nodejs v24
---
 package-lock.json | 30 +-----------------------------
 package.json      |  9 ++++-----
 2 files changed, 5 insertions(+), 34 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 49571ce51aa..c54f9c5cbdc 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -85,7 +85,6 @@
         "buffer": "6.0.3",
         "chalk": "4.1.2",
         "commander": "2.20.3",
-        "cross-env": "7.0.3",
         "crypto-browserify": "3.12.0",
         "css-loader": "5.2.7",
         "csstype": "2.6.21",
@@ -151,7 +150,7 @@
         "webpack-cli": "5.1.4"
       },
       "engines": {
-        "node": ">=20.0.0 <23.0.0",
+        "node": ">=20.0.0 <25.0.0",
         "npm": ">=10.0.0"
       }
     },
@@ -8594,24 +8593,6 @@
         "sha.js": "^2.4.8"
       }
     },
-    "node_modules/cross-env": {
-      "version": "7.0.3",
-      "resolved": "https://registry.npmjs.org/cross-env/-/cross-env-7.0.3.tgz",
-      "integrity": "sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==",
-      "dev": true,
-      "dependencies": {
-        "cross-spawn": "^7.0.1"
-      },
-      "bin": {
-        "cross-env": "src/bin/cross-env.js",
-        "cross-env-shell": "src/bin/cross-env-shell.js"
-      },
-      "engines": {
-        "node": ">=10.14",
-        "npm": ">=6",
-        "yarn": ">=1"
-      }
-    },
     "node_modules/cross-fetch": {
       "version": "4.0.0",
       "resolved": "https://registry.npmjs.org/cross-fetch/-/cross-fetch-4.0.0.tgz",
@@ -28132,15 +28113,6 @@
         "sha.js": "^2.4.8"
       }
     },
-    "cross-env": {
-      "version": "7.0.3",
-      "resolved": "https://registry.npmjs.org/cross-env/-/cross-env-7.0.3.tgz",
-      "integrity": "sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==",
-      "dev": true,
-      "requires": {
-        "cross-spawn": "^7.0.1"
-      }
-    },
     "cross-fetch": {
       "version": "4.0.0",
       "resolved": "https://registry.npmjs.org/cross-fetch/-/cross-fetch-4.0.0.tgz",
diff --git a/package.json b/package.json
index d80c393a06e..eb5f29502ef 100644
--- a/package.json
+++ b/package.json
@@ -29,7 +29,7 @@
     "mass_rename": "node ./build/commands/scripts/commands.js mass_rename",
     "docs": "node ./build/commands/scripts/commands.js docs",
     "test": "node ./build/commands/scripts/commands.js test",
-    "test:scripts": "cross-env NODE_OPTIONS=--no-experimental-fetch jest build/commands/lib build/commands/scripts",
+    "test:scripts": "jest build/commands/lib build/commands/scripts",
     "tslint": "npm run eslint",
     "eslint": "eslint ./components ./build",
     "pep8": "pycodestyle --max-line-length 120 -r script",
@@ -38,8 +38,8 @@
     "web-ui": "webpack --config components/webpack/webpack.config.js",
     "build-storybook": "npm run build -- --target=brave:storybook && storybook build -c .storybook -o .storybook-out",
     "storybook": "storybook dev",
-    "test-unit": "cross-env NODE_OPTIONS=--no-experimental-fetch jest -t",
-    "test-unit:wallet": "cross-env NODE_OPTIONS=--no-experimental-fetch jest --coverage=false components/brave_wallet_ui",
+    "test-unit": "jest -t",
+    "test-unit:wallet": "jest --coverage=false components/brave_wallet_ui",
     "test-python-scripts": "npm run pep8 && PYTHONPATH=./script python -m unittest discover -s ./script/test",
     "update_symlink": "node ./build/commands/scripts/commands.js update_symlink",
     "build_fuzzer": "node ./build/commands/scripts/commands.js build_fuzzer",
@@ -65,7 +65,7 @@
     "url": "https://github.com/brave/brave-browser/issues"
   },
   "engines": {
-    "node": ">=20.0.0 <23.0.0",
+    "node": ">=20.0.0 <25.0.0",
     "npm": ">=10.0.0"
   },
   "homepage": "https:/github.com/brave/brave-core#readme",
@@ -120,7 +120,6 @@
     "buffer": "6.0.3",
     "chalk": "4.1.2",
     "commander": "2.20.3",
-    "cross-env": "7.0.3",
     "crypto-browserify": "3.12.0",
     "css-loader": "5.2.7",
     "csstype": "2.6.21",