From 611ecdf354ff22d3c2b135ece7162e8ca1569741 Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Wed, 22 Apr 2026 12:10:06 +0100 Subject: [PATCH] [cr149] `//chrome/browser/first_run` modularised Chromium changes: https://chromium.googlesource.com/chromium/src/+/03702156827220b6df76964a262caf312e8fa0f4 commit 03702156827220b6df76964a262caf312e8fa0f4 Author: Keybo Qian Date: Fri Apr 17 12:00:06 2026 -0700 Modularize //chrome/browser/first_run Extract the `first_run` feature out of the monolithic `//chrome/browser` and `//chrome/test` targets into its own dedicated `BUILD.gn` file. - Extracts prod code, `unit_tests`, and `browser_tests` into `//chrome/browser/first_run/BUILD.gn`. - Adds a `DEPS` file to enforce strict dependency boundaries. - Extracts `scoped_relaunch_chrome_browser_override` to a `test_support` target. - Guards `browser_tests` with `!is_android` to fix compile failures. - Adds temporary circular include exceptions to unblock the extraction. This refactoring is part of the ongoing effort to break down the Chrome browser monolith, which helps improve build times, enforces stricter dependency boundaries, and makes the codebase easier to maintain. Cq-Include-Trybots: luci.chromium.try:android-cast-arm-rel Bug: 500390199 Change-Id: I2d62edb19cfe1b1f241e21fe31e9cae7df974e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7763734 Reviewed-by: Dana Fried Auto-Submit: Keybo Qian Commit-Queue: Keybo Qian Cr-Commit-Position: refs/heads/main@{#1616736} --- browser/brave_rewards/test/BUILD.gn | 1 + browser/brave_stats/BUILD.gn | 1 + browser/ui/BUILD.gn | 1 + browser/ui/sidebar/BUILD.gn | 1 + browser/upgrade_when_idle/BUILD.gn | 1 + 5 files changed, 5 insertions(+) diff --git a/browser/brave_rewards/test/BUILD.gn b/browser/brave_rewards/test/BUILD.gn index e8a7e6aa1a6..da676381a56 100644 --- a/browser/brave_rewards/test/BUILD.gn +++ b/browser/brave_rewards/test/BUILD.gn @@ -66,6 +66,7 @@ source_set("browser_tests") { "//brave/components/brave_rewards/core/mojom:engine", "//brave/components/l10n/common:test_support", "//brave/components/ntp_background_images/common", + "//chrome/browser/first_run", "//chrome/browser/ui/browser_window", "//components/policy/core/browser", "//components/policy/core/common:test_support", diff --git a/browser/brave_stats/BUILD.gn b/browser/brave_stats/BUILD.gn index a9d327ad80a..55188569ede 100644 --- a/browser/brave_stats/BUILD.gn +++ b/browser/brave_stats/BUILD.gn @@ -55,6 +55,7 @@ source_set("brave_stats") { "//brave/components/serp_metrics:prefs", "//brave/components/version_info", "//chrome/browser:browser_process", + "//chrome/browser/first_run", "//chrome/browser/headless", "//chrome/browser/profiles:profile", "//chrome/browser/profiles:profile_manager", diff --git a/browser/ui/BUILD.gn b/browser/ui/BUILD.gn index ab48462b586..f0a8e839f99 100644 --- a/browser/ui/BUILD.gn +++ b/browser/ui/BUILD.gn @@ -432,6 +432,7 @@ source_set("ui") { "//chrome/browser/content_settings:content_settings_factory", "//chrome/browser/contextual_search", "//chrome/browser/favicon", + "//chrome/browser/first_run", "//chrome/browser/importer", "//chrome/browser/profiles", "//chrome/browser/search", diff --git a/browser/ui/sidebar/BUILD.gn b/browser/ui/sidebar/BUILD.gn index a36803d061e..c05200527aa 100644 --- a/browser/ui/sidebar/BUILD.gn +++ b/browser/ui/sidebar/BUILD.gn @@ -55,6 +55,7 @@ source_set("sidebar_impl") { "//brave/components/sidebar/common", "//chrome/browser:browser_process", "//chrome/browser/favicon", + "//chrome/browser/first_run", "//chrome/browser/history", "//chrome/browser/image_fetcher", "//chrome/browser/profiles", diff --git a/browser/upgrade_when_idle/BUILD.gn b/browser/upgrade_when_idle/BUILD.gn index 08899b2261d..0d3a6ddcf57 100644 --- a/browser/upgrade_when_idle/BUILD.gn +++ b/browser/upgrade_when_idle/BUILD.gn @@ -13,6 +13,7 @@ source_set("upgrade_when_idle") { # here because it would create a dependency cycle. deps = [ "//base", + "//chrome/browser/first_run", "//chrome/browser/profiles:profile_manager", "//chrome/browser/ui/browser_window", "//chrome/browser/upgrade_detector",