[cr149][Android] Changes for optional button on LocationBar
Chromium changes: https://chromium.googlesource.com/chromium/src/+/2d803238f4a71a73decc73a5ec682070f1401750 commit 2d803238f4a71a73decc73a5ec682070f1401750 Author: Calder Kitagawa <ckitagawa@chromium.org> Date: Tue Apr 28 18:00:59 2026 -0700 [IA] Move optional button to LocationBar - Create an OptionalButtonCoordinator in LocationBarCoordinator for phones only. - Add logic to show/hide new optional button dynamically. - Update ToolbarPhone to proxy calls into LocationBar except on the NTP. On the NTP the identity disk is still presented in the optional button. Will refactor post-launch. Bug: 491511644 Change-Id: I81a485c1fa93420c661984523cb0367f737d87be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7793280 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/main@{#1622145}
This commit is contained in:
@@ -35,6 +35,7 @@ import org.chromium.chrome.browser.toolbar.bottom.BottomToolbarConfiguration;
|
||||
import org.chromium.chrome.browser.toolbar.menu_button.BraveMenuButtonCoordinator;
|
||||
import org.chromium.chrome.browser.ui.edge_to_edge.TopInsetProvider;
|
||||
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
|
||||
import org.chromium.chrome.browser.user_education.UserEducationHelper;
|
||||
import org.chromium.components.browser_ui.accessibility.PageZoomManager;
|
||||
import org.chromium.ui.base.WindowAndroid;
|
||||
import org.chromium.ui.modaldialog.ModalDialogManager;
|
||||
@@ -100,7 +101,8 @@ public class BraveLocationBarCoordinator extends LocationBarCoordinator {
|
||||
SnackbarManager snackbarManager,
|
||||
View bottomContainerView,
|
||||
@Nullable OmniboxChipManager omniboxChipManager,
|
||||
@Nullable LocationBarFocusScrimHandler scrimHandler) {
|
||||
@Nullable LocationBarFocusScrimHandler scrimHandler,
|
||||
@Nullable UserEducationHelper userEducationHelper) {
|
||||
super(
|
||||
locationBarLayout,
|
||||
autocompleteAnchorView,
|
||||
@@ -142,7 +144,8 @@ public class BraveLocationBarCoordinator extends LocationBarCoordinator {
|
||||
snackbarManager,
|
||||
bottomContainerView,
|
||||
omniboxChipManager,
|
||||
scrimHandler);
|
||||
scrimHandler,
|
||||
userEducationHelper);
|
||||
|
||||
if (mUrlBar != null) {
|
||||
((UrlBar) mUrlBar).setSelectAllOnFocus(true);
|
||||
|
||||
Reference in New Issue
Block a user