From 645e789a84656deef435782917fa1a414930b25a Mon Sep 17 00:00:00 2001 From: Artem Samoilenko Date: Thu, 23 Apr 2026 11:21:26 -0400 Subject: [PATCH] [cr149][Android] Remove getSetupInProgressHandle() Chromium changes: https://chromium.googlesource.com/chromium/src/+/24cc34c57c5013cf7e27d1c9319cd506770b6477 commit 24cc34c57c5013cf7e27d1c9319cd506770b6477 Author: Victor Hugo Vianna Silva Date: Tue Apr 21 05:19:50 2026 -0700 [sync/android] Remove getSetupInProgressHandle() There was only one remaining call. It was originally added for the "advanced sync setup" flow, to ensure sync only started after the user confirmed data type settings (thus preventing an irreversible upload of unwanted data). That flow doesn't exist anymore, since existing data is not uploaded when the user signs in. So the call is removed. Strictly speaking, there is a chance this changes behavior, as the call was done for both syncing and signed-in users. But if that's the case, it's a bug to be fixed separately. Notice this function doesn't exist on iOS anymore. Bug: 40066949 Change-Id: I6aacd39823972c5bc1b7181a9f1a52f57a62eba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7771958 Commit-Queue: Victor Vianna Reviewed-by: Mahmoud Rashad Cr-Commit-Position: refs/heads/main@{#1618071} --- .../browser/sync/BraveManageSyncSettingsTest.java | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/android/javatests/org/chromium/chrome/browser/sync/BraveManageSyncSettingsTest.java b/android/javatests/org/chromium/chrome/browser/sync/BraveManageSyncSettingsTest.java index 291116adbb0..8ad7f87790d 100644 --- a/android/javatests/org/chromium/chrome/browser/sync/BraveManageSyncSettingsTest.java +++ b/android/javatests/org/chromium/chrome/browser/sync/BraveManageSyncSettingsTest.java @@ -64,21 +64,6 @@ public class BraveManageSyncSettingsTest { void syncPasswordsOverridden(Boolean isChromeOS, Boolean handlerShouldBeOverridden) { setupMockSyncService(); - // The next line triggers presubmit warning - // Banned functions were used. - // ... - // It is safe to ignore this warning if you are just moving an existing - // call, or if you want special handling for users in the legacy state. - // Support the legacy state is the case for Brave Sync - when(mSyncService.hasSyncConsent()).thenReturn(true); - - when(mSyncService.getSetupInProgressHandle()) - .thenReturn( - new SyncService.SyncSetupInProgressHandle() { - @Override - public void close() {} - }); - BraveManageSyncSettings.setIsRunningOnChromeOSForTesting(isChromeOS); BraveManageSyncSettings fragment = startManageSyncPreferences();