From 69c58c7b7c0c8a6abcd4f790835eaa8f74d88c53 Mon Sep 17 00:00:00 2001 From: r0hit0303 Date: Wed, 3 Jun 2026 20:38:29 +0200 Subject: [PATCH] [Tests] Disable failing webgpu tests on Windows (#36963) Windows doesn't seem to have support for webgpu adapter. So we disable these tests for them. Resolves https://github.com/brave/brave-browser/issues/56063, https://github.com/brave/brave-browser/issues/56064, https://github.com/brave/brave-browser/issues/56065, https://github.com/brave/brave-browser/issues/56066 --- .../brave_webgpu_farbling_browsertest.cc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/browser/farbling/brave_webgpu_farbling_browsertest.cc b/browser/farbling/brave_webgpu_farbling_browsertest.cc index 46a938f017a..42e2c3f5ddb 100644 --- a/browser/farbling/brave_webgpu_farbling_browsertest.cc +++ b/browser/farbling/brave_webgpu_farbling_browsertest.cc @@ -163,18 +163,18 @@ INSTANTIATE_TEST_SUITE_P( : "WebGLBalancedFingerprintingProtection_Disabled"; }); -// Windows x64 doesn't have the WebGPU adapter support. -#if BUILDFLAG(IS_WIN) && defined(ARCH_CPU_X86_64) -#define NON_WIN_X64_TEST(test) DISABLED_##test +// Windows doesn't seem to have the WebGPU adapter support. +#if BUILDFLAG(IS_WIN) +#define NON_WIN_TEST(test) DISABLED_##test #else -#define NON_WIN_X64_TEST(test) test +#define NON_WIN_TEST(test) test #endif // Tests that navigator.gpu.requestAdapter() → adapter.info fields (vendor, // architecture, device) are emptied under BALANCED (feature on) and MAXIMUM // farbling, and are returned as-is under OFF and BALANCED (feature off). IN_PROC_BROWSER_TEST_P(BraveWebGPUAdapterInfoTest, - NON_WIN_X64_TEST(FarbleAdapterInfo)) { + NON_WIN_TEST(FarbleAdapterInfo)) { const std::string domain = "a.com"; const GURL url = https_server_.GetURL(domain, "/adapter-info.html"); @@ -212,7 +212,7 @@ IN_PROC_BROWSER_TEST_P(BraveWebGPUAdapterInfoTest, // MAXIMUM farbling, and are returned as-is under OFF and BALANCED (feature // off). IN_PROC_BROWSER_TEST_P(BraveWebGPUAdapterInfoTest, - NON_WIN_X64_TEST(FarbleDeviceAdapterInfo)) { + NON_WIN_TEST(FarbleDeviceAdapterInfo)) { const std::string domain = "a.com"; const GURL url = https_server_.GetURL(domain, "/device-adapter-info.html"); @@ -248,7 +248,7 @@ IN_PROC_BROWSER_TEST_P(BraveWebGPUAdapterInfoTest, // Tests that adapter.info fields (vendor, architecture, device) are NOT // scrubbed under MAXIMUM farbling when WebGPU developer features are enabled. IN_PROC_BROWSER_TEST_F(BraveWebGPUDeveloperFeaturesTest, - NON_WIN_X64_TEST(AdapterInfoNotScrubbed)) { + NON_WIN_TEST(AdapterInfoNotScrubbed)) { const std::string domain = "a.com"; const GURL url = https_server_.GetURL(domain, "/adapter-info.html"); @@ -273,7 +273,7 @@ IN_PROC_BROWSER_TEST_F(BraveWebGPUDeveloperFeaturesTest, // Tests that device.adapterInfo fields (vendor, architecture, device) are NOT // scrubbed under MAXIMUM farbling when WebGPU developer features are enabled. IN_PROC_BROWSER_TEST_F(BraveWebGPUDeveloperFeaturesTest, - NON_WIN_X64_TEST(DeviceAdapterInfoNotScrubbed)) { + NON_WIN_TEST(DeviceAdapterInfoNotScrubbed)) { const std::string domain = "a.com"; const GURL url = https_server_.GetURL(domain, "/device-adapter-info.html");