From 6a680adf32a00a416b61703b868f7cd7d817c66d Mon Sep 17 00:00:00 2001 From: AlexeyBarabash Date: Thu, 2 Apr 2026 01:15:02 +0300 Subject: [PATCH] [cr148][Android] DropdownCommonProperties removed SuggestionCommonProperties is used instead Chromium change: https://source.chromium.org/chromium/chromium/src/+/fdf1ac3a145796f9cb1e3c8a72a639506d18a6e0 commit fdf1ac3a145796f9cb1e3c8a72a639506d18a6e0 Author: Charles Cai Date: Mon Mar 30 17:42:35 2026 -0700 Refactor Omnibox suggestion properties into a single common class This CL merges `DropdownCommonProperties` into `SuggestionCommonProperties`. This unifies the property definitions for Omnibox suggestions into a single location to simplify property model management. This is a pure data-layer refactoring that prepares the architecture for migrating UI elements like headers and group separators to ItemDecorations. Bug: 491220357 Change-Id: Ie531dc38e9e53b5829060ae1a7f49c014061f409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7708772 Commit-Queue: Charles Cai Reviewed-by: Tomasz Wiszkowski Reviewed-by: Sky Malice Cr-Commit-Position: refs/heads/main@{#1607509} --- .../BraveDropdownItemViewInfoListBuilder.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/BraveDropdownItemViewInfoListBuilder.java b/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/BraveDropdownItemViewInfoListBuilder.java index 44ea360de9f..43a577bdb20 100644 --- a/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/BraveDropdownItemViewInfoListBuilder.java +++ b/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/BraveDropdownItemViewInfoListBuilder.java @@ -163,16 +163,17 @@ class BraveDropdownItemViewInfoListBuilder extends DropdownItemViewInfoListBuild viewInfoList .get(viewInfoList.size() - 1) .model - .set(DropdownCommonProperties.BG_BOTTOM_CORNER_ROUNDED, false); + .set(SuggestionCommonProperties.BG_BOTTOM_CORNER_ROUNDED, false); viewInfoList .get(viewInfoList.size() - 1) .model - .set(DropdownCommonProperties.SHOW_DIVIDER, true); + .set(SuggestionCommonProperties.SHOW_DIVIDER, true); } - leoModel.set(DropdownCommonProperties.BG_TOP_CORNER_ROUNDED, viewInfoList.size() == 0); - leoModel.set(DropdownCommonProperties.BG_BOTTOM_CORNER_ROUNDED, true); - leoModel.set(DropdownCommonProperties.SHOW_DIVIDER, false); + leoModel.set( + SuggestionCommonProperties.BG_TOP_CORNER_ROUNDED, viewInfoList.size() == 0); + leoModel.set(SuggestionCommonProperties.BG_BOTTOM_CORNER_ROUNDED, true); + leoModel.set(SuggestionCommonProperties.SHOW_DIVIDER, false); viewInfoList.add( tileNavSuggestPosition,