From 6d04aa2e45fe4ccb03f475e2eaf07b03670ff08b Mon Sep 17 00:00:00 2001 From: AlexeyBarabash Date: Fri, 17 Apr 2026 23:09:44 +0300 Subject: [PATCH] Revert "[Android] Suppressed false-positive *ForTesting() warning" This reverts commit 32d066b5936217c6f3a9cf92fc7166cfe35a6fb8. --- .../chrome/browser/signin/services/BraveSigninManager.java | 2 +- chromium_presubmit_config.json5 | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/BraveSigninManager.java b/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/BraveSigninManager.java index b87e7ea15f2..f4171178ee1 100644 --- a/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/BraveSigninManager.java +++ b/browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/BraveSigninManager.java @@ -106,7 +106,7 @@ public class BraveSigninManager implements SigninManager { @SigninAccessPoint int accessPoint, @Nullable SignInCallback callback) {} - @Override + @Deprecated public void turnOnSyncForTesting( CoreAccountInfo coreAccountInfo, @SigninAccessPoint int accessPoint) {} diff --git a/chromium_presubmit_config.json5 b/chromium_presubmit_config.json5 index 61bacbbf29b..3e4d4a9e991 100644 --- a/chromium_presubmit_config.json5 +++ b/chromium_presubmit_config.json5 @@ -176,11 +176,6 @@ "CheckStableMojomChanges": [ "components/brave_rewards/core/mojom/.*\\.mojom", ], - // BraveSigninManager implements the SigninManager interface which defines - // turnOnSyncForTesting as a deprecated method, forcing this override. - "CheckNoProductionCodeUsingTestOnlyFunctionsJava": [ - "browser/signin/services/android/java/src/org/chromium/chrome/browser/signin/services/BraveSigninManager\\.java", - ], // TODO(alexeybarabash): https://github.com/brave/brave-browser/issues/45245 "_CheckAndroidNullAwayAnnotatedClasses": [ "android/java/org/chromium/chrome/browser/app/BraveActivity.java",