Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(wallet): bubble up ApproveTransaction error message to clients

Browse Source
This commit is contained in:
Anirudha Bose
2022-02-16 16:17:00 +05:30
parent bece65622a
commit 6d3596e5fc
8 changed files with 86 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/crypto_wallet/fragments/ApproveTxBottomSheetDialogFragment.java
+4 -1
View File
@@ -37,6 +37,7 @@ import org.chromium.brave_wallet.mojom.BraveWalletService;
import org.chromium.brave_wallet.mojom.CoinType;
import org.chromium.brave_wallet.mojom.EthereumChain;
import org.chromium.brave_wallet.mojom.JsonRpcService;
import org.chromium.brave_wallet.mojom.ProviderError;
import org.chromium.brave_wallet.mojom.TransactionInfo;
import org.chromium.brave_wallet.mojom.TransactionType;
import org.chromium.brave_wallet.mojom.TxData;
@@ -352,8 +353,10 @@ public class ApproveTxBottomSheetDialogFragment extends BottomSheetDialogFragmen
if (txService == null) {
return;
}
txService.approveTransaction(CoinType.ETH, mTxInfo.id, success -> {
txService.approveTransaction(CoinType.ETH, mTxInfo.id, (success, error, errorMessage) -> {
assert success;
Utils.warnWhenError(ApproveTxBottomSheetDialogFragment.TAG_FRAGMENT,
"approveTransaction", error, errorMessage);
if (!success) {
return;
}