From 707e40f59a6ea2605ce0de654776e6d83d3f04ef Mon Sep 17 00:00:00 2001 From: Netzenbot Date: Sun, 8 Feb 2026 08:17:50 -0500 Subject: [PATCH] Disable flaky InstallableManagerBrowserTest.CheckFavicon and add ASAN filter support (#33777) Add InstallableManagerBrowserTest.CheckFavicon to browser_tests.filter to disable this flaky upstream test. The test intermittently fails due to favicon fetch timing issues. Already disabled on Mac upstream (crbug.com/333331507). Also add ASAN filter support to getApplicableFilters() in testUtils.js, which was missing (only UBSAN and MSAN were supported). Resolves https://github.com/brave/brave-browser/issues/52659 --- build/commands/lib/testUtils.js | 4 ++++ test/filters/browser_tests.filter | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/build/commands/lib/testUtils.js b/build/commands/lib/testUtils.js index d02c47099cf..4f0841c2346 100644 --- a/build/commands/lib/testUtils.js +++ b/build/commands/lib/testUtils.js @@ -84,6 +84,10 @@ const getApplicableFilters = (config, suite) => { possibleFilters.push([suite, targetPlatform, 'ubsan'].join('-')) } + if (config.is_asan) { + possibleFilters.push([suite, targetPlatform, 'asan'].join('-')) + } + if (config.is_msan) { possibleFilters.push([suite, targetPlatform, 'msan'].join('-')) } diff --git a/test/filters/browser_tests.filter b/test/filters/browser_tests.filter index cf3b36fd9d0..5b4869f9096 100644 --- a/test/filters/browser_tests.filter +++ b/test/filters/browser_tests.filter @@ -3506,3 +3506,8 @@ # covering this - safe to disable the upstream one. # For more info, see https://github.com/brave/brave-browser/issues/46011 -SecureDnsHandlerTest.OtherPoliciesSet + +# https://github.com/brave/brave-browser/issues/52659 +# Flaky favicon fetch failure. Also disabled on Mac upstream +# (crbug.com/333331507). +-InstallableManagerBrowserTest.CheckFavicon