Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr136][Android] Removed tab_resumption_module_container_stub layout

Browse Source 
Related Chromium changes:
https://source.chromium.org/chromium/chromium/src/+/f8de93495c1d5e041d25dfd02d60f03ff1fabeed

	[Android TRM] Remove R.id.tab_resumption_module_container_stub.

	In crrev.com/c/5297855, the Tab Resumption Module was integrated into
	the Magic Stack. Therefore it no longer needs the ViewStub
	R.id.tab_resumption_module_container_stub as the top level layout, but
	it still lingers. This CL deletes the now useless ViewStub.

	Bug: 1515325
	Change-Id: I358b64ef57c267629230578cf8dc5b28af3d7dfc
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5734353

https://source.chromium.org/chromium/chromium/src/+/28cde898edae21f1b807d3e0e43d62701837ac7a

	[Android TRM] Remove feature and most of the code.

	This CL removes the Android Tab Resumption Module:
	* Remove chrome/browser/tab_resumption.
	* Remove flags and configs.
	* Remove 5 UI strings: IDS_TAB_RESUMPTION_MODULE_*,
	  IDS_N_{MINUTES,HOURS}_AGO_NARROW.
	* Remove resources.

	Need to keep for metrics:
	* tools/metrics/histograms/enums.xml entry.

	Out of scope of this CL; TODO in follow-ups:
	* NTP Customization features and tests involving the TRM (will remove in
	  follow-up).
	* Keep IDS_TAB_RESUMPTION_MODULE_SEE_MORE "See more": This got reused by
	  Tab Switcher.
	* Keep IDS_HOME_MODULES_TAB_RESUMPTION_TITLE "Continue with this tab" /
	  "Continue with these tabs": Used by Single Tab Module.

	Unaffected:
	* TRM still exists on Desktop and iOS. Tab data sync from Android
	  continue to work same as before.

	Bug: 400479323, 400479745
	Change-Id: I38cc101c361c761d38dff931b7ab6d15960836fa
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408054
This commit is contained in:
AlexeyBarabash
2025-04-16 09:30:32 +01:00
committed by Claudio DeSouza
parent c22976042d
commit 72b40f7798
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/res/layout/new_tab_page_layout.xml
-9
View File
@@ -149,15 +149,6 @@
android:layout_weight="0"
android:visibility="invisible" />
<ViewStub
android:id="@+id/tab_resumption_module_container_stub"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/mvt_container_top_margin"
android:layout_marginLeft="@dimen/mvt_container_lateral_margin"
android:layout_marginRight="@dimen/mvt_container_lateral_margin"
android:layout="@layout/tab_resumption_module_layout" />
<!-- Spacer for when there is no search provider logo. -->
<View
android:id="@+id/no_search_logo_spacer"