Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #13372 from brave/android-news-settingsbar

Browse Source 
Fixes news settings bar disappears when switching tabs
This commit is contained in:
alexsafe
2022-05-19 22:36:57 +02:00
committed by GitHub
parent 4f79b90268 f2d537694c
commit 7ce370bde3
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
+7 -3
View File
@@ -887,6 +887,10 @@ public class BraveNewTabPageLayout extends NewTabPageLayout implements Connectio
if (mActivity == null) {
mActivity = BraveActivity.getBraveActivity();
}
if (mSettingsBar != null && prevRecyclerViewItemPosition > 0) {
mSettingsBar.setVisibility(View.VISIBLE);
mSettingsBar.setAlpha(0f);
}
keepPosition(
prevScrollPosition, prevRecyclerViewPosition, prevRecyclerViewItemPosition);
}
@@ -1321,7 +1325,6 @@ public class BraveNewTabPageLayout extends NewTabPageLayout implements Connectio
mTouchScroll = true;
mFirstVisibleCard = linearLayoutManager.findFirstVisibleItemPosition();
mParentScrollView.scrollBy(0, offset + 2);
} catch (Exception e) {
Log.e("bn", "Exception onScrolled:" + e);
}
@@ -1639,8 +1642,9 @@ public class BraveNewTabPageLayout extends NewTabPageLayout implements Connectio
.getActivityTab()
.getId(),
0);
if (compositorView.getChildAt(2).getId()
== R.id.news_settings_bar) {
if (mSettingsBar == null
&& compositorView.getChildAt(2).getId()
== R.id.news_settings_bar) {
mSettingsBar = (LinearLayout) compositorView.getChildAt(2);
mSettingsBar.setVisibility(View.INVISIBLE);
mSettingsBar.setAlpha(0f);