From 7e0d78f4f95884d8a35a8ef87c763d6899a0cc42 Mon Sep 17 00:00:00 2001 From: AlexeyBarabash Date: Fri, 16 Jan 2026 15:30:22 +0200 Subject: [PATCH] [cr144][Android] Clipboard arg at BookmarkManagerMediator.ctor Chromium change: https://source.chromium.org/chromium/chromium/src/+/2e92587e809aa11f8d4d8b402127969fa991c46b [Bookmarks] Add bookmark copy link menu item on Android 1. Introduce a Copy link action in the bookmark row menu. 2. Update strings and relevant tests/metrics. 3. Remove unnecessary @Batch annotation to suppress presubmit warning. Design doc: https://docs.google.com/document/d/1zDD-gk01xMioNgL_NTKroxvPW1HnVbPDHIxNQlF-_ZI Bug: 448009940,454406742 Change-Id: I67b48cdb39d6d9f2801ab5157c4dd14ba8925896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7309645 --- .../browser/bookmarks/BraveBookmarkManagerMediator.java | 7 +++++-- .../org/chromium/chrome/browser/BytecodeTest.java | 4 +++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/android/java/org/chromium/chrome/browser/bookmarks/BraveBookmarkManagerMediator.java b/android/java/org/chromium/chrome/browser/bookmarks/BraveBookmarkManagerMediator.java index a0fd4579666..d4b20fb319f 100644 --- a/android/java/org/chromium/chrome/browser/bookmarks/BraveBookmarkManagerMediator.java +++ b/android/java/org/chromium/chrome/browser/bookmarks/BraveBookmarkManagerMediator.java @@ -34,6 +34,7 @@ import org.chromium.components.browser_ui.widget.selectable_list.SelectableListL import org.chromium.components.browser_ui.widget.selectable_list.SelectionDelegate; import org.chromium.components.commerce.core.ShoppingService; import org.chromium.ui.base.ActivityWindowAndroid; +import org.chromium.ui.base.Clipboard; import org.chromium.ui.base.WindowAndroid; import org.chromium.ui.modaldialog.ModalDialogManager; import org.chromium.ui.modelutil.MVCListAdapter.ModelList; @@ -80,7 +81,8 @@ class BraveBookmarkManagerMediator extends BookmarkManagerMediator BooleanSupplier canShowSigninPromo, Consumer onScrollListenerConsumer, BookmarkManagerOpener bookmarkManagerOpener, - PriceDropNotificationManager priceDropNotificationManager) { + PriceDropNotificationManager priceDropNotificationManager, + Clipboard clipboard) { super( activity, lifecycleOwner, @@ -104,7 +106,8 @@ class BraveBookmarkManagerMediator extends BookmarkManagerMediator canShowSigninPromo, onScrollListenerConsumer, bookmarkManagerOpener, - priceDropNotificationManager); + priceDropNotificationManager, + clipboard); } public void setWindow(ActivityWindowAndroid window) { diff --git a/android/javatests/org/chromium/chrome/browser/BytecodeTest.java b/android/javatests/org/chromium/chrome/browser/BytecodeTest.java index 4de75acb963..a62011f6ed8 100644 --- a/android/javatests/org/chromium/chrome/browser/BytecodeTest.java +++ b/android/javatests/org/chromium/chrome/browser/BytecodeTest.java @@ -209,6 +209,7 @@ import org.chromium.content_public.browser.WebContents; import org.chromium.ui.ViewProvider; import org.chromium.ui.base.ActivityResultTracker; import org.chromium.ui.base.ActivityWindowAndroid; +import org.chromium.ui.base.Clipboard; import org.chromium.ui.base.IntentRequestTracker; import org.chromium.ui.base.WindowAndroid; import org.chromium.ui.edge_to_edge.EdgeToEdgeManager; @@ -1990,7 +1991,8 @@ public class BytecodeTest { BooleanSupplier.class, Consumer.class, BookmarkManagerOpener.class, - PriceDropNotificationManager.class)); + PriceDropNotificationManager.class, + Clipboard.class)); Assert.assertTrue( constructorsMatch( "org/chromium/chrome/browser/bookmarks/BookmarkBridge",