From 88fc12d696ec97c2ad53bc0b9badc2fb63f6d005 Mon Sep 17 00:00:00 2001 From: AlexeyBarabash Date: Mon, 19 Jan 2026 17:10:43 +0200 Subject: [PATCH] [cr146][Android] Plumb PromptOptions through PermissionPromptAndroid Chromium change: https://source.chromium.org/chromium/chromium/src/+/d383d17c542efef6c305d73882a540caed0db057 [permissions] Plumb PromptOptions through PermissionPromptAndroid This CL is part of a chain of CLs removing PromptOptions from PermissionRequest and instead plumbing it through the code, see https://crbug.com/465377277 for more context. This CL plumbs PromptOptions through the c++ logic for the permission prompt on Android, delaying the point at which PermissionRequestManager::SetPromptOptions is called, and hence making it easier to remove that method in a later CL. Note how this change highlights immediately that the quiet prompt does not currently allow to choose between approximate and precise location: we would have noticed it right away if we had plumbed the PromptOptions through right away. Bug: 450752868, 430494523, 465377277 Change-Id: I636b8f7be61b18f3bdb6a7a555e68137d4427c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7416297 --- browser/permissions/brave_wallet_permission_prompt_android.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/permissions/brave_wallet_permission_prompt_android.cc b/browser/permissions/brave_wallet_permission_prompt_android.cc index 3fc82846163..1837977ad17 100644 --- a/browser/permissions/brave_wallet_permission_prompt_android.cc +++ b/browser/permissions/brave_wallet_permission_prompt_android.cc @@ -61,7 +61,7 @@ void BraveWalletPermissionPrompt::Delegate::Closing() { if (!permission_prompt_) { return; } - permission_prompt_->Dismiss(); + permission_prompt_->Dismiss(/*prompt_options=*/std::monostate()); } BraveWalletPermissionPrompt::Delegate::~Delegate() {