From 89cb65342117293e8364b8b24af9ca441845d654 Mon Sep 17 00:00:00 2001 From: Jay Harris Date: Tue, 13 Dec 2022 14:49:46 -0800 Subject: [PATCH] Make muting sites easier (#16269) --- app/brave_generated_resources.grd | 12 +++++ app/brave_settings_strings.grdp | 3 ++ browser/brave_profile_prefs.cc | 1 + .../api/settings_private/brave_prefs_util.cc | 2 + .../brave_appearance_page/toolbar.html | 5 ++ browser/ui/tabs/brave_tab_menu_model.cc | 31 +++++++++++-- browser/ui/tabs/brave_tab_menu_model.h | 6 ++- browser/ui/tabs/brave_tab_strip_model.cc | 6 +++ browser/ui/tabs/brave_tab_strip_model.h | 3 ++ .../tabs/brave_tab_context_menu_contents.cc | 46 ++++++++++++++++--- .../tabs/brave_tab_context_menu_contents.h | 1 + ...ave_settings_localized_strings_provider.cc | 2 + .../prefs/pref_service_incognito_allowlist.cc | 3 +- .../ui/views/tabs/alert_indicator_button.cc | 37 +++++++++++++++ .../ui/views/tabs/alert_indicator_button.h | 29 ++++++++++++ components/constants/pref_names.cc | 2 + components/constants/pref_names.h | 1 + 17 files changed, 177 insertions(+), 13 deletions(-) create mode 100644 chromium_src/chrome/browser/ui/views/tabs/alert_indicator_button.cc create mode 100644 chromium_src/chrome/browser/ui/views/tabs/alert_indicator_button.h diff --git a/app/brave_generated_resources.grd b/app/brave_generated_resources.grd index beb74b9b133..d824f8cc942 100644 --- a/app/brave_generated_resources.grd +++ b/app/brave_generated_resources.grd @@ -852,6 +852,12 @@ Or change later at $2brave://settings/ext Float on mouseover + + {NUM_TABS, plural, =1 {Mute tab} other {Mute tabs}} + + + {NUM_TABS, plural, =1 {Unmute tab} other {Unmute tabs}} + @@ -866,6 +872,12 @@ Or change later at $2brave://settings/ext Float on Mouseover + + {NUM_TABS, plural, =1 {Mute Tab} other {Mute Tabs}} + + + {NUM_TABS, plural, =1 {Unmute Tab} other {Unmute Tabs}} + diff --git a/app/brave_settings_strings.grdp b/app/brave_settings_strings.grdp index 1658052b54b..a43d96ceda8 100644 --- a/app/brave_settings_strings.grdp +++ b/app/brave_settings_strings.grdp @@ -1171,6 +1171,9 @@ Close window when closing last tab + + Disable mute function in tab speaker icons +