From 89f4eb930e4699ec8a76c0e3cc2d810a602541f4 Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Fri, 10 Apr 2026 12:39:34 +0100 Subject: [PATCH] [cr149] `String::Substring` renamed to `DeprecatedSubstring` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Chromium changes: https://chromium.googlesource.com/chromium/src/+/c6f8d3ab428ec002d18b29ecd18c0c124b667e87 commit c6f8d3ab428ec002d18b29ecd18c0c124b667e87 Author: Kent Tamura Date: Thu Apr 9 01:44:49 2026 -0700 WTF: Rename String::Substring() to DeprecatedSubstring() * inspector_css_parser_observer.cc: A DCHECK assumes `comment_text` is not empty, so `start_offset` should not be greater than `parsed_text_.length()`. We can use subview(). Bug: 473854537 Change-Id: Ia38b03fd58755e9370037c483bce7bfd5482343e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7740859 Auto-Submit: Kent Tamura Reviewed-by: Fredrik Söderquist Commit-Queue: Fredrik Söderquist Cr-Commit-Position: refs/heads/main@{#1612041} --- .../blink/renderer/core/brave_page_graph/page_graph.cc | 4 ++-- .../blink/renderer/core/farbling/brave_session_cache.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/third_party/blink/renderer/core/brave_page_graph/page_graph.cc b/third_party/blink/renderer/core/brave_page_graph/page_graph.cc index c94983a2075..c22809bddb8 100644 --- a/third_party/blink/renderer/core/brave_page_graph/page_graph.cc +++ b/third_party/blink/renderer/core/brave_page_graph/page_graph.cc @@ -853,7 +853,7 @@ void PageGraph::RegisterPageGraphWebAPICallWithResult( blink::Vector cookie_structure = value.SplitSkippingEmpty('='); String cookie_key = *(cookie_structure.begin()); String cookie_value = - value.Substring(cookie_key.length() + 1, value.length()); + value.DeprecatedSubstring(cookie_key.length() + 1, value.length()); RegisterStorageWrite(execution_context, cookie_key, base::Value(cookie_value.Utf8()), brave_page_graph::StorageLocation::kCookie); @@ -936,7 +936,7 @@ void PageGraph::RegisterPageGraphJavaScriptUrl(blink::Document* document, .script_code = blink::DecodeUrlEscapeSequences( url.GetString(), blink::DecodeUrlMode::kUtf8OrIsomorphic) - .Substring(kJavascriptSchemeLength), + .DeprecatedSubstring(kJavascriptSchemeLength), .parent_script_id = GetExecutingScriptId(execution_context), }); } diff --git a/third_party/blink/renderer/core/farbling/brave_session_cache.cc b/third_party/blink/renderer/core/farbling/brave_session_cache.cc index 3d51fdebfae..18b9df25b28 100644 --- a/third_party/blink/renderer/core/farbling/brave_session_cache.cc +++ b/third_party/blink/renderer/core/farbling/brave_session_cache.cc @@ -405,7 +405,7 @@ bool BraveSessionCache::AllowFontFamily( case BraveFarblingLevel::MAXIMUM: { if (AllowFontByFamilyName( family_name, - blink::DefaultLanguage().GetString().Substring(0, 2))) { + blink::DefaultLanguage().GetString().DeprecatedSubstring(0, 2))) { return true; } if (IsFontAllowedForFarbling(family_name)) {