From 8a10c987c442f50f30fe1142eca8f085488c63f6 Mon Sep 17 00:00:00 2001
From: "Brian R. Bondy" <netzen@gmail.com>
Date: Mon, 6 Aug 2018 17:55:18 -0400
Subject: [PATCH] Test that only brave-extension has access to
 chrome.braveShields

---
 browser/extensions/brave_shields_apitest.cc   | 45 +++++++++++++++++++
 test/BUILD.gn                                 |  8 ++++
 .../api_test/braveShields/background.js       | 14 ++++++
 .../api_test/braveShields/manifest.json       | 13 ++++++
 .../api_test/notBraveShields/background.js    | 13 ++++++
 .../api_test/notBraveShields/manifest.json    | 13 ++++++
 6 files changed, 106 insertions(+)
 create mode 100644 browser/extensions/brave_shields_apitest.cc
 create mode 100644 test/data/extensions/api_test/braveShields/background.js
 create mode 100644 test/data/extensions/api_test/braveShields/manifest.json
 create mode 100644 test/data/extensions/api_test/notBraveShields/background.js
 create mode 100644 test/data/extensions/api_test/notBraveShields/manifest.json

diff --git a/browser/extensions/brave_shields_apitest.cc b/browser/extensions/brave_shields_apitest.cc
new file mode 100644
index 00000000000..415adf89712
--- /dev/null
+++ b/browser/extensions/brave_shields_apitest.cc
@@ -0,0 +1,45 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#include "base/path_service.h"
+#include "brave/common/brave_paths.h"
+#include "chrome/browser/extensions/extension_apitest.h"
+#include "extensions/test/result_catcher.h"
+
+namespace extensions {
+namespace {
+
+class BraveShieldsExtensionApiTest : public ExtensionApiTest {
+ public:
+  void SetUp() override {
+    brave::RegisterPathProvider();
+    base::PathService::Get(brave::DIR_TEST_DATA, &extension_dir_);
+    extension_dir_ = extension_dir_.AppendASCII("extensions/api_test");
+    ExtensionApiTest::SetUp();
+  }
+  void TearDown() override {
+    ExtensionApiTest::TearDown();
+  }
+  base::FilePath extension_dir_;
+};
+
+IN_PROC_BROWSER_TEST_F(BraveShieldsExtensionApiTest, BraveExtensionHasAccess) {
+  const Extension* extension =
+    LoadExtension(extension_dir_.AppendASCII("braveShields"));
+  ASSERT_TRUE(extension);
+  ResultCatcher catcher;
+  ASSERT_TRUE(catcher.GetNextResult()) << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(BraveShieldsExtensionApiTest, NotBraveExtensionHasNoAccess) {
+  LOG(ERROR) << "======= This is an intentional fail:";
+  const Extension* extension =
+    LoadExtension(extension_dir_.AppendASCII("notBraveShields"));
+  ASSERT_TRUE(extension);
+  ResultCatcher catcher;
+  ASSERT_FALSE(catcher.GetNextResult()) << message_;
+}
+
+}  // namespace
+}  // extensions
diff --git a/test/BUILD.gn b/test/BUILD.gn
index 83fee1e7764..7031fe2a93f 100644
--- a/test/BUILD.gn
+++ b/test/BUILD.gn
@@ -164,6 +164,14 @@ test("brave_browser_tests") {
     "//chrome/browser/extensions/updater/extension_cache_fake.cc",
     "//chrome/browser/extensions/updater/extension_cache_fake.h",
   ]
+
+  # API tests
+  sources += [
+    "//brave/browser/extensions/brave_shields_apitest.cc",
+    "//chrome/browser/extensions/extension_apitest.cc",
+    "//chrome/browser/extensions/extension_apitest.h",
+  ]
+
   if (is_linux && is_official_build) {
     sources += [
       # BraveViewsDelegateLinuxBrowserTest only works in release(official) build.
diff --git a/test/data/extensions/api_test/braveShields/background.js b/test/data/extensions/api_test/braveShields/background.js
new file mode 100644
index 00000000000..9600c42b3df
--- /dev/null
+++ b/test/data/extensions/api_test/braveShields/background.js
@@ -0,0 +1,14 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+chrome.test.runTests([
+  function braveShieldsExtensionHasAccess() {
+    if (chrome.braveShields) {
+      chrome.test.succeed();
+    } else {
+      chrome.test.fail();
+    }
+  },
+]);
+
diff --git a/test/data/extensions/api_test/braveShields/manifest.json b/test/data/extensions/api_test/braveShields/manifest.json
new file mode 100644
index 00000000000..faba21b2b4e
--- /dev/null
+++ b/test/data/extensions/api_test/braveShields/manifest.json
@@ -0,0 +1,13 @@
+{
+  "version": "1.0.0",
+  "name": "Brave",
+  "manifest_version": 2,
+  "description": "API test for braveShields",
+  "web_accessible_resources": [
+  ],
+  "background": {
+    "scripts": ["background.js"]
+  },
+  "permissions": [ "contentSettings", "tabs", "storage", "webNavigation" ],
+  "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAupOLMy5Fd4dCSOtjcApsAQOnuBdTs+OvBVt/3P93noIrf068x0xXkvxbn+fpigcqfNamiJ5CjGyfx9zAIs7zcHwbxjOw0Uih4SllfgtK+svNTeE0r5atMWE0xR489BvsqNuPSxYJUmW28JqhaSZ4SabYrRx114KcU6ko7hkjyPkjQa3P+chStJjIKYgu5tWBiMJp5QVLelKoM+xkY6S7efvJ8AfajxCViLGyDQPDviGr2D0VvIBob0D1ZmAoTvYOWafcNCaqaejPDybFtuLFX3pZBqfyOCyyzGhucyCmfBXJALKbhjRAqN5glNsUmGhhPK87TuGATQfVuZtenMvXMQIDAQAB"
+}
diff --git a/test/data/extensions/api_test/notBraveShields/background.js b/test/data/extensions/api_test/notBraveShields/background.js
new file mode 100644
index 00000000000..a57fdb2d496
--- /dev/null
+++ b/test/data/extensions/api_test/notBraveShields/background.js
@@ -0,0 +1,13 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+chrome.test.runTests([
+  function braveShieldsExtensionHasAccess() {
+    if (chrome.braveShields) {
+      chrome.test.succeed();
+    } else {
+      chrome.test.fail();
+    }
+  },
+]);
diff --git a/test/data/extensions/api_test/notBraveShields/manifest.json b/test/data/extensions/api_test/notBraveShields/manifest.json
new file mode 100644
index 00000000000..79bb5c115a3
--- /dev/null
+++ b/test/data/extensions/api_test/notBraveShields/manifest.json
@@ -0,0 +1,13 @@
+{
+  "version": "1.0.0",
+  "name": "Brave",
+  "manifest_version": 2,
+  "description": "API test for something that is not braveShields",
+  "web_accessible_resources": [
+  ],
+  "background": {
+    "scripts": ["background.js"]
+  },
+  "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAs4TIQXRCftLpGmQZxmm6AU8pqGKLoDyi537HGQyRKcK7j/CSXCf3vwJr7xkV72p7bayutuzyNZ3740QxBPiesfBOp8bBb8d2VgTHP3b+SuNmK/rsSRsMRhT05x8AAr/7ab6U3rW0Gsalm2653xnnQS8vt0s62xQTmC+UMXowaSLUZ0Be/TOu6lHZhOeo0NBMKc6PkOu0R1EEfP7dJR6SM/v4dBUBZ1HXcuziVbCXVyU51opZCMjlxyUlQR9pTGk+Zh5sDn1Vw1MwLnWiEfQ4EGL1V7GeI4vgLoOLgq7tmhEratHGCfC1IHm9luMACRr/ybMI6DQJOvgBvecb292FxQIDAQAB",
+  "permissions": [ "contentSettings", "tabs", "storage", "webNavigation" ]
+}