From 907a7c60fa9af4b489fb74795415ee270d341f50 Mon Sep 17 00:00:00 2001 From: "Brian R. Bondy" Date: Tue, 10 Feb 2026 13:00:13 -0500 Subject: [PATCH] Add missing buildflag guards to Origin settings page (#33812) Only Speedreader had an guard. Add guards for all feature toggles so they don't render when compiled out. Resolves https://github.com/brave/brave-browser/issues/52687 --- browser/resources/settings/BUILD.gn | 6 + .../brave_origin_page/brave_origin_page.html | 114 ++++++++++-------- 2 files changed, 72 insertions(+), 48 deletions(-) diff --git a/browser/resources/settings/BUILD.gn b/browser/resources/settings/BUILD.gn index 4190dd9549d..1f7fa049540 100644 --- a/browser/resources/settings/BUILD.gn +++ b/browser/resources/settings/BUILD.gn @@ -7,6 +7,9 @@ import("//brave/browser/shell_integrations/buildflags/buildflags.gni") import("//brave/build/config.gni") import("//brave/components/ai_chat/core/common/buildflags/buildflags.gni") import("//brave/components/brave_ads/buildflags/buildflags.gni") +import("//brave/components/brave_news/common/buildflags/buildflags.gni") +import("//brave/components/brave_rewards/core/buildflags/buildflags.gni") +import("//brave/components/brave_talk/buildflags/buildflags.gni") import("//brave/components/brave_vpn/common/buildflags/buildflags.gni") import("//brave/components/brave_wallet/common/buildflags/buildflags.gni") import("//brave/components/brave_wayback_machine/buildflags/buildflags.gni") @@ -88,6 +91,9 @@ preprocess_if_expr("preprocess") { defines = [ "enable_ai_chat=$enable_ai_chat", "enable_brave_ads=$enable_brave_ads", + "enable_brave_news=$enable_brave_news", + "enable_brave_rewards=$enable_brave_rewards", + "enable_brave_talk=$enable_brave_talk", "enable_tor=$enable_tor", "enable_brave_wayback_machine=$enable_brave_wayback_machine", "enable_brave_vpn=$enable_brave_vpn", diff --git a/browser/resources/settings/brave_origin_page/brave_origin_page.html b/browser/resources/settings/brave_origin_page/brave_origin_page.html index d4cb5a7f2ba..2fc77dd2520 100644 --- a/browser/resources/settings/brave_origin_page/brave_origin_page.html +++ b/browser/resources/settings/brave_origin_page/brave_origin_page.html @@ -29,14 +29,16 @@ -
$i18n{braveOriginSectionAdsTitle}
+ +
$i18n{braveOriginSectionAdsTitle}
- - + + +
$i18n{braveOriginSectionAnalyticsTitle}
@@ -52,20 +54,26 @@ icon="bar-chart"> -
$i18n{braveOriginSectionFeaturesTitle}
+ +
$i18n{braveOriginSectionFeaturesTitle}
+
- - + + + + - - + + + + - - + + + + - - + + + + - - + + + + - - + + + + - - + + + +