From 8fda1384ec08c29d5ba24a004f9ed14b19768fdc Mon Sep 17 00:00:00 2001 From: deeppandya Date: Fri, 17 May 2024 02:29:38 -0400 Subject: [PATCH 1/2] Enable in app update dialog for < android 14 devices --- android/java/org/chromium/chrome/browser/app/BraveActivity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/java/org/chromium/chrome/browser/app/BraveActivity.java b/android/java/org/chromium/chrome/browser/app/BraveActivity.java index ffe04c90c49..0477ecb76a6 100644 --- a/android/java/org/chromium/chrome/browser/app/BraveActivity.java +++ b/android/java/org/chromium/chrome/browser/app/BraveActivity.java @@ -264,7 +264,7 @@ public abstract class BraveActivity extends ChromeActivity public static final int APP_OPEN_COUNT_FOR_WIDGET_PROMO = 25; - private static final boolean ENABLE_IN_APP_UPDATE = false; + private static final boolean ENABLE_IN_APP_UPDATE = Build.VERSION.SDK_INT < Build.VERSION_CODES.UPSIDE_DOWN_CAKE; /** Settings for sending local notification reminders. */ public static final String CHANNEL_ID = "com.brave.browser"; From cb56a5b00e8598a2c16f02f0ef65ce6162d3ba93 Mon Sep 17 00:00:00 2001 From: deeppandya Date: Wed, 22 May 2024 16:20:32 -0400 Subject: [PATCH 2/2] Resolve presubmit issues --- .../java/org/chromium/chrome/browser/app/BraveActivity.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/android/java/org/chromium/chrome/browser/app/BraveActivity.java b/android/java/org/chromium/chrome/browser/app/BraveActivity.java index 0477ecb76a6..93de69f3217 100644 --- a/android/java/org/chromium/chrome/browser/app/BraveActivity.java +++ b/android/java/org/chromium/chrome/browser/app/BraveActivity.java @@ -264,7 +264,8 @@ public abstract class BraveActivity extends ChromeActivity public static final int APP_OPEN_COUNT_FOR_WIDGET_PROMO = 25; - private static final boolean ENABLE_IN_APP_UPDATE = Build.VERSION.SDK_INT < Build.VERSION_CODES.UPSIDE_DOWN_CAKE; + private static final boolean ENABLE_IN_APP_UPDATE = + Build.VERSION.SDK_INT < Build.VERSION_CODES.UPSIDE_DOWN_CAKE; /** Settings for sending local notification reminders. */ public static final String CHANNEL_ID = "com.brave.browser";