From 956efc766e8affd0cec07edb8c36105b93af6542 Mon Sep 17 00:00:00 2001 From: Artem Samoilenko Date: Wed, 10 Dec 2025 15:13:51 -0500 Subject: [PATCH] [cr145][Android] Clean up sTabGroupParityBottomSheetAndroid Chromium changes: https://chromium.googlesource.com/chromium/src/+/b1c73a30ed49ea3961dcdd30cf9275c888296a58 commit b1c73a30ed49ea3961dcdd30cf9275c888296a58 Author: luci-bisection@appspot.gserviceaccount.com Date: Tue Dec 9 10:44:12 2025 -0800 Revert "Revert "[Community Contributions] Clean up sTabGroupParityBottomSheetAndroid"" This reverts commit 2e7c96beae9fe9dcd350e7de8882e64c6cdd6231. Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8695938283667055729 Sample failed build: https://ci.chromium.org/b/8695938283667055729 If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7241785&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8695938283667055729&type=BUG Original change's description: > Revert "[Community Contributions] Clean up sTabGroupParityBottomSheetAndroid" > > This reverts commit b0ce122d544925ff7ce8bafd0e72b8167843e17d. > > Reason for revert: broke Chrome internal builds, see > https://ci.chromium.org/ui/p/chrome/builders/ci/android-internal-chromium-tot/191918/overview > > Original change's description: > > [Community Contributions] Clean up sTabGroupParityBottomSheetAndroid > > > > Bug: 448348139 > > Change-Id: I661f84a0b0751bebf481d1ba46cc39f9ddcc9644 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7235865 > > Reviewed-by: Fiaz Muhammad > > Reviewed-by: Theresa Sullivan > > Commit-Queue: Eleanor Lee > > Reviewed-by: Calder Kitagawa > > Cr-Commit-Position: refs/heads/main@{#1556157} > > Bug: 448348139 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: Icbc7a9caf9680a7d51b4a371b2318aa4282b31ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7241785 > Auto-Submit: Alex Ilin > Commit-Queue: Rubber Stamper > Bot-Commit: Rubber Stamper > Owners-Override: Alex Ilin > Cr-Commit-Position: refs/heads/main@{#1556200} > Bug: 448348139 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ifaa2b88fbf293d9a7a1346309f935a7ddaec4e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7242570 Bot-Commit: Rubber Stamper Commit-Queue: luci-bisection@appspot.gserviceaccount.com Owners-Override: luci-bisection@appspot.gserviceaccount.com Bot-Commit: luci-bisection@appspot.gserviceaccount.com Cr-Commit-Position: refs/heads/main@{#1556267} --- .../BraveTabbedAppMenuPropertiesDelegate.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java b/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java index c41dc5a0073..ef44f5b00c6 100644 --- a/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java +++ b/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java @@ -546,13 +546,11 @@ public class BraveTabbedAppMenuPropertiesDelegate extends TabbedAppMenuPropertie 0))); // Add to Group - if (ChromeFeatureList.sTabGroupParityBottomSheetAndroid.isEnabled()) { - modelList.add( - new MVCListAdapter.ListItem( - AppMenuHandler.AppMenuItemType.STANDARD, - buildModelForStandardMenuItem( - R.id.add_to_group_menu_id, R.string.menu_add_tab_to_group, 0))); - } + modelList.add( + new MVCListAdapter.ListItem( + AppMenuHandler.AppMenuItemType.STANDARD, + buildModelForStandardMenuItem( + R.id.add_to_group_menu_id, R.string.menu_add_tab_to_group, 0))); // New Window if (!DeviceInfo.isAutomotive()) {