From 95fb334df8f9f5edbe333ef9935d2c65b1a1b2ca Mon Sep 17 00:00:00 2001 From: AlexeyBarabash Date: Thu, 6 Nov 2025 14:20:32 +0200 Subject: [PATCH] [cr144][Android] New arg at BraveTabbedRootUiCoordinator.ctor https://source.chromium.org/chromium/chromium/src/+/61b7d0e50d82d35958f834607e512c7b7ff9910c [tips] Add a pref for second run experience for tips opt in promo Add a pref for second run experience for the tips opt in promo and trigger the bottom sheet promo. Bug: 454718966 Change-Id: I6677b56cfd46379ab417fc37a53ab2758367a4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7080471 --- .../browser/tabbed_mode/BraveTabbedRootUiCoordinator.java | 7 +++++-- .../org/chromium/chrome/browser/BytecodeTest.java | 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedRootUiCoordinator.java b/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedRootUiCoordinator.java index f407b5eee4b..79048b16377 100644 --- a/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedRootUiCoordinator.java +++ b/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedRootUiCoordinator.java @@ -19,6 +19,7 @@ import org.chromium.base.supplier.OneshotSupplier; import org.chromium.base.supplier.OneshotSupplierImpl; import org.chromium.chrome.R; import org.chromium.chrome.browser.ActivityTabProvider; +import org.chromium.chrome.browser.ChromeInactivityTracker; import org.chromium.chrome.browser.app.BraveActivity; import org.chromium.chrome.browser.back_press.BackPressManager; import org.chromium.chrome.browser.bookmarks.BookmarkManagerOpener; @@ -123,7 +124,8 @@ public class BraveTabbedRootUiCoordinator extends TabbedRootUiCoordinator { @NonNull ManualFillingComponentSupplier manualFillingComponentSupplier, @NonNull EdgeToEdgeManager edgeToEdgeManager, @NonNull ObservableSupplier bookmarkManagerOpenerSupplier, - @Nullable ObservableSupplier xrSpaceModeObservableSupplier) { + @Nullable ObservableSupplier xrSpaceModeObservableSupplier, + @NonNull OneshotSupplier inactivityTrackerSupplier) { super( activity, onOmniboxFocusChangedListener, @@ -174,7 +176,8 @@ public class BraveTabbedRootUiCoordinator extends TabbedRootUiCoordinator { manualFillingComponentSupplier, edgeToEdgeManager, bookmarkManagerOpenerSupplier, - xrSpaceModeObservableSupplier); + xrSpaceModeObservableSupplier, + inactivityTrackerSupplier); mBraveActivity = activity; mHubManagerSupplier = hubManagerSupplier; diff --git a/android/javatests/org/chromium/chrome/browser/BytecodeTest.java b/android/javatests/org/chromium/chrome/browser/BytecodeTest.java index fc2d540788f..3eeb79ce4c6 100644 --- a/android/javatests/org/chromium/chrome/browser/BytecodeTest.java +++ b/android/javatests/org/chromium/chrome/browser/BytecodeTest.java @@ -1828,7 +1828,8 @@ public class BytecodeTest { ManualFillingComponentSupplier.class, EdgeToEdgeManager.class, ObservableSupplier.class, - ObservableSupplier.class)); + ObservableSupplier.class, + OneshotSupplier.class)); Assert.assertTrue( constructorsMatch( "org/chromium/chrome/browser/bookmarks/BookmarkToolbar",