From 982ca37da28d3e8865aba24fd5ff0a7620d2af98 Mon Sep 17 00:00:00 2001 From: AlexeyBarabash Date: Tue, 15 Jul 2025 17:31:57 +0300 Subject: [PATCH] [cr140][Android] Restricted visibility of google_android_datatransport_transport_backend_cct_java Visibility of //third_party/android_deps/autorolled:google_android_datatransport_transport_backend_cct_java was updated This caused such error ``` ERROR at //build/config/android/internal_rules.gni:4265:5: Dependency not allowed. group("${target_name}__host") { ^------------------------------ The item //brave/third_party/android_deps:com_android_billingclient_java__classes__host can not depend on //third_party/android_deps:google_android_datatransport_transport_backend_cct_java__host because it is not in //third_party/android_deps:google_android_datatransport_transport_backend_cct_java__host's visibility list: [ //third_party/android_deps:* //third_party/androidx:* ] ``` This commit adds a patch to fix it. Chromium change: https://source.chromium.org/chromium/chromium/src/+/30c6c0049a0fe2f8d34c3cfc586882969a33a115 Roll android_deps from 4VVOF34a8wadMNo1_... to q7nAVGdftMgI61E5C... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/android-deps-chromium Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: clank-library-failures@google.com Change-Id: I5ef7f146b26d34d85467c97fe36a2fde6b79c010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6734819 --- ...hird_party-android_deps-autorolled-BUILD.gn.patch | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/patches/third_party-android_deps-autorolled-BUILD.gn.patch b/patches/third_party-android_deps-autorolled-BUILD.gn.patch index 844b8bb338b..c57b26834b2 100644 --- a/patches/third_party-android_deps-autorolled-BUILD.gn.patch +++ b/patches/third_party-android_deps-autorolled-BUILD.gn.patch @@ -1,8 +1,16 @@ diff --git a/third_party/android_deps/autorolled/BUILD.gn b/third_party/android_deps/autorolled/BUILD.gn -index 0b5c773f614d0b1a2635285ae9bd8f1b0d95540c..3d416e051382dbf17165448c197736b825e7c297 100644 +index 491a489f9191976ac86c915792f472906e37c84e..8a8a2cce86269b7969a06420d88430e3a50505e3 100644 --- a/third_party/android_deps/autorolled/BUILD.gn +++ b/third_party/android_deps/autorolled/BUILD.gn -@@ -717,6 +717,7 @@ template("define_autorolled_targets") { +@@ -833,6 +833,7 @@ template("define_autorolled_targets") { + "//third_party/android_deps:google_android_datatransport_transport_runtime_java", + "//third_party/androidx:androidx_annotation_annotation_java", + ] ++ import("//brave/third_party/android_deps/sources.gni") visibility += brave_third_party_android_deps_visibility + } + } + +@@ -857,6 +858,7 @@ template("define_autorolled_targets") { "//third_party/android_deps:javax_inject_javax_inject_java", "//third_party/androidx:androidx_annotation_annotation_java", ]