Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr148][Android] Removed preferences we don't need

Browse Source 
BraveMainSettingsFragmentTest#testPreferenceCount caught
2 more prefs we don't want:
- settings_promo_card
- manage_sync

The change below is probably responsible for exposing them

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/1ea4b48ea68982cd81a4a3a6f8bad6e8839789bd

commit 1ea4b48ea68982cd81a4a3a6f8bad6e8839789bd
Author: Josef Raska <josefraska@google.com>
Date:   Wed Mar 18 07:41:06 2026 -0700

    [HoT][Autofill] - Launch HoT screen in Settings

    - Launching an empty screen for now.
    - Video from the test: https://screencast.googleplex.com/cast/NDU3ODE5MTk5MjY4NDU0NHxhNGViM2JiYy1kOQ
    - More tests and user action reporting comes in crrev.com/c/7653458

    Bug: 482994356
    Change-Id: Ib3ae426846faaff85e2fd69da6d04078d7a54b6f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7653140
    Reviewed-by: Julia Sobiech <jsobiech@google.com>
    Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
    Reviewed-by: Abe Boujane <boujane@google.com>
    Reviewed-by: Timofey Chudakov <tchudakov@google.com>
    Commit-Queue: Josef Raska <josefraska@google.com>
    Cr-Commit-Position: refs/heads/main@{#1601279}
This commit is contained in:
AlexeyBarabash
2026-04-27 12:00:59 +01:00
committed by Claudio DeSouza
parent 949d29fb70
commit 99ebb5a603
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/settings/BraveMainPreferencesBase.java
+4
View File
@@ -240,6 +240,8 @@ public abstract class BraveMainPreferencesBase extends BravePreferenceFragment
removePreferenceIfPresent(PREF_ADVANCED_SECTION);
removePreferenceIfPresent(PREF_PRIVACY);
removePreferenceIfPresent(PREF_BRAVE_VPN_CALLOUT);
removePreferenceIfPresent(MainSettings.PREF_SETTINGS_PROMO_CARD);
removePreferenceIfPresent(MainSettings.PREF_MANAGE_SYNC);
if (!ChromeFeatureList.isEnabled(BraveFeatureList.BRAVE_PLAYLIST)) {
removePreferenceIfPresent(PREF_BRAVE_PLAYLIST);
@@ -707,6 +709,8 @@ public abstract class BraveMainPreferencesBase extends BravePreferenceFragment
indexData.removeEntry(getUniqueId(MainSettings.PREF_SEARCH_ENGINE));
indexData.removeEntry(getUniqueId(MainSettings.PREF_DOWNLOADS));
indexData.removeEntry(getUniqueId(MainSettings.PREF_SAFETY_HUB));
indexData.removeEntry(getUniqueId(MainSettings.PREF_SETTINGS_PROMO_CARD));
indexData.removeEntry(getUniqueId(MainSettings.PREF_MANAGE_SYNC));
indexData.removeEntry(
getUniqueId(MainSettings.PREF_ACCOUNT_AND_GOOGLE_SERVICES_SECTION));
indexData.removeEntry(getUniqueId(MainSettings.PREF_GOOGLE_SERVICES));