[cr140][Android] Changed arguments of ToolbarManager.ctor
`extensionService` arg was removed Chromium change: https://source.chromium.org/chromium/chromium/src/+/abfb8fa6b66c62e8c0e5fb3390b54a35c33eb7c3 extensions: Extract toolbar-related stuff from ExtensionService ExtensionService (formerly named ExtensionToolbarManager until recently) currently contains a lot of toolbar-specific UI logic, requiring the dependency from //c/b/ui/android/extensions to //c/b/ui/android/toolbar. This dependency is not desirable as it forbids most of the UI code under //c/b/ui/android to depend on //c/b/ui/android/extensions due to dependency cycles. We want to reverse the dependency direction. As the first step towards the goal, this patch extracts the toolbar-related methods from ExtensionService to a new class ExtensionToolbarCoordinator, and place it under //c/b/ui/android/toolbar. ExtensionToolbarCoordinator's implementation is loaded with ServiceLoader just like ExtensionService, so that its implementation can depend on conditionally-compiled extension UI code. It is created and owned by ToolbarManager, instead of RootUiCoordinator that formerly owned ExtensionService, because it now focuses on toolbar stuff. This is a pure refactoring. No functional changes are expected. Bug: 428637084 Change-Id: I141d6ba797626230d59cd0bc481588264ac6cf06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6694669
This commit is contained in:
@@ -85,7 +85,6 @@ import org.chromium.chrome.browser.toolbar.top.TopToolbarCoordinator;
|
||||
import org.chromium.chrome.browser.ui.appmenu.AppMenuCoordinator;
|
||||
import org.chromium.chrome.browser.ui.appmenu.AppMenuDelegate;
|
||||
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeController;
|
||||
import org.chromium.chrome.browser.ui.extensions.ExtensionService;
|
||||
import org.chromium.chrome.browser.ui.system.StatusBarColorController;
|
||||
import org.chromium.chrome.browser.undo_tab_close_snackbar.UndoBarThrottle;
|
||||
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController;
|
||||
@@ -172,7 +171,6 @@ public class BraveToolbarManager extends ToolbarManager
|
||||
ActivityTabProvider tabProvider,
|
||||
ScrimManager scrimManager,
|
||||
ToolbarActionModeCallback toolbarActionModeCallback,
|
||||
@Nullable ExtensionService extensionService,
|
||||
FindToolbarManager findToolbarManager,
|
||||
ObservableSupplier<Profile> profileSupplier,
|
||||
ObservableSupplier<BookmarkModel> bookmarkModelSupplier,
|
||||
@@ -223,7 +221,6 @@ public class BraveToolbarManager extends ToolbarManager
|
||||
tabProvider,
|
||||
scrimManager,
|
||||
toolbarActionModeCallback,
|
||||
extensionService,
|
||||
findToolbarManager,
|
||||
profileSupplier,
|
||||
bookmarkModelSupplier,
|
||||
|
||||
Reference in New Issue
Block a user