From a534dfc5ec838bfeb5fe3a6281d6211b56038c48 Mon Sep 17 00:00:00 2001 From: Emerick Rogul Date: Fri, 6 Feb 2026 09:03:42 -0500 Subject: [PATCH] [cr146] Disable URL sanitizer tests on Mac due to focus-related flakiness Clipboard write access requires document focus, but waiting for document focus is flakey on Mac. Several upstream tests are disabled on Mac due to this issue. For example, see https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/controlled_frame/controlled_frame_permission_request_browsertest.cc;l=242-250 --- browser/url_sanitizer/url_sanitizer_browsertest.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/browser/url_sanitizer/url_sanitizer_browsertest.cc b/browser/url_sanitizer/url_sanitizer_browsertest.cc index 646ff981084..73b7dfa17ff 100644 --- a/browser/url_sanitizer/url_sanitizer_browsertest.cc +++ b/browser/url_sanitizer/url_sanitizer_browsertest.cc @@ -233,10 +233,16 @@ class DisabledURLSanitizerTest : public URLSanitizerTestBase { DisabledURLSanitizerTest() : URLSanitizerTestBase(false) {} }; -IN_PROC_BROWSER_TEST_F(EnabledURLSanitizerTest, JSApi) { +// These tests require document focus, and waiting for focus is flaky on mac. +#if BUILDFLAG(IS_MAC) +#define MAYBE_JSApi DISABLED_JSApi +#else +#define MAYBE_JSApi JSApi +#endif +IN_PROC_BROWSER_TEST_F(EnabledURLSanitizerTest, MAYBE_JSApi) { Check(); } -IN_PROC_BROWSER_TEST_F(DisabledURLSanitizerTest, JSApi) { +IN_PROC_BROWSER_TEST_F(DisabledURLSanitizerTest, MAYBE_JSApi) { Check(); }