diff --git a/.pylint2rc b/.pylint2rc deleted file mode 100644 index b6b9ed700e7..00000000000 --- a/.pylint2rc +++ /dev/null @@ -1,379 +0,0 @@ -[MASTER] - -# Specify a configuration file. -#rcfile= - -# Python code to execute, usually for sys.path manipulation such as -# pygtk.require(). -#init-hook= - -# Add files or directories to the blacklist. They should be base names, not -# paths. -ignore=CVS - -# Pickle collected data for later comparisons. -persistent=yes - -# List of plugins (as comma separated values of python modules names) to load, -# usually to register additional checkers. -load-plugins= - -# Use multiple processes to speed up Pylint. -jobs=0 - -# Allow loading of arbitrary C extensions. Extensions are imported into the -# active Python interpreter and may run arbitrary code. -unsafe-load-any-extension=no - -# A comma-separated list of package or module names from where C extensions may -# be loaded. Extensions are loading into the active Python interpreter and may -# run arbitrary code -extension-pkg-whitelist= - -# Allow optimization of some AST trees. This will activate a peephole AST -# optimizer, which will apply various small optimizations. For instance, it can -# be used to obtain the result of joining multiple strings with the addition -# operator. Joining a lot of strings can lead to a maximum recursion error in -# Pylint and this flag can prevent that. It has one side effect, the resulting -# AST will be different than the one from reality. -optimize-ast=no - - -[MESSAGES CONTROL] - -# Only show warnings with the listed confidence levels. Leave empty to show -# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED -confidence= - -# Enable the message, report, category or checker with the given id(s). You can -# either give multiple identifier separated by comma (,) or put this option -# multiple time (only on the command line, not in the configuration file where -# it should appear only once). See also the "--disable" option for examples. -#enable= - -# Disable the message, report, category or checker with the given id(s). You -# can either give multiple identifiers separated by comma (,) or put this -# option multiple times (only on the command line, not in the configuration -# file where it should appear only once).You can also use "--disable=all" to -# disable everything first and then reenable specific checks. For example, if -# you want to run only the similarities checker, you can use "--disable=all -# --enable=similarities". If you want to run only the classes checker, but have -# no Warning level messages displayed, use"--disable=all --enable=classes -# --disable=W" -disable=import-star-module-level,old-octal-literal,oct-method,print-statement,unpacking-in-except,parameter-unpacking,backtick,old-raise-syntax,old-ne-operator,long-suffix,dict-view-method,dict-iter-method,metaclass-assignment,next-method-called,raising-string,indexing-exception,raw_input-builtin,long-builtin,file-builtin,execfile-builtin,coerce-builtin,cmp-builtin,buffer-builtin,basestring-builtin,apply-builtin,filter-builtin-not-iterating,using-cmp-argument,useless-suppression,raw-checker-failed,range-builtin-not-iterating,suppressed-message,invalid-name,no-absolute-import,old-division,cmp-method,bad-inline-option,reload-builtin,zip-builtin-not-iterating,intern-builtin,unichr-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,input-builtin,round-builtin,file-ignored,locally-disabled,hex-method,nonzero-method,map-builtin-not-iterating,deprecated-pragma,missing-docstring,missing-module-docstring,raise-missing-from,invalid-name,superfluous-parens, - - -[REPORTS] - -# Set the output format. Available formats are text, parseable, colorized, msvs -# (visual studio) and html. You can also give a reporter class, eg -# mypackage.mymodule.MyReporterClass. -output-format=text - -# Put messages in a separate file for each module / package specified on the -# command line instead of printing them on stdout. Reports (if any) will be -# written in a file name "pylint_global.[txt|html]". -files-output=no - -# Tells whether to display a full report or only the messages -reports=no - -# Python expression which should return a note less than 10 (10 is the highest -# note). You have access to the variables errors warning, statement which -# respectively contain the number of errors / warnings messages and the total -# number of statements analyzed. This is used by the global evaluation report -# (RP0004). -evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) - -# Template used to display messages. This is a python new-style format string -# used to format the message information. See doc for all details -#msg-template= - - -[FORMAT] - -# Maximum number of characters on a single line. -max-line-length=80 - -# Regexp for a line that is allowed to be longer than the limit. -ignore-long-lines=^\s*(# )??$ - -# Allow the body of an if to be on the same line as the test if there is no -# else. -single-line-if-stmt=no - -# List of optional constructs for which whitespace checking is disabled. `dict- -# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}. -# `trailing-comma` allows a space between comma and closing bracket: (a, ). -# `empty-line` allows space-only lines. -no-space-check=trailing-comma,dict-separator - -# Maximum number of lines in a module -max-module-lines=1000 - -# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 -# tab). -indent-string=' ' - -# Number of spaces of indent required inside a hanging or continued line. -indent-after-paren=4 - -# Expected format of line ending, e.g. empty (any line ending), LF or CRLF. -expected-line-ending-format= - - -[MISCELLANEOUS] - -# List of note tags to take in consideration, separated by a comma. -notes=FIXME,XXX,TODO - - -[SPELLING] - -# Spelling dictionary name. Available dictionaries: none. To make it working -# install python-enchant package. -spelling-dict= - -# List of comma separated words that should not be checked. -spelling-ignore-words= - -# A path to a file that contains private dictionary; one word per line. -spelling-private-dict-file= - -# Tells whether to store unknown words to indicated private dictionary in -# --spelling-private-dict-file option instead of raising a message. -spelling-store-unknown-words=no - - -[TYPECHECK] - -# Tells whether missing members accessed in mixin class should be ignored. A -# mixin class is detected if its name ends with "mixin" (case insensitive). -ignore-mixin-members=yes - -# List of module names for which member attributes should not be checked -# (useful for modules/projects where namespaces are manipulated during runtime -# and thus existing member attributes cannot be deduced by static analysis. It -# supports qualified module names, as well as Unix pattern matching. -ignored-modules= - -# List of classes names for which member attributes should not be checked -# (useful for classes with attributes dynamically set). This supports can work -# with qualified names. -ignored-classes=optparse.Values,thread._local,_thread._local - -# List of members which are set dynamically and missed by pylint inference -# system, and so shouldn't trigger E1101 when accessed. Python regular -# expressions are accepted. -generated-members= - - -[BASIC] - -# List of builtins function names that should not be used, separated by a comma -bad-functions=map,filter,input - -# Good variable names which should always be accepted, separated by a comma -good-names=i,j,k,ex,Run,_ - -# Bad variable names which should always be refused, separated by a comma -bad-names=foo,bar,baz,toto,tutu,tata - -# Colon-delimited sets of names that determine each other's naming style when -# the name regexes allow several styles. -name-group= - -# Include a hint for the correct naming format with invalid-name -include-naming-hint=no - -# Regular expression matching correct function names -function-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Naming hint for function names -function-name-hint=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression matching correct variable names -variable-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Naming hint for variable names -variable-name-hint=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression matching correct constant names -const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$ - -# Naming hint for constant names -const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$ - -# Regular expression matching correct attribute names -attr-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Naming hint for attribute names -attr-name-hint=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression matching correct argument names -argument-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Naming hint for argument names -argument-name-hint=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression matching correct class attribute names -class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$ - -# Naming hint for class attribute names -class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$ - -# Regular expression matching correct inline iteration names -inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ - -# Naming hint for inline iteration names -inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$ - -# Regular expression matching correct class names -class-rgx=[A-Z_][a-zA-Z0-9]+$ - -# Naming hint for class names -class-name-hint=[A-Z_][a-zA-Z0-9]+$ - -# Regular expression matching correct module names -module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ - -# Naming hint for module names -module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ - -# Regular expression matching correct method names -method-rgx=[a-z_][a-z0-9_]{2,30}$ - -# Naming hint for method names -method-name-hint=[a-z_][a-z0-9_]{2,30}$ - -# Regular expression which should only match function or class names that do -# not require a docstring. -no-docstring-rgx=^_ - -# Minimum line length for functions/classes that require docstrings, shorter -# ones are exempt. -docstring-min-length=-1 - - -[ELIF] - -# Maximum number of nested blocks for function / method body -max-nested-blocks=5 - - -[SIMILARITIES] - -# Minimum lines number of a similarity. -min-similarity-lines=4 - -# Ignore comments when computing similarities. -ignore-comments=yes - -# Ignore docstrings when computing similarities. -ignore-docstrings=yes - -# Ignore imports when computing similarities. -ignore-imports=no - - -[LOGGING] - -# Logging modules to check that the string format arguments are in logging -# function parameter format -logging-modules=logging - - -[VARIABLES] - -# Tells whether we should check for unused import in __init__ files. -init-import=no - -# A regular expression matching the name of dummy variables (i.e. expectedly -# not used). -dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_ - -# List of additional names supposed to be defined in builtins. Remember that -# you should avoid to define new builtins when possible. -additional-builtins= - -# List of strings which can identify a callback function by name. A callback -# name must start or end with one of those strings. -callbacks=cb_,_cb - - -[CLASSES] - -# List of method names used to declare (i.e. assign) instance attributes. -defining-attr-methods=__init__,__new__,setUp,__post_init__ - -# List of valid names for the first argument in a class method. -valid-classmethod-first-arg=cls - -# List of valid names for the first argument in a metaclass class method. -valid-metaclass-classmethod-first-arg=cls - -# List of member names, which should be excluded from the protected access -# warning. -exclude-protected=_asdict,_fields,_replace,_source,_make - - -[IMPORTS] - -# Deprecated modules which should not be used, separated by a comma -deprecated-modules=tkinter.tix - -# Create a graph of every (i.e. internal and external) dependencies in the -# given file (report RP0402 must not be disabled) -import-graph= - -# Create a graph of external dependencies in the given file (report RP0402 must -# not be disabled) -ext-import-graph= - -# Create a graph of internal dependencies in the given file (report RP0402 must -# not be disabled) -int-import-graph= - - -[DESIGN] - -# Maximum number of arguments for function / method -max-args=8 - -# Argument names that match this expression will be ignored. Default to name -# with leading underscore -ignored-argument-names=_.*|^ignored_|^unused_ - -# Maximum number of locals for function / method body -max-locals=15 - -# Maximum number of return / yield for function / method body -max-returns=6 - -# Maximum number of branch for function / method body -max-branches=12 - -# Maximum number of statements in function / method body -max-statements=50 - -# Maximum number of parents for a class (see R0901). -max-parents=7 - -# Maximum number of attributes for a class (see R0902). -max-attributes=7 - -# Minimum number of public methods for a class (see R0903). -min-public-methods=2 - -# Maximum number of public methods for a class (see R0904). -max-public-methods=20 - -# Maximum number of boolean expressions in a if statement -max-bool-expr=5 - - -[EXCEPTIONS] - -# Exceptions that will emit a warning when being caught. Defaults to -# "Exception" -overgeneral-exceptions=BaseException,Exception diff --git a/.pylintrc b/.pylintrc deleted file mode 100644 index 85d912dcc38..00000000000 --- a/.pylintrc +++ /dev/null @@ -1,615 +0,0 @@ -[MASTER] - -# A comma-separated list of package or module names from where C extensions may -# be loaded. Extensions are loading into the active Python interpreter and may -# run arbitrary code. -extension-pkg-allow-list= - -# A comma-separated list of package or module names from where C extensions may -# be loaded. Extensions are loading into the active Python interpreter and may -# run arbitrary code. (This is an alternative name to extension-pkg-allow-list -# for backward compatibility.) -extension-pkg-whitelist= - -# Specify a score threshold to be exceeded before program exits with error. -fail-under=10.0 - -# Files or directories to be skipped. They should be base names, not paths. -ignore=CVS - -# Files or directories matching the regex patterns are skipped. The regex -# matches against base names, not paths. -ignore-patterns= - -# Python code to execute, usually for sys.path manipulation such as -# pygtk.require(). -#init-hook= - -# Control the amount of potential inferred values when inferring a single -# object. This can help the performance when dealing with large functions or -# complex, nested conditions. -limit-inference-results=100 - -# List of plugins (as comma separated values of python module names) to load, -# usually to register additional checkers. -load-plugins= - -# Pickle collected data for later comparisons. -persistent=yes - -# When enabled, pylint would attempt to guess common misconfiguration and emit -# user-friendly hints instead of false-positive error messages. -suggestion-mode=yes - -# Allow loading of arbitrary C extensions. Extensions are imported into the -# active Python interpreter and may run arbitrary code. -unsafe-load-any-extension=no - - -[MESSAGES CONTROL] - -# Only show warnings with the listed confidence levels. Leave empty to show -# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED. -confidence= - -# Disable the message, report, category or checker with the given id(s). You -# can either give multiple identifiers separated by comma (,) or put this -# option multiple times (only on the command line, not in the configuration -# file where it should appear only once). You can also use "--disable=all" to -# disable everything first and then reenable specific checks. For example, if -# you want to run only the similarities checker, you can use "--disable=all -# --enable=similarities". If you want to run only the classes checker, but have -# no Warning level messages displayed, use "--disable=all --enable=classes -# --disable=W". -disable=bad-indentation, - too-many-locals, - too-many-branches, - broad-except, - print-statement, - parameter-unpacking, - unpacking-in-except, - old-raise-syntax, - backtick, - long-suffix, - old-ne-operator, - old-octal-literal, - import-star-module-level, - non-ascii-bytes-literal, - raw-checker-failed, - bad-inline-option, - locally-disabled, - file-ignored, - suppressed-message, - useless-suppression, - deprecated-pragma, - use-symbolic-message-instead, - apply-builtin, - basestring-builtin, - buffer-builtin, - cmp-builtin, - coerce-builtin, - execfile-builtin, - file-builtin, - long-builtin, - raw_input-builtin, - reduce-builtin, - standarderror-builtin, - unicode-builtin, - xrange-builtin, - coerce-method, - delslice-method, - getslice-method, - setslice-method, - no-absolute-import, - old-division, - dict-iter-method, - dict-view-method, - next-method-called, - metaclass-assignment, - indexing-exception, - raising-string, - reload-builtin, - oct-method, - hex-method, - nonzero-method, - cmp-method, - input-builtin, - round-builtin, - intern-builtin, - unichr-builtin, - map-builtin-not-iterating, - zip-builtin-not-iterating, - range-builtin-not-iterating, - filter-builtin-not-iterating, - using-cmp-argument, - eq-without-hash, - div-method, - idiv-method, - rdiv-method, - exception-message-attribute, - invalid-str-codec, - sys-max-int, - bad-python3-import, - deprecated-string-function, - deprecated-str-translate-call, - deprecated-itertools-function, - deprecated-types-field, - next-method-defined, - dict-items-not-iterating, - dict-keys-not-iterating, - dict-values-not-iterating, - deprecated-operator-function, - deprecated-urllib-function, - xreadlines-attribute, - deprecated-sys-function, - exception-escape, - comprehension-escape, - missing-docstring, - missing-function-docstring, - missing-module-docstring, - raise-missing-from, - invalid-name, - duplicate-code, - deprecated-method, - superfluous-parens, - -# Enable the message, report, category or checker with the given id(s). You can -# either give multiple identifier separated by comma (,) or put this option -# multiple time (only on the command line, not in the configuration file where -# it should appear only once). See also the "--disable" option for examples. -enable=c-extension-no-member - - -[REPORTS] - -# Python expression which should return a score less than or equal to 10. You -# have access to the variables 'error', 'warning', 'refactor', and 'convention' -# which contain the number of messages in each category, as well as 'statement' -# which is the total number of statements analyzed. This score is used by the -# global evaluation report (RP0004). -evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) - -# Template used to display messages. This is a python new-style format string -# used to format the message information. See doc for all details. -#msg-template= - -# Set the output format. Available formats are text, parseable, colorized, json -# and msvs (visual studio). You can also give a reporter class, e.g. -# mypackage.mymodule.MyReporterClass. -output-format=text - -# Tells whether to display a full report or only the messages. -reports=no - -# Activate the evaluation score. -score=yes - - -[REFACTORING] - -# Maximum number of nested blocks for function / method body -max-nested-blocks=5 - -# Complete name of functions that never returns. When checking for -# inconsistent-return-statements if a never returning function is called then -# it will be considered as an explicit return statement and no message will be -# printed. -never-returning-functions=sys.exit - - -[BASIC] - -# Naming style matching correct argument names. -argument-naming-style=snake_case - -# Regular expression matching correct argument names. Overrides argument- -# naming-style. -#argument-rgx= - -# Naming style matching correct attribute names. -attr-naming-style=snake_case - -# Regular expression matching correct attribute names. Overrides attr-naming- -# style. -#attr-rgx= - -# Bad variable names which should always be refused, separated by a comma. -bad-names=foo, - bar, - baz, - toto, - tutu, - tata - -# Bad variable names regexes, separated by a comma. If names match any regex, -# they will always be refused -bad-names-rgxs= - -# Naming style matching correct class attribute names. -class-attribute-naming-style=any - -# Regular expression matching correct class attribute names. Overrides class- -# attribute-naming-style. -#class-attribute-rgx= - -# Naming style matching correct class constant names. -class-const-naming-style=UPPER_CASE - -# Regular expression matching correct class constant names. Overrides class- -# const-naming-style. -#class-const-rgx= - -# Naming style matching correct class names. -class-naming-style=PascalCase - -# Regular expression matching correct class names. Overrides class-naming- -# style. -#class-rgx= - -# Naming style matching correct constant names. -const-naming-style=UPPER_CASE - -# Regular expression matching correct constant names. Overrides const-naming- -# style. -#const-rgx= - -# Minimum line length for functions/classes that require docstrings, shorter -# ones are exempt. -docstring-min-length=-1 - -# Naming style matching correct function names. -function-naming-style=snake_case - -# Regular expression matching correct function names. Overrides function- -# naming-style. -#function-rgx= - -# Good variable names which should always be accepted, separated by a comma. -good-names=i, - j, - k, - ex, - Run, - _ - -# Good variable names regexes, separated by a comma. If names match any regex, -# they will always be accepted -good-names-rgxs= - -# Include a hint for the correct naming format with invalid-name. -include-naming-hint=no - -# Naming style matching correct inline iteration names. -inlinevar-naming-style=any - -# Regular expression matching correct inline iteration names. Overrides -# inlinevar-naming-style. -#inlinevar-rgx= - -# Naming style matching correct method names. -method-naming-style=snake_case - -# Regular expression matching correct method names. Overrides method-naming- -# style. -#method-rgx= - -# Naming style matching correct module names. -module-naming-style=snake_case - -# Regular expression matching correct module names. Overrides module-naming- -# style. -#module-rgx= - -# Colon-delimited sets of names that determine each other's naming style when -# the name regexes allow several styles. -name-group= - -# Regular expression which should only match function or class names that do -# not require a docstring. -no-docstring-rgx=^_ - -# List of decorators that produce properties, such as abc.abstractproperty. Add -# to this list to register other decorators that produce valid properties. -# These decorators are taken in consideration only for invalid-name. -property-classes=abc.abstractproperty - -# Naming style matching correct variable names. -variable-naming-style=snake_case - -# Regular expression matching correct variable names. Overrides variable- -# naming-style. -#variable-rgx= - - -[FORMAT] - -# Expected format of line ending, e.g. empty (any line ending), LF or CRLF. -expected-line-ending-format= - -# Regexp for a line that is allowed to be longer than the limit. -ignore-long-lines=^\s*(# )??$ - -# Number of spaces of indent required inside a hanging or continued line. -indent-after-paren=4 - -# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 -# tab). -indent-string=' ' - -# Maximum number of characters on a single line. -max-line-length=80 - -# Maximum number of lines in a module. -max-module-lines=1000 - -# Allow the body of a class to be on the same line as the declaration if body -# contains single statement. -single-line-class-stmt=no - -# Allow the body of an if to be on the same line as the test if there is no -# else. -single-line-if-stmt=no - - -[LOGGING] - -# The type of string formatting that logging methods do. `old` means using % -# formatting, `new` is for `{}` formatting. -logging-format-style=old - -# Logging modules to check that the string format arguments are in logging -# function parameter format. -logging-modules=logging - - -[MISCELLANEOUS] - -# List of note tags to take in consideration, separated by a comma. -notes=FIXME, - XXX, - TODO - -# Regular expression of note tags to take in consideration. -#notes-rgx= - - -[SIMILARITIES] - -# Ignore comments when computing similarities. -ignore-comments=yes - -# Ignore docstrings when computing similarities. -ignore-docstrings=yes - -# Ignore imports when computing similarities. -ignore-imports=no - -# Minimum lines number of a similarity. -min-similarity-lines=4 - - -[SPELLING] - -# Limits count of emitted suggestions for spelling mistakes. -max-spelling-suggestions=4 - -# Spelling dictionary name. Available dictionaries: none. To make it work, -# install the 'python-enchant' package. -spelling-dict= - -# List of comma separated words that should not be checked. -spelling-ignore-words= - -# A path to a file that contains the private dictionary; one word per line. -spelling-private-dict-file= - -# Tells whether to store unknown words to the private dictionary (see the -# --spelling-private-dict-file option) instead of raising a message. -spelling-store-unknown-words=no - - -[STRING] - -# This flag controls whether inconsistent-quotes generates a warning when the -# character used as a quote delimiter is used inconsistently within a module. -check-quote-consistency=no - -# This flag controls whether the implicit-str-concat should generate a warning -# on implicit string concatenation in sequences defined over several lines. -check-str-concat-over-line-jumps=no - - -[TYPECHECK] - -# List of decorators that produce context managers, such as -# contextlib.contextmanager. Add to this list to register other decorators that -# produce valid context managers. -contextmanager-decorators=contextlib.contextmanager - -# List of members which are set dynamically and missed by pylint inference -# system, and so shouldn't trigger E1101 when accessed. Python regular -# expressions are accepted. -generated-members= - -# Tells whether missing members accessed in mixin class should be ignored. A -# mixin class is detected if its name ends with "mixin" (case insensitive). -ignore-mixin-members=yes - -# Tells whether to warn about missing members when the owner of the attribute -# is inferred to be None. -ignore-none=yes - -# This flag controls whether pylint should warn about no-member and similar -# checks whenever an opaque object is returned when inferring. The inference -# can return multiple potential results while evaluating a Python object, but -# some branches might not be evaluated, which results in partial inference. In -# that case, it might be useful to still emit no-member and other checks for -# the rest of the inferred objects. -ignore-on-opaque-inference=yes - -# List of class names for which member attributes should not be checked (useful -# for classes with dynamically set attributes). This supports the use of -# qualified names. -ignored-classes=optparse.Values,thread._local,_thread._local - -# List of module names for which member attributes should not be checked -# (useful for modules/projects where namespaces are manipulated during runtime -# and thus existing member attributes cannot be deduced by static analysis). It -# supports qualified module names, as well as Unix pattern matching. -ignored-modules= - -# Show a hint with possible names when a member name was not found. The aspect -# of finding the hint is based on edit distance. -missing-member-hint=yes - -# The minimum edit distance a name should have in order to be considered a -# similar match for a missing member name. -missing-member-hint-distance=1 - -# The total number of similar names that should be taken in consideration when -# showing a hint for a missing member. -missing-member-max-choices=1 - -# List of decorators that change the signature of a decorated function. -signature-mutators= - - -[VARIABLES] - -# List of additional names supposed to be defined in builtins. Remember that -# you should avoid defining new builtins when possible. -additional-builtins= - -# Tells whether unused global variables should be treated as a violation. -allow-global-unused-variables=yes - -# List of names allowed to shadow builtins -allowed-redefined-builtins= - -# List of strings which can identify a callback function by name. A callback -# name must start or end with one of those strings. -callbacks=cb_, - _cb - -# A regular expression matching the name of dummy variables (i.e. expected to -# not be used). -dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_ - -# Argument names that match this expression will be ignored. Default to name -# with leading underscore. -ignored-argument-names=_.*|^ignored_|^unused_ - -# Tells whether we should check for unused import in __init__ files. -init-import=no - -# List of qualified module names which can have objects that can redefine -# builtins. -redefining-builtins-modules=six.moves,past.builtins,future.builtins,builtins,io - - -[CLASSES] - -# Warn about protected attribute access inside special methods -check-protected-access-in-special-methods=no - -# List of method names used to declare (i.e. assign) instance attributes. -defining-attr-methods=__init__, - __new__, - setUp, - __post_init__ - -# List of member names, which should be excluded from the protected access -# warning. -exclude-protected=_asdict, - _fields, - _replace, - _source, - _make - -# List of valid names for the first argument in a class method. -valid-classmethod-first-arg=cls - -# List of valid names for the first argument in a metaclass class method. -valid-metaclass-classmethod-first-arg=cls - - -[DESIGN] - -# Maximum number of arguments for function / method. -max-args=8 - -# Maximum number of attributes for a class (see R0902). -max-attributes=7 - -# Maximum number of boolean expressions in an if statement (see R0916). -max-bool-expr=5 - -# Maximum number of branch for function / method body. -max-branches=12 - -# Maximum number of locals for function / method body. -max-locals=15 - -# Maximum number of parents for a class (see R0901). -max-parents=7 - -# Maximum number of public methods for a class (see R0904). -max-public-methods=20 - -# Maximum number of return / yield for function / method body. -max-returns=6 - -# Maximum number of statements in function / method body. -max-statements=50 - -# Minimum number of public methods for a class (see R0903). -min-public-methods=2 - - -[IMPORTS] - -# List of modules that can be imported at any level, not just the top level -# one. -allow-any-import-level= - -# Allow wildcard imports from modules that define __all__. -allow-wildcard-with-all=no - -# Analyse import fallback blocks. This can be used to support both Python 2 and -# 3 compatible code, which means that the block might have code that exists -# only in one or another interpreter, leading to false positives when analysed. -analyse-fallback-blocks=no - -# Deprecated modules which should not be used, separated by a comma. -deprecated-modules=tkinter.tix - -# Output a graph (.gv or any supported image format) of external dependencies -# to the given file (report RP0402 must not be disabled). -ext-import-graph= - -# Output a graph (.gv or any supported image format) of all (i.e. internal and -# external) dependencies to the given file (report RP0402 must not be -# disabled). -import-graph= - -# Output a graph (.gv or any supported image format) of internal dependencies -# to the given file (report RP0402 must not be disabled). -int-import-graph= - -# Force import order to recognize a module as part of the standard -# compatibility libraries. -known-standard-library= - -# Force import order to recognize a module as part of a third party library. -known-third-party=enchant - -# Couples of modules and preferred modules, separated by a comma. -preferred-modules= - - -[EXCEPTIONS] - -# Exceptions that will emit a warning when being caught. Defaults to -# "BaseException, Exception". -overgeneral-exceptions=BaseException, - Exception diff --git a/PRESUBMIT.py b/PRESUBMIT.py index eed7c19cc6e..030e03b05bf 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -6,6 +6,7 @@ import collections.abc import copy import os +import sys import brave_node import chromium_presubmit_overrides @@ -16,7 +17,7 @@ import override_utils USE_PYTHON3 = True PRESUBMIT_VERSION = '2.0.0' -# pylint: disable=line-too-long,protected-access,undefined-variable +# pylint: disable=line-too-long # Adds support for chromium_presubmit_config.json5 and some helpers. @@ -150,7 +151,7 @@ def CheckESLint(input_api, output_api): with import_inline.sys_path( input_api.os_path.join(input_api.PresubmitLocalPath(), '..', 'tools')): - # pylint: disable=import-error,import-outside-toplevel + # pylint: disable=import-outside-toplevel from web_dev_style import js_checker return js_checker.JSChecker(input_api, output_api).RunEsLintChecks(files_to_check) @@ -160,7 +161,7 @@ def CheckWebDevStyle(input_api, output_api): with import_inline.sys_path( input_api.os_path.join(input_api.PresubmitLocalPath(), '..', 'tools')): - # pylint: disable=import-error,import-outside-toplevel + # pylint: disable=import-outside-toplevel from web_dev_style import presubmit_support, js_checker # Disable RunEsLintChecks, it's run separately in CheckESLint. with override_utils.override_scope_function( @@ -180,9 +181,6 @@ def CheckPylint(input_api, output_api): extra_paths_list = os.environ['PYTHONPATH'].split(os.pathsep) return input_api.canned_checks.RunPylint(input_api, output_api, - pylintrc=input_api.os_path.join( - input_api.PresubmitLocalPath(), - '.pylintrc'), extra_paths_list=extra_paths_list) @@ -313,7 +311,7 @@ def ApplyBanRuleExcludes(): value for name, value in globals().items() if name.startswith('_BANNED_') and isinstance(value, collections.abc.Sequence) and len(value) > 0 - and isinstance(value[0], BanRule) # pylint: disable=undefined-variable + and isinstance(value[0], BanRule) ] # Get additional excluded paths from the config. @@ -407,7 +405,6 @@ def CheckJavaStyle(_original_check, input_api, output_api): for f in input_api.AffectedFiles()): return [] - import sys # pylint: disable=import-outside-toplevel # Android toolchain is only available on Linux. if not sys.platform.startswith('linux'): return [] @@ -415,7 +412,8 @@ def CheckJavaStyle(_original_check, input_api, output_api): with import_inline.sys_path( input_api.os_path.join(input_api.PresubmitLocalPath(), 'tools', 'android')): - from checkstyle import checkstyle # pylint: disable=import-outside-toplevel, import-error + # pylint: disable=import-outside-toplevel + from checkstyle import checkstyle files_to_skip = input_api.DEFAULT_FILES_TO_SKIP diff --git a/chromium_src/PRESUBMIT.py b/chromium_src/PRESUBMIT.py index 925337f4f1a..6babe9c7f98 100644 --- a/chromium_src/PRESUBMIT.py +++ b/chromium_src/PRESUBMIT.py @@ -52,7 +52,7 @@ def CheckOverrides(input_api, output_api): with import_inline.sys_path( input_api.os_path.join(input_api.PresubmitLocalPath(), '..', 'tools')): - # pylint: disable=import-error,import-outside-toplevel + # pylint: disable=import-outside-toplevel from chromium_src import check_chromium_src overrides = [ f.AbsoluteLocalPath() for f in input_api.AffectedSourceFiles(None) diff --git a/chromium_src/build/android/gradle/generate_gradle.py b/chromium_src/build/android/gradle/generate_gradle.py index 92021bac5ef..19a53211232 100644 --- a/chromium_src/build/android/gradle/generate_gradle.py +++ b/chromium_src/build/android/gradle/generate_gradle.py @@ -12,7 +12,6 @@ _INPUT_SRC_JARS = 'input_srcjars' _BRAVE_GEN_COMPONENTS = os.path.join('gen', 'brave', 'components') -# pylint: disable=undefined-variable @override_utils.override_method(_ProjectEntry) def GeneratedJavaSubdir(self, _): gen_path = os.path.join('gen', self.GradleSubdir(), _GENERATED_JAVA_SUBDIR) diff --git a/chromium_src/buildtools/checkdeps/checkdeps.py b/chromium_src/buildtools/checkdeps/checkdeps.py index bb1724561c6..8d93252f252 100644 --- a/chromium_src/buildtools/checkdeps/checkdeps.py +++ b/chromium_src/buildtools/checkdeps/checkdeps.py @@ -6,7 +6,6 @@ import posixpath -# pylint: disable=import-error,too-few-public-methods from builddeps import NormalizePath diff --git a/chromium_src/chrome/tools/build/win/create_installer_archive.py b/chromium_src/chrome/tools/build/win/create_installer_archive.py index cc28a59894f..53f7da1dd7a 100644 --- a/chromium_src/chrome/tools/build/win/create_installer_archive.py +++ b/chromium_src/chrome/tools/build/win/create_installer_archive.py @@ -3,8 +3,6 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this file, # You can obtain one at https://mozilla.org/MPL/2.0/. -# pylint: disable=too-many-arguments,undefined-variable,unused-argument -# pylint: disable=no-value-for-parameter import os import re @@ -36,7 +34,7 @@ def CopyAllFilesToStagingDir(original_function, config, distribution, @override_utils.override_function(globals()) -def GetPrevVersion(_, build_dir, temp_dir, last_chrome_installer, output_name): +def GetPrevVersion(_, build_dir, _temp_dir, last_chrome_installer, output_name): # We override GetPrevVersion because it has an unwanted side effect. The # `temp_dir` it gets passed is actually the staging directory. The original # GetPrevVersion places the previous version's chrome.dll inside this @@ -58,6 +56,7 @@ def GetPrevVersion(_, build_dir, temp_dir, last_chrome_installer, output_name): stderr=subprocess.STDOUT, text=True) except subprocess.CalledProcessError as e: + # pylint: disable=raise-missing-from raise Exception("Error while running cmd: %s\n" "Exit code: %s\n" "Command output:\n%s" % (e.cmd, e.returncode, e.output)) diff --git a/chromium_src/mojo/public/tools/mojom/mojom_parser.py b/chromium_src/mojo/public/tools/mojom/mojom_parser.py index d8ce6f6f309..cfafa60ae6a 100644 --- a/chromium_src/mojo/public/tools/mojom/mojom_parser.py +++ b/chromium_src/mojo/public/tools/mojom/mojom_parser.py @@ -6,7 +6,6 @@ import codecs import os.path -# pylint: disable=import-error from mojom.parse import ast from mojom.parse import conditional_features from mojom.parse import parser diff --git a/chromium_src/third_party/blink/renderer/bindings/scripts/bind_gen/interface.py b/chromium_src/third_party/blink/renderer/bindings/scripts/bind_gen/interface.py index 2ce6163f4e3..598e1b16ddd 100644 --- a/chromium_src/third_party/blink/renderer/bindings/scripts/bind_gen/interface.py +++ b/chromium_src/third_party/blink/renderer/bindings/scripts/bind_gen/interface.py @@ -14,10 +14,10 @@ import override_utils SCRIPTS_DIR = os.path.abspath(os.path.dirname(os.path.dirname(__file__))) sys.path.insert(1, SCRIPTS_DIR) -from bind_gen.code_node import SymbolNode, TextNode # pylint: disable=import-error,wrong-import-position -from bind_gen.codegen_accumulator import CodeGenAccumulator # pylint: disable=import-error,wrong-import-position -from bind_gen.codegen_context import CodeGenContext # pylint: disable=import-error,wrong-import-position -from bind_gen.codegen_format import format_template as _format # pylint: disable=import-error,wrong-import-position +from bind_gen.code_node import SymbolNode, TextNode +from bind_gen.codegen_accumulator import CodeGenAccumulator +from bind_gen.codegen_context import CodeGenContext +from bind_gen.codegen_format import format_template as _format # Get gn arg to enable WebAPI probes. _IS_PG_WEBAPI_PROBES_ENABLED = override_utils.get_gn_arg( diff --git a/chromium_src/tools/clang/pylib/clang/compile_db.py b/chromium_src/tools/clang/pylib/clang/compile_db.py index 710fa5b008c..9a41b4c5b37 100644 --- a/chromium_src/tools/clang/pylib/clang/compile_db.py +++ b/chromium_src/tools/clang/pylib/clang/compile_db.py @@ -9,12 +9,13 @@ import re import override_utils # Remove redirect_cc from the command line. -GOMACC_PATTERN_TO_REPLACE = (r'gomacc(\.exe)', r'(gomacc|redirect_cc)(\.exe)') +CMD_PATTERN_TO_REPLACE = (r'rewrapper(\.exe)', + r'(rewrapper|redirect_cc)(\.exe)') -# pylint: disable=used-before-assignment -assert GOMACC_PATTERN_TO_REPLACE[0] in _CLANG_WRAPPER_CMD_LINE_RE.pattern +_CLANG_WRAPPER_CMD_LINE_RE: object # Injected from upstream compile_db.py. +assert CMD_PATTERN_TO_REPLACE[0] in _CLANG_WRAPPER_CMD_LINE_RE.pattern _CLANG_WRAPPER_CMD_LINE_RE = re.compile( - _CLANG_WRAPPER_CMD_LINE_RE.pattern.replace(*GOMACC_PATTERN_TO_REPLACE), + _CLANG_WRAPPER_CMD_LINE_RE.pattern.replace(*CMD_PATTERN_TO_REPLACE), re.VERBOSE) diff --git a/chromium_src/tools/grit/grit/gather/policy_json.py b/chromium_src/tools/grit/grit/gather/policy_json.py index 88a176d5dc3..ef89df5ae77 100644 --- a/chromium_src/tools/grit/grit/gather/policy_json.py +++ b/chromium_src/tools/grit/grit/gather/policy_json.py @@ -5,11 +5,12 @@ import override_utils + @override_utils.override_method(PolicyJson) -def SetDefines(self, _, defines): - self._config = { - 'build': 'brave', - 'app_name': 'Brave', - 'frame_name': 'Brave Frame', - 'os_name': 'Google Chrome OS' - } +def SetDefines(self, _orig_method, _defines): + self._config = { + 'build': 'brave', + 'app_name': 'Brave', + 'frame_name': 'Brave Frame', + 'os_name': 'Google Chrome OS' + } diff --git a/chromium_src/tools/json_schema_compiler/feature_compiler.py b/chromium_src/tools/json_schema_compiler/feature_compiler.py index 46bfad5e6f0..9cc63742443 100644 --- a/chromium_src/tools/json_schema_compiler/feature_compiler.py +++ b/chromium_src/tools/json_schema_compiler/feature_compiler.py @@ -3,7 +3,7 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this file, # You can obtain one at https://mozilla.org/MPL/2.0/. -#pylint: disable=line-too-long,too-few-public-methods,undefined-variable,protected-access +# pylint: disable=line-too-long import import_inline import override_utils diff --git a/chromium_src/tools/perf/core/results_dashboard.py b/chromium_src/tools/perf/core/results_dashboard.py index b8a640b7439..2f533d66bf3 100644 --- a/chromium_src/tools/perf/core/results_dashboard.py +++ b/chromium_src/tools/perf/core/results_dashboard.py @@ -9,7 +9,7 @@ import subprocess import override_utils -from core import path_util # pylint: disable=import-error +from core import path_util def BraveAuthTokenGeneratorCallback(): diff --git a/tools/android/generate_breakpad_symbols.py b/tools/android/generate_breakpad_symbols.py old mode 100644 new mode 100755 index 4c5adb1b1af..96fec0a279e --- a/tools/android/generate_breakpad_symbols.py +++ b/tools/android/generate_breakpad_symbols.py @@ -132,7 +132,7 @@ def InvokeChromiumGenerateSymbols(args, lib_paths): # Lets fail just not to ignore something important at_least_one_failed.value = True - except Exception as e: # pylint: disable=broad-except + except Exception as e: if args.verbose: with print_lock: print(type(e)) diff --git a/tools/chromium_src/check_chromium_src.py b/tools/chromium_src/check_chromium_src.py index 7dd318e98eb..c29de79c3d1 100755 --- a/tools/chromium_src/check_chromium_src.py +++ b/tools/chromium_src/check_chromium_src.py @@ -456,7 +456,7 @@ class ChromiumSrcOverridesChecker: json5_path = os.path.join(CHROMIUM_SRC, 'third_party', 'pyjson5', 'src') sys.path.append(json5_path) - # pylint: disable=import-outside-toplevel,import-error + # pylint: disable=import-outside-toplevel import json5 with open(config_path, "r", encoding='utf-8') as exclusions_file: diff --git a/tools/posix/generate_breakpad_symbols.py b/tools/posix/generate_breakpad_symbols.py index 428ecc418de..e18cabbf74b 100755 --- a/tools/posix/generate_breakpad_symbols.py +++ b/tools/posix/generate_breakpad_symbols.py @@ -24,7 +24,7 @@ import threading sys.path.append(os.path.join(os.path.dirname(__file__), os.pardir, os.pardir, os.pardir, "build")) -import gn_helpers # pylint: disable=wrong-import-position +import gn_helpers CONCURRENT_TASKS=4 @@ -203,7 +203,7 @@ def GenerateSymbols(options, binaries): f = open(os.path.join(output_path, symbol_file), 'w') f.write(syms) f.close() - except Exception as inst: # pylint: disable=broad-except + except Exception as inst: with print_lock: print(f'Symbol failure {binary} {type(inst)} {inst}') finally: diff --git a/tools/win/create_delta_archive.py b/tools/win/create_delta_archive.py index 9eea45dd2b9..8b3c2131b0c 100644 --- a/tools/win/create_delta_archive.py +++ b/tools/win/create_delta_archive.py @@ -11,7 +11,6 @@ from subprocess import check_call from import_inline import sys_path with sys_path('//chrome/tools/build/win'): - # pylint: disable=import-error, wrong-import-position import create_installer_archive as upstream_impl