From a9381fecc2c879bb39f983cd1ba731c63a36be30 Mon Sep 17 00:00:00 2001 From: Simon Hong Date: Tue, 12 May 2026 20:11:10 +0900 Subject: [PATCH] Improve brave_interactive_ui_tests target (#36297) Added missing //chrome/installer/util:strings deps on Windows - some installer strings are used in admin user - used BraveTestLauncherDelegate --- .../chrome/test/base/interactive_ui_tests_main.cc | 15 +++++++++++++++ test/BUILD.gn | 5 +++++ 2 files changed, 20 insertions(+) create mode 100644 chromium_src/chrome/test/base/interactive_ui_tests_main.cc diff --git a/chromium_src/chrome/test/base/interactive_ui_tests_main.cc b/chromium_src/chrome/test/base/interactive_ui_tests_main.cc new file mode 100644 index 00000000000..6585a365955 --- /dev/null +++ b/chromium_src/chrome/test/base/interactive_ui_tests_main.cc @@ -0,0 +1,15 @@ +/* Copyright (c) 2026 The Brave Authors. All rights reserved. + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this file, + * You can obtain one at https://mozilla.org/MPL/2.0/. */ + +#include "brave/test/base/brave_test_launcher_delegate.h" + +// Apply Brave-specific behavior change in the test launcher delegate. +// * Suppress first run dialog (Mac/Linux). +// * Suppress browser window closing dialog. +#define ChromeTestLauncherDelegate BraveTestLauncherDelegate + +#include + +#undef ChromeTestLauncherDelegate diff --git a/test/BUILD.gn b/test/BUILD.gn index 8545e67b0f3..520fe153a14 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -760,6 +760,7 @@ if (!is_android) { sources = [ "//chrome/test/base/interactive_ui_tests_main.cc" ] deps = [ + ":browser_test_support", "//brave:packed_resources", "//chrome:packed_resources", "//chrome/browser", @@ -770,6 +771,10 @@ if (!is_android) { "//ui/compositor", ] + if (is_win) { + deps += [ "//chrome/installer/util:strings" ] + } + if (enable_commander) { deps += [ "//brave/browser/ui/commander:interactive_ui_tests" ] }