[cr148][Android] Changes at ShareDelegateImpl.ctor
New args: signinAndHistorySyncActivityLauncher; activityResultTracker; modalDialogManagerSupplier; snackbarManager. Chromium change: https://source.chromium.org/chromium/chromium/src/+/0af385e0296806bb278d2c4b73e7e652d310def5 commit 0af385e0296806bb278d2c4b73e7e652d310def5 Author: quacksort <quacksort@google.com> Date: Tue Mar 24 06:59:26 2026 -0700 [Signin][Android] Migrate send tab to self sign-in to activity-less flow This is part of the effort to reduce reliance on SigninAndHistorySyncActivity by sign-in entry points. go/activityless-signin The new flow uses BottomSheetSigninAndHistorySyncCoordinator to handle the sign-in process, avoiding the need to launch a separate activity. Bug: 478814334 Change-Id: I0448875de416af5e3e48d1ac5f2eeb3d18e6efcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7647173 Reviewed-by: Anton Goncharenko <agonch@google.com> Commit-Queue: Lucia Giorgi <quacksort@google.com> Cr-Commit-Position: refs/heads/main@{#1604087}
This commit is contained in:
@@ -8,6 +8,7 @@ package org.chromium.chrome.browser.share;
|
||||
import android.content.Context;
|
||||
|
||||
import org.chromium.base.BravePreferenceKeys;
|
||||
import org.chromium.base.supplier.MonotonicObservableSupplier;
|
||||
import org.chromium.build.annotations.NullMarked;
|
||||
import org.chromium.build.annotations.Nullable;
|
||||
import org.chromium.chrome.browser.data_sharing.DataSharingTabManager;
|
||||
@@ -16,7 +17,11 @@ import org.chromium.chrome.browser.preferences.ChromeSharedPreferences;
|
||||
import org.chromium.chrome.browser.profiles.Profile;
|
||||
import org.chromium.chrome.browser.tab.Tab;
|
||||
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
|
||||
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
|
||||
import org.chromium.chrome.browser.ui.signin.SigninAndHistorySyncActivityLauncher;
|
||||
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController;
|
||||
import org.chromium.ui.base.ActivityResultTracker;
|
||||
import org.chromium.ui.modaldialog.ModalDialogManager;
|
||||
|
||||
import java.util.function.Supplier;
|
||||
|
||||
@@ -31,7 +36,11 @@ public class BraveShareDelegateImpl extends ShareDelegateImpl {
|
||||
Supplier<@Nullable Profile> profileSupplier,
|
||||
ShareSheetDelegate delegate,
|
||||
boolean isCustomTab,
|
||||
@Nullable DataSharingTabManager dataSharingTabManager) {
|
||||
@Nullable DataSharingTabManager dataSharingTabManager,
|
||||
SigninAndHistorySyncActivityLauncher signinAndHistorySyncActivityLauncher,
|
||||
ActivityResultTracker activityResultTracker,
|
||||
MonotonicObservableSupplier<ModalDialogManager> modalDialogManagerSupplier,
|
||||
SnackbarManager snackbarManager) {
|
||||
super(
|
||||
context,
|
||||
controller,
|
||||
@@ -41,7 +50,11 @@ public class BraveShareDelegateImpl extends ShareDelegateImpl {
|
||||
profileSupplier,
|
||||
delegate,
|
||||
isCustomTab,
|
||||
dataSharingTabManager);
|
||||
dataSharingTabManager,
|
||||
signinAndHistorySyncActivityLauncher,
|
||||
activityResultTracker,
|
||||
modalDialogManagerSupplier,
|
||||
snackbarManager);
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
Reference in New Issue
Block a user