diff --git a/build/commands/lib/config.js b/build/commands/lib/config.js index 7958cd7eb36..9730a23317f 100755 --- a/build/commands/lib/config.js +++ b/build/commands/lib/config.js @@ -476,7 +476,7 @@ Config.prototype.buildArgs = function () { Config.prototype.shouldSign = function () { if (this.skip_signing || - this.buildConfig !== 'Release' || + this.isComponentBuild() || this.targetOS === 'ios') { return false } diff --git a/build/config.gni b/build/config.gni index f0d41ed672f..b85f33a40a8 100644 --- a/build/config.gni +++ b/build/config.gni @@ -8,7 +8,7 @@ declare_args() { # "nightly" for nightly channel release. # "" for stable channel release. brave_channel = "" - is_release_channel = true + is_release_channel = false base_sparkle_update_url = "" enable_sparkle = is_official_build && is_mac diff --git a/build/mac/DS_Store.development b/build/mac/DS_Store.development new file mode 100644 index 00000000000..ababf8f8d34 Binary files /dev/null and b/build/mac/DS_Store.development differ diff --git a/build/mac/dmg-development.icns b/build/mac/dmg-development.icns new file mode 100644 index 00000000000..3c6d4976c7d Binary files /dev/null and b/build/mac/dmg-development.icns differ diff --git a/script/signing_helper.py b/script/signing_helper.py index a1058befb5d..805b40348e1 100644 --- a/script/signing_helper.py +++ b/script/signing_helper.py @@ -143,6 +143,11 @@ def GetBraveSigningConfig(config_class, mac_provisioning_profile=None): """ Not chrome branded """ return False + @property + def distributions(self): + """ Brave distribution """ + return [model.Distribution(channel=brave_channel)] + config_class = ConfigNonChromeBranded if mac_provisioning_profile is not None: @@ -169,9 +174,4 @@ def GetBraveSigningConfig(config_class, mac_provisioning_profile=None): """ Run spctl check """ return True - @property - def distributions(self): - """ Brave distribution """ - return [model.Distribution(channel=brave_channel)] - return ProvisioningProfileCodeSignConfig