From ae470a75eebf22bf4d473ae34cefbaa2a0541dce Mon Sep 17 00:00:00 2001 From: Simon Hong Date: Fri, 7 Oct 2022 08:35:36 +0900 Subject: [PATCH] Added more null check when checking NTP search conversion https://github.com/brave/brave-browser/issues/25849 --- components/brave_search_conversion/utils.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/components/brave_search_conversion/utils.cc b/components/brave_search_conversion/utils.cc index c954e6dd90a..7cbf60756fe 100644 --- a/components/brave_search_conversion/utils.cc +++ b/components/brave_search_conversion/utils.cc @@ -33,7 +33,11 @@ bool IsNTPPromotionEnabled(PrefService* prefs, TemplateURLService* service) { // Don't need to prompt for conversion if user uses brave as a default // provider. - auto id = service->GetDefaultSearchProvider()->data().prepopulate_id; + auto* template_url = service->GetDefaultSearchProvider(); + if (!template_url) + return false; + + const auto id = template_url->prepopulate_id(); if (id == TemplateURLPrepopulateData::PREPOPULATED_ENGINE_ID_BRAVE || id == TemplateURLPrepopulateData::PREPOPULATED_ENGINE_ID_BRAVE_TOR) { return false;