[cr144][Android] New arg clientPackageName at BaseCustomTabRootUiCoordinator.ctor
Chromium change: https://source.chromium.org/chromium/chromium/src/+/02817219ab601f30168893303c8851195e89f200 Window Controls Overlay on Android: Toggle button Similar to the UI for Window Controls Overlay on other platforms, provide a toggle button to enable/disabled the Window Controls Overlay. Other platforms use single chevron for the toggle button. However, this looks very similar to a chevron that is present in Android's desktop windowing system UI. Use unfold icons instead for differentiation. Screenshots: When disabled, to enable: https://drive.google.com/file/d/1jxs5koZg0kffQEBFaHWy-P8y8PAdN2HU When enabled, to disable: https://drive.google.com/file/d/1tsL3jmk93XUVO464LwlRweYO7ebzvpbk/view?usp=drive_link Fixed: 447455087 Change-Id: I11f50cf9e7bf5e93967cec2aac18e7860a97eac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7069865
This commit is contained in:
@@ -940,6 +940,7 @@
|
||||
*** mMinimizationManagerHolder;
|
||||
*** getAppHeaderCoordinator(...);
|
||||
*** getBrowserServicesThemeColorProvider(...);
|
||||
*** getClientPackageNameProvider(...);
|
||||
public <init>(...);
|
||||
}
|
||||
|
||||
|
||||
+8
-1
@@ -30,6 +30,7 @@ import androidx.core.content.ContextCompat;
|
||||
import org.chromium.base.IntentUtils;
|
||||
import org.chromium.chrome.R;
|
||||
import org.chromium.chrome.browser.browserservices.intents.BrowserServicesIntentDataProvider;
|
||||
import org.chromium.chrome.browser.browserservices.ui.controller.trustedwebactivity.ClientPackageNameProvider;
|
||||
import org.chromium.chrome.browser.customtabs.content.CustomTabActivityTabController;
|
||||
import org.chromium.chrome.browser.customtabs.features.minimizedcustomtab.CustomTabMinimizationManagerHolder;
|
||||
import org.chromium.chrome.browser.customtabs.features.toolbar.BrowserServicesThemeColorProvider;
|
||||
@@ -233,7 +234,8 @@ public class FullScreenCustomTabActivity extends CustomTabActivity {
|
||||
() -> getCustomTabActivityNavigationController().openCurrentUrlInBrowser(),
|
||||
getEdgeToEdgeManager(),
|
||||
getAppHeaderCoordinator(),
|
||||
this::getBrowserServicesThemeColorProvider);
|
||||
this::getBrowserServicesThemeColorProvider,
|
||||
getClientPackageNameProvider().get());
|
||||
return mBaseCustomTabRootUiCoordinator;
|
||||
}
|
||||
|
||||
@@ -246,4 +248,9 @@ public class FullScreenCustomTabActivity extends CustomTabActivity {
|
||||
assert false : "This methos should be overridden via bytecode manipulation!";
|
||||
return null;
|
||||
}
|
||||
|
||||
private ClientPackageNameProvider getClientPackageNameProvider() {
|
||||
assert false : "This method should be overridden via bytecode manipulation!";
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
+4
-2
@@ -94,7 +94,8 @@ public class FullScreenCustomTabRootUiCoordinator extends BaseCustomTabRootUiCoo
|
||||
@NonNull Runnable openInBrowserRunnable,
|
||||
@NonNull EdgeToEdgeManager edgeToEdgeManager,
|
||||
@Nullable DesktopWindowStateManager desktopWindowStateManager,
|
||||
@Nullable Supplier<BrowserServicesThemeColorProvider> webAppThemeColorProvider) {
|
||||
@Nullable Supplier<BrowserServicesThemeColorProvider> webAppThemeColorProvider,
|
||||
@Nullable String clientPackageName) {
|
||||
super(
|
||||
activity,
|
||||
shareDelegateSupplier,
|
||||
@@ -135,7 +136,8 @@ public class FullScreenCustomTabRootUiCoordinator extends BaseCustomTabRootUiCoo
|
||||
openInBrowserRunnable,
|
||||
edgeToEdgeManager,
|
||||
desktopWindowStateManager,
|
||||
webAppThemeColorProvider);
|
||||
webAppThemeColorProvider,
|
||||
clientPackageName);
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
Reference in New Issue
Block a user