From aff77155a2d0ae49e3dae7e650fdfdbc93f32481 Mon Sep 17 00:00:00 2001 From: AlexeyBarabash Date: Fri, 12 Mar 2021 14:00:29 +0200 Subject: [PATCH] Added P3A metric for reset progress marker operation --- components/p3a/brave_p3a_service.cc | 1 + components/sync/engine_impl/brave_model_type_worker.cc | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/components/p3a/brave_p3a_service.cc b/components/p3a/brave_p3a_service.cc index e3c2ef62457..e5a3c02493b 100644 --- a/components/p3a/brave_p3a_service.cc +++ b/components/p3a/brave_p3a_service.cc @@ -89,6 +89,7 @@ constexpr const char* kCollectedHistograms[] = { "Brave.Today.WeeklyMaxCardViewsCount", "Brave.Today.WeeklyMaxCardVisitsCount", "Brave.Sync.Status", + "Brave.Sync.ProgressTokenEverReset", "Brave.Uptime.BrowserOpenMinutes", "Brave.Welcome.InteractionStatus", diff --git a/components/sync/engine_impl/brave_model_type_worker.cc b/components/sync/engine_impl/brave_model_type_worker.cc index 200e3ee1b99..9135fc64028 100644 --- a/components/sync/engine_impl/brave_model_type_worker.cc +++ b/components/sync/engine_impl/brave_model_type_worker.cc @@ -8,6 +8,7 @@ #include #include "base/logging.h" +#include "base/metrics/histogram_functions.h" #include "components/sync/engine/model_type_processor.h" namespace syncer { @@ -72,7 +73,8 @@ bool BraveModelTypeWorker::IsResetProgressMarkerRequired( kMinimalTimeBetweenResetMarker) { // Reset progress marker due to 7th failure happening twice in a row // in less than 30mins - // P3A sample is 2 + // P3A sample is 1 + base::UmaHistogramExactLinear("Brave.Sync.ProgressTokenEverReset", 1, 1); return false; } @@ -99,6 +101,9 @@ bool BraveModelTypeWorker::IsResetProgressMarkerRequired( void BraveModelTypeWorker::ResetProgressMarker() { VLOG(1) << "Reset progress marker for type " << ModelTypeToString(type_); + // Normal reset of progress marker due to 7th failure + // P3A sample is 0 + base::UmaHistogramExactLinear("Brave.Sync.ProgressTokenEverReset", 0, 1); last_reset_marker_time_ = base::Time::Now(); model_type_state_.mutable_progress_marker()->clear_token(); }