diff --git a/components/misc_metrics/default_browser_monitor.cc b/components/misc_metrics/default_browser_monitor.cc index 3c0516ae62f..6becf1145dd 100644 --- a/components/misc_metrics/default_browser_monitor.cc +++ b/components/misc_metrics/default_browser_monitor.cc @@ -62,12 +62,8 @@ void DefaultBrowserMonitor::OnDefaultBrowserStateReceived(bool is_default) { cached_default_status_ = is_default; - int typical_answer = is_default ? 1 : 0; - int express_answer = is_default ? 1 : (INT_MAX - 1); - - UMA_HISTOGRAM_EXACT_LINEAR(kDefaultBrowserHistogramName, typical_answer, 2); - UMA_HISTOGRAM_EXACT_LINEAR(kDefaultBrowserDailyHistogramName, express_answer, - 2); + UMA_HISTOGRAM_BOOLEAN(kDefaultBrowserHistogramName, is_default); + UMA_HISTOGRAM_BOOLEAN(kDefaultBrowserDailyHistogramName, is_default); if (status_changed) { for (auto& observer : observers_) { diff --git a/components/misc_metrics/default_browser_monitor.h b/components/misc_metrics/default_browser_monitor.h index b75faa6af65..6dd7215b59f 100644 --- a/components/misc_metrics/default_browser_monitor.h +++ b/components/misc_metrics/default_browser_monitor.h @@ -21,7 +21,7 @@ namespace misc_metrics { inline constexpr char kDefaultBrowserHistogramName[] = "Brave.Core.IsDefault"; inline constexpr char kDefaultBrowserDailyHistogramName[] = - "Brave.Core.IsDefaultDaily"; + "Brave.Core.IsDefaultDaily.2"; // Periodically checks if the browser is the default browser and reports the // relevant metrics via P3A. diff --git a/components/misc_metrics/default_browser_monitor_unittest.cc b/components/misc_metrics/default_browser_monitor_unittest.cc index 08c53466b60..718e603d2e3 100644 --- a/components/misc_metrics/default_browser_monitor_unittest.cc +++ b/components/misc_metrics/default_browser_monitor_unittest.cc @@ -66,8 +66,7 @@ TEST_F(DefaultBrowserMonitorUnitTest, ReportsIsNotDefaultState) { CreateMonitor(); histogram_tester_.ExpectUniqueSample(kDefaultBrowserHistogramName, 0, 1); - histogram_tester_.ExpectUniqueSample(kDefaultBrowserDailyHistogramName, - INT_MAX - 1, 1); + histogram_tester_.ExpectUniqueSample(kDefaultBrowserDailyHistogramName, 0, 1); } TEST_F(DefaultBrowserMonitorUnitTest, ReportsIsDefaultState) { @@ -84,8 +83,7 @@ TEST_F(DefaultBrowserMonitorUnitTest, SwitchingBetweenNoAndYesStates) { CreateMonitor(); histogram_tester_.ExpectUniqueSample(kDefaultBrowserHistogramName, 0, 1); - histogram_tester_.ExpectUniqueSample(kDefaultBrowserDailyHistogramName, - INT_MAX - 1, 1); + histogram_tester_.ExpectUniqueSample(kDefaultBrowserDailyHistogramName, 0, 1); // Switch to "yes" state (true) and fast forward to trigger next check SetMockedDefaultBrowserStatus(true); @@ -103,8 +101,7 @@ TEST_F(DefaultBrowserMonitorUnitTest, SwitchingBetweenNoAndYesStates) { #endif histogram_tester_.ExpectBucketCount(kDefaultBrowserHistogramName, 0, 2); - histogram_tester_.ExpectBucketCount(kDefaultBrowserDailyHistogramName, - INT_MAX - 1, 2); + histogram_tester_.ExpectBucketCount(kDefaultBrowserDailyHistogramName, 0, 2); histogram_tester_.ExpectTotalCount(kDefaultBrowserHistogramName, 3); histogram_tester_.ExpectTotalCount(kDefaultBrowserDailyHistogramName, 3); diff --git a/components/p3a/metric_names.h b/components/p3a/metric_names.h index 91ac3a475c8..35b31230fd0 100644 --- a/components/p3a/metric_names.h +++ b/components/p3a/metric_names.h @@ -211,7 +211,7 @@ inline constexpr auto kCollectedExpressHistograms = .attributes = MetricAttributes{MetricAttribute::kAnswerIndex, MetricAttribute::kDateOfActivation, MetricAttribute::kVersion, MetricAttribute::kYoi, MetricAttribute::kChannel, MetricAttribute::kPlatform, MetricAttribute::kCountryCode, MetricAttribute::kWoi}, .record_activation_date = true, }}, - {"Brave.Core.IsDefaultDaily", MetricConfig{ + {"Brave.Core.IsDefaultDaily.2", MetricConfig{ .attributes = MetricAttributes{MetricAttribute::kAnswerIndex, MetricAttribute::kChannel, MetricAttribute::kDateOfInstall, MetricAttribute::kDateOfActivation, MetricAttribute::kGeneralPlatform, MetricAttribute::kSubregion, MetricAttribute::kVersion}, .record_activation_date = true, }},