Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr148][Android] Removed supportsFindInPage from BaseCustomTabRootUiCoordinator

Browse Source 
Chromium change
https://source.chromium.org/chromium/chromium/src/+/2ee27ab283f1578d5f35ac79ee7fcf62d2a951fe

commit 2ee27ab283f1578d5f35ac79ee7fcf62d2a951fe
Author: Henrique Nakashima <hnakashima@chromium.org>
Date:   Thu Apr 2 13:17:48 2026 -0700

    [Android] Null-annotate RootUiCoordinator (part 11)

    Fix 1 NullAway error due to:
    - mFindToolbarManager

    Clean up the always true supportFindInPage() to simplify nullability.

    Down to 48 errors.

    Change-Id: Iee0789070cd9904b08f827e481ce9ec3886bdb40
    Bug: 485252552
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7722900
    Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
    Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1609461}
This commit is contained in:
AlexeyBarabash
2026-04-27 12:01:01 +01:00
committed by Claudio DeSouza
parent a3000cb123
commit b9c2460005
4 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/customtabs/FullScreenCustomTabActivity.java
-1
View File
@@ -221,7 +221,6 @@ public class FullScreenCustomTabActivity extends CustomTabActivity {
getModalDialogManagerSupplier().asNonNull(),
/* appMenuBlocker= */ this,
this::supportsAppMenu,
this::supportsFindInPage,
getTabCreatorManagerSupplier(),
getFullscreenManager(),
getCompositorViewHolderSupplier(),
android/java/org/chromium/chrome/browser/customtabs/FullScreenCustomTabRootUiCoordinator.java
-2
View File
@@ -76,7 +76,6 @@ public class FullScreenCustomTabRootUiCoordinator extends BaseCustomTabRootUiCoo
@NonNull NonNullObservableSupplier<ModalDialogManager> modalDialogManagerSupplier,
@NonNull AppMenuBlocker appMenuBlocker,
@NonNull BooleanSupplier supportsAppMenuSupplier,
@NonNull BooleanSupplier supportsFindInPage,
@NonNull Supplier<TabCreatorManager> tabCreatorManagerSupplier,
@NonNull FullscreenManager fullscreenManager,
@NonNull MonotonicObservableSupplier<CompositorViewHolder> compositorViewHolderSupplier,
@@ -123,7 +122,6 @@ public class FullScreenCustomTabRootUiCoordinator extends BaseCustomTabRootUiCoo
modalDialogManagerSupplier,
appMenuBlocker,
supportsAppMenuSupplier,
supportsFindInPage,
tabCreatorManagerSupplier,
fullscreenManager,
compositorViewHolderSupplier,
android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedRootUiCoordinator.java
-2
View File
@@ -107,7 +107,6 @@ public class BraveTabbedRootUiCoordinator extends TabbedRootUiCoordinator {
MonotonicObservableSupplier<ModalDialogManager> modalDialogManagerSupplier,
AppMenuBlocker appMenuBlocker,
BooleanSupplier supportsAppMenuSupplier,
BooleanSupplier supportsFindInPage,
Supplier<TabCreatorManager> tabCreatorManagerSupplier,
FullscreenManager fullscreenManager,
Supplier<CompositorViewHolder> compositorViewHolderSupplier,
@@ -163,7 +162,6 @@ public class BraveTabbedRootUiCoordinator extends TabbedRootUiCoordinator {
modalDialogManagerSupplier,
appMenuBlocker,
supportsAppMenuSupplier,
supportsFindInPage,
tabCreatorManagerSupplier,
fullscreenManager,
compositorViewHolderSupplier,