From bd450fd91cc334cfaa97667971155e45bf46e152 Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Sat, 2 May 2026 01:00:38 +0100 Subject: [PATCH] [cr149] Fixing `BraveSpecificsToModel` due to last field change This field used to be a bool, but it is now an enum. This change corrects the implementation of `BraveSpecificsToModel`, which is supposed to stay in sycn with `DeviceInfo`. Chromium changes: https://chromium.googlesource.com/chromium/src/+/2beaaac13944769bdb69f50226ddb84e8e840456 commit 2beaaac13944769bdb69f50226ddb84e8e840456 Author: Theodore Olsauskas-Warren Date: Thu Apr 30 10:56:48 2026 -0700 [Glic] Move experimental triggering in DeviceInfo to use Enum Update the recently added bool glic_experimental_triggering_opted_in to use an enum, updating its name to match. The previously added proto entry is removed and the value reused, there is no practical risk of version mismatch (and bool values map to enum versions that are reasonably safe). Change-Id: I231dca339fa09a72d6b79d7a4aeb12d3e9b3b761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7796299 Reviewed-by: Mikel Astiz Reviewed-by: David Trainor Reviewed-by: Maria Petrisor Reviewed-by: Shakti Sahu Reviewed-by: Roman Arora Commit-Queue: Theodore Olsauskas-Warren Reviewed-by: Min Qin Reviewed-by: Rohit Rao Reviewed-by: Tommy Nyquist Cr-Commit-Position: refs/heads/main@{#1623334} --- .../components/sync_device_info/device_info_sync_bridge.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chromium_src/components/sync_device_info/device_info_sync_bridge.cc b/chromium_src/components/sync_device_info/device_info_sync_bridge.cc index 54e1504041f..1e1b02ef324 100644 --- a/chromium_src/components/sync_device_info/device_info_sync_bridge.cc +++ b/chromium_src/components/sync_device_info/device_info_sync_bridge.cc @@ -87,7 +87,7 @@ std::unique_ptr BraveSpecificsToModel( SpecificsToAutoSignOutLastSigninTimestamp(specifics), specifics.feature_fields().desktop_to_ios_promo_receiving_enabled(), SpecificsToDesktopToIOSPromoReceivingTypes(specifics), - specifics.feature_fields().glic_experimental_triggering_opted_in(), + SpecificsToGlicExperimentalTriggeringState(specifics), SpecificsToSelfDeleteSupport(specifics)); }