From c000b38890ac6da28d66fc3954ae0545ae2f4787 Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Sun, 31 Aug 2025 19:48:55 +0100 Subject: [PATCH] [cr141] `//ui/native_theme` now a single target Chromium changes: https://chromium.googlesource.com/chromium/src/+/07a2719a22e6c57f81b5063877cc42e6aeb4b362 commit 07a2719a22e6c57f81b5063877cc42e6aeb4b362 Author: Peter Kasting Date: Thu Aug 28 15:16:29 2025 -0700 Fold native_theme_browser into native_theme. This was split out many years ago to prevent people from accidentally using the Windows native theme impl, which can't work in the renderer sandbox, directly from Blink. Unfortunately, it also prevents #including native_theme_win.h from native_theme.cc, which I need to do as part of refactoring NativeTheme construction. Recombining these shouldn't cause any compile or runtime problems; it just means that if somehow people call NativeThemeWin methods from Blink code (which there should be no reason to do) it will be an error at runtime instead of link time. Bug: 431953872 Change-Id: I836456bf5321bb30173a8125b5765ae56d80d39a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6882627 Auto-Submit: Peter Kasting Commit-Queue: Peter Kasting Reviewed-by: Elly FJ Owners-Override: Nico Weber Cr-Commit-Position: refs/heads/main@{#1508050} --- browser/themes/BUILD.gn | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/browser/themes/BUILD.gn b/browser/themes/BUILD.gn index 2f56c655169..813be25b464 100644 --- a/browser/themes/BUILD.gn +++ b/browser/themes/BUILD.gn @@ -31,9 +31,6 @@ source_set("themes") { sources += [ "brave_dark_mode_utils_win.cc" ] } - deps += [ - "//ui/native_theme", - "//ui/native_theme:native_theme_browser", - ] + deps += [ "//ui/native_theme" ] } }