From c164d6759c8ae7daf74f0ec997a7f7b0236e4ad2 Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Mon, 15 Dec 2025 12:01:42 +0000 Subject: [PATCH] [cr145] IWYU for `callback_helpers.h` This change does IWYU additions for all cases where `base::DoNothing` is used. Furthermore, this change removes some of the uses of `base::DoNothing` as an argument default value in a header, removing the need to add `callback_helpers.h` to those headers. Chromium changes: https://chromium.googlesource.com/chromium/src/+/e8436cccafc34d6e4d9c060f682345060579d208 https://chromium.googlesource.com/chromium/src/+/227f058d9b9e27370a64b34046d71b9f23106409 commit e8436cccafc34d6e4d9c060f682345060579d208 Author: Lei Zhang Date: Fri Dec 12 15:16:22 2025 -0800 Forward declare base::ScopedClosureRunner in some Blink headers Avoid including base/functional/callback_helpers.h when not needed. Also use base/functional/callback_forward.h since callback_helpers.h was providing callback.h. For scrollable_area.h, make this possible by getting rid the default arguments to PerformSnapping(), SnapAtCurrentPosition(), and SnapForEndPosition(). These methods have very few callers, so just pass in all the arguments. Then do IWYU to fix the build. Change-Id: I5cfd017bd6f392b0d97e99c41d4885fac7140a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7254408 Commit-Queue: Philip Rogers Auto-Submit: Lei Zhang Reviewed-by: Philip Rogers Reviewed-by: Christoph Schwering Reviewed-by: Robert Flack Cr-Commit-Position: refs/heads/main@{#1558318} commit 227f058d9b9e27370a64b34046d71b9f23106409 Author: Lei Zhang Date: Thu Dec 11 21:30:12 2025 -0800 Do IWYU for callback_helpers.h in async_dom_storage_database.cc Add callback_helpers.h for base::DoNothing() usage. The transitive include that makes this work as-is will be deleted in the near future. Change-Id: Id5ba6db705434734a854874923b7bb196392ca6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7253640 Commit-Queue: Mingyu Lei Auto-Submit: Lei Zhang Reviewed-by: Mingyu Lei Cr-Commit-Position: refs/heads/main@{#1557849} --- .../ai_chat/ai_chat_agent_profile_helper.cc | 1 + .../tools/content_agent_tool_base_test.cc | 1 + browser/brave_browser_main_parts.cc | 2 ++ .../creator_detection_script_injector.cc | 1 + .../util/rewards_browsertest_contribution.cc | 1 + ...e_vpn_dns_observer_service_win_unittest.cc | 1 + ...wireguard_observer_service_win_unittest.cc | 1 + .../brave_wallet_event_emitter_browsertest.cc | 1 + .../brave_wallet_service_delegate_impl.cc | 1 + .../brave_wallet_tab_helper_unittest.cc | 1 + .../cardano_provider_renderer_browsertest.cc | 1 + .../solana_provider_impl_unittest.cc | 1 + .../solana_provider_renderer_browsertest.cc | 1 + .../email_aliases_browsertest.cc | 25 ++++++++++--------- .../brave_extensions_manifest_v2_migrator.cc | 1 + .../brave_extensions_manifest_v2_unittest.cc | 1 + browser/misc_metrics/doh_metrics.cc | 1 + ...ock_tp_network_delegate_helper_unittest.cc | 1 + ...permission_lifetime_manager_browsertest.cc | 1 + .../permission_manager_browsertest.cc | 1 + ...playlist_active_tab_tracker_browsertest.cc | 1 + browser/playlist/test/playlist_browsertest.cc | 1 + .../test/playlist_service_unittest.cc | 1 + .../sync/network_time_helper_browsertest.cc | 1 + browser/tor/tor_profile_manager.cc | 1 + ...ai_rewriter_dialog_delegate_browsertest.cc | 1 + .../ui/speedreader/speedreader_tab_helper.cc | 1 + .../tree_tab_node_tab_collection_unittest.cc | 1 + ...ion_prompt_bubble_base_view_browsertest.cc | 1 + .../views/playlist/playlist_action_dialogs.cc | 1 + .../brave_profile_menu_view_browsertest.cc | 1 + .../playlist_side_panel_coordinator.cc | 1 + .../split_view/split_view_browsertest.cc | 1 + .../brave_education_page_handler_unittest.cc | 1 + .../background_facade.cc | 1 + .../new_tab_page_handler.cc | 1 + .../wallet_panel_ui_browsertest.cc | 1 + .../brave_new_tab_page_handler.cc | 1 + .../content_scraper_browsertest.cc | 1 + .../widevine_cdm_component_installer.h | 2 +- .../browser/download/download_item_model.cc | 1 + .../incognito_clear_browsing_data_dialog.cc | 1 + .../core/delivery/prediction_manager.cc | 1 + .../update_client/update_checker.cc | 1 + .../content/browser/full_screenshotter.cc | 1 + .../associated_content_delegate_unittest.cc | 1 + .../core/internal/catalog/catalog.cc | 1 + .../core/engine/contribution/contribution.cc | 1 + .../contribution/contribution_monthly.cc | 1 + .../parameters/rewards_parameters_provider.cc | 1 + .../core/engine/publisher/media/youtube.cc | 1 + .../core/engine/publisher/publisher.cc | 1 + .../publisher/server_publisher_fetcher.cc | 1 + .../core/engine/wallet/wallet_util.cc | 1 + .../engine/wallet_provider/linkage_checker.cc | 1 + .../ad_block_subscription_service_manager.cc | 1 + .../ad_block_component_service_manager.cc | 1 + .../brave_sync/sync_service_impl_helper.cc | 1 + .../browser/brave_wallet_p3a_unittest.cc | 1 + .../keyring_service_migrations_unittest.cc | 1 + .../brave_wallet/browser/solana_tx_manager.cc | 1 + .../browser/wallet_data_files_installer.cc | 1 + .../browser/zcash/zcash_auto_sync_manager.cc | 1 + ...rd_to_orchard_transaction_task_unittest.cc | 1 + ...o_transparent_transaction_task_unittest.cc | 1 + ...nt_to_orchard_transaction_task_unittest.cc | 1 + ...e_transparent_transaction_task_unittest.cc | 1 + ...zcash_get_chaintip_status_task_unittest.cc | 1 + ...esolve_transaction_status_task_unittest.cc | 1 + .../browser/zcash/zcash_wallet_service.cc | 1 + .../zcash/zcash_wallet_service_unittest.cc | 1 + components/email_aliases/email_aliases_auth.h | 2 +- .../email_aliases_service_unittest.cc | 4 ++- ...p_sponsored_rich_media_ad_event_handler.cc | 1 + .../browser/playlist_media_file_downloader.cc | 1 + .../brave_sync_service_impl_unittest.cc | 1 + .../browser/credential_manager_unittest.cc | 1 + .../browser/reporter_unittest.cc | 1 + ios/app/brave_profile_controller.mm | 1 + .../api/brave_rewards/brave_rewards_api.mm | 1 + ios/browser/api/history/brave_history_api.mm | 1 + .../ntp_background_images_service_ios.mm | 1 + .../webui/ai_chat/associated_url_content.mm | 1 + .../test/js_ethereum_provider_browsertest.cc | 1 + 84 files changed, 99 insertions(+), 15 deletions(-) diff --git a/browser/ai_chat/ai_chat_agent_profile_helper.cc b/browser/ai_chat/ai_chat_agent_profile_helper.cc index c51acabaf59..53863b6c360 100644 --- a/browser/ai_chat/ai_chat_agent_profile_helper.cc +++ b/browser/ai_chat/ai_chat_agent_profile_helper.cc @@ -15,6 +15,7 @@ #include "chrome/common/chrome_paths.h" #if !BUILDFLAG(IS_ANDROID) +#include "base/functional/callback_helpers.h" #include "chrome/browser/profiles/profile_window.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_window/public/browser_window_features.h" diff --git a/browser/ai_chat/tools/content_agent_tool_base_test.cc b/browser/ai_chat/tools/content_agent_tool_base_test.cc index 66c1ffbbb4b..6fe9b50d71a 100644 --- a/browser/ai_chat/tools/content_agent_tool_base_test.cc +++ b/browser/ai_chat/tools/content_agent_tool_base_test.cc @@ -8,6 +8,7 @@ #include #include +#include "base/functional/callback_helpers.h" #include "base/run_loop.h" #include "base/test/bind.h" #include "base/test/gmock_callback_support.h" diff --git a/browser/brave_browser_main_parts.cc b/browser/brave_browser_main_parts.cc index 8798227b949..f0811ebd4a1 100644 --- a/browser/brave_browser_main_parts.cc +++ b/browser/brave_browser_main_parts.cc @@ -44,7 +44,9 @@ #if BUILDFLAG(ENABLE_TOR) #include + #include "base/files/file_util.h" +#include "base/functional/callback_helpers.h" #include "brave/components/tor/tor_constants.h" #include "chrome/browser/browser_process_impl.h" #include "chrome/browser/profiles/profile_attributes_init_params.h" diff --git a/browser/brave_rewards/creator_detection_script_injector.cc b/browser/brave_rewards/creator_detection_script_injector.cc index 1109d27bf8c..0efe840d421 100644 --- a/browser/brave_rewards/creator_detection_script_injector.cc +++ b/browser/brave_rewards/creator_detection_script_injector.cc @@ -11,6 +11,7 @@ #include "base/containers/fixed_flat_map.h" #include "base/feature_list.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/strings/strcat.h" #include "base/strings/utf_string_conversions.h" #include "brave/browser/brave_rewards/rewards_util.h" diff --git a/browser/brave_rewards/test/util/rewards_browsertest_contribution.cc b/browser/brave_rewards/test/util/rewards_browsertest_contribution.cc index 59d95ecf48c..adf99db5804 100644 --- a/browser/brave_rewards/test/util/rewards_browsertest_contribution.cc +++ b/browser/brave_rewards/test/util/rewards_browsertest_contribution.cc @@ -9,6 +9,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/test/bind.h" #include "brave/browser/brave_rewards/test/util/rewards_browsertest_context_helper.h" #include "brave/browser/brave_rewards/test/util/rewards_browsertest_context_util.h" diff --git a/browser/brave_vpn/dns/brave_vpn_dns_observer_service_win_unittest.cc b/browser/brave_vpn/dns/brave_vpn_dns_observer_service_win_unittest.cc index 4c05e3018c0..88a667b259a 100644 --- a/browser/brave_vpn/dns/brave_vpn_dns_observer_service_win_unittest.cc +++ b/browser/brave_vpn/dns/brave_vpn_dns_observer_service_win_unittest.cc @@ -7,6 +7,7 @@ #include +#include "base/functional/callback_helpers.h" #include "base/run_loop.h" #include "base/test/bind.h" #include "base/test/scoped_feature_list.h" diff --git a/browser/brave_vpn/win/brave_vpn_wireguard_observer_service_win_unittest.cc b/browser/brave_vpn/win/brave_vpn_wireguard_observer_service_win_unittest.cc index 6f42844cced..54af7cfda77 100644 --- a/browser/brave_vpn/win/brave_vpn_wireguard_observer_service_win_unittest.cc +++ b/browser/brave_vpn/win/brave_vpn_wireguard_observer_service_win_unittest.cc @@ -7,6 +7,7 @@ #include +#include "base/functional/callback_helpers.h" #include "base/run_loop.h" #include "base/test/bind.h" #include "brave/components/brave_vpn/common/brave_vpn_utils.h" diff --git a/browser/brave_wallet/brave_wallet_event_emitter_browsertest.cc b/browser/brave_wallet/brave_wallet_event_emitter_browsertest.cc index 9199d8b5163..50f27ed22d4 100644 --- a/browser/brave_wallet/brave_wallet_event_emitter_browsertest.cc +++ b/browser/brave_wallet/brave_wallet_event_emitter_browsertest.cc @@ -6,6 +6,7 @@ #include #include +#include "base/functional/callback_helpers.h" #include "base/test/scoped_feature_list.h" #include "brave/browser/brave_wallet/brave_wallet_service_factory.h" #include "brave/components/brave_wallet/browser/brave_wallet_service.h" diff --git a/browser/brave_wallet/brave_wallet_service_delegate_impl.cc b/browser/brave_wallet/brave_wallet_service_delegate_impl.cc index 44eae207ffb..fbad5f7b441 100644 --- a/browser/brave_wallet/brave_wallet_service_delegate_impl.cc +++ b/browser/brave_wallet/brave_wallet_service_delegate_impl.cc @@ -9,6 +9,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/types/expected.h" #include "brave/components/brave_wallet/browser/brave_wallet_utils.h" #include "brave/components/brave_wallet/browser/permission_utils.h" diff --git a/browser/brave_wallet/brave_wallet_tab_helper_unittest.cc b/browser/brave_wallet/brave_wallet_tab_helper_unittest.cc index e7286844cab..0dfdd99ad84 100644 --- a/browser/brave_wallet/brave_wallet_tab_helper_unittest.cc +++ b/browser/brave_wallet/brave_wallet_tab_helper_unittest.cc @@ -7,6 +7,7 @@ #include +#include "base/functional/callback_helpers.h" #include "brave/components/constants/webui_url_constants.h" #include "chrome/browser/ui/hid/hid_chooser_controller.h" #include "chrome/grit/generated_resources.h" diff --git a/browser/brave_wallet/cardano_provider_renderer_browsertest.cc b/browser/brave_wallet/cardano_provider_renderer_browsertest.cc index 07b545d4041..40491934f61 100644 --- a/browser/brave_wallet/cardano_provider_renderer_browsertest.cc +++ b/browser/brave_wallet/cardano_provider_renderer_browsertest.cc @@ -5,6 +5,7 @@ #include +#include "base/functional/callback_helpers.h" #include "base/memory/weak_ptr.h" #include "base/path_service.h" #include "brave/browser/brave_content_browser_client.h" diff --git a/browser/brave_wallet/solana_provider_impl_unittest.cc b/browser/brave_wallet/solana_provider_impl_unittest.cc index 70e9ffc3c64..cf2de7e6d58 100644 --- a/browser/brave_wallet/solana_provider_impl_unittest.cc +++ b/browser/brave_wallet/solana_provider_impl_unittest.cc @@ -10,6 +10,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/json/json_reader.h" #include "base/memory/raw_ptr.h" #include "base/memory/scoped_refptr.h" diff --git a/browser/brave_wallet/solana_provider_renderer_browsertest.cc b/browser/brave_wallet/solana_provider_renderer_browsertest.cc index 10b2ed1c32d..bfddcbb2da3 100644 --- a/browser/brave_wallet/solana_provider_renderer_browsertest.cc +++ b/browser/brave_wallet/solana_provider_renderer_browsertest.cc @@ -9,6 +9,7 @@ #include "base/containers/flat_map.h" #include "base/containers/to_vector.h" #include "base/feature_list.h" +#include "base/functional/callback_helpers.h" #include "base/memory/weak_ptr.h" #include "base/path_service.h" #include "base/strings/strcat.h" diff --git a/browser/email_aliases/email_aliases_browsertest.cc b/browser/email_aliases/email_aliases_browsertest.cc index 14292227b73..fc4c94e653f 100644 --- a/browser/email_aliases/email_aliases_browsertest.cc +++ b/browser/email_aliases/email_aliases_browsertest.cc @@ -5,6 +5,7 @@ #include +#include "base/functional/callback_helpers.h" #include "base/json/json_reader.h" #include "base/path_service.h" #include "base/test/run_until.h" @@ -365,9 +366,9 @@ IN_PROC_BROWSER_TEST_F(EmailAliasesBrowserTest, ContextMenuAuthorized) { { auto initilized = test::AuthStateObserver::Setup(service, true); } - EmailAliasesAuth auth( - browser()->profile()->GetPrefs(), - test::GetEncryptor(g_browser_process->os_crypt_async())); + EmailAliasesAuth auth(browser()->profile()->GetPrefs(), + test::GetEncryptor(g_browser_process->os_crypt_async()), + base::DoNothing()); auth.SetAuthForTesting("success_token"); ASSERT_TRUE(base::test::RunUntil( [&]() { return !service->GetAuthTokenForTesting().empty(); })); @@ -401,9 +402,9 @@ IN_PROC_BROWSER_TEST_F(EmailAliasesBrowserTest, ContextMenuAuthorized) { } IN_PROC_BROWSER_TEST_F(EmailAliasesBrowserTest, ContextMenuAuthorizedManage) { - EmailAliasesAuth auth( - browser()->profile()->GetPrefs(), - test::GetEncryptor(g_browser_process->os_crypt_async())); + EmailAliasesAuth auth(browser()->profile()->GetPrefs(), + test::GetEncryptor(g_browser_process->os_crypt_async()), + base::DoNothing()); auth.SetAuthForTesting("success_token"); const GURL settings_page("chrome://settings/email-aliases"); @@ -435,9 +436,9 @@ IN_PROC_BROWSER_TEST_F(EmailAliasesBrowserTest, ContextMenuAuthorizedManage) { } IN_PROC_BROWSER_TEST_F(EmailAliasesBrowserTest, ContextMenuAuthorizedCancel) { - EmailAliasesAuth auth( - browser()->profile()->GetPrefs(), - test::GetEncryptor(g_browser_process->os_crypt_async())); + EmailAliasesAuth auth(browser()->profile()->GetPrefs(), + test::GetEncryptor(g_browser_process->os_crypt_async()), + base::DoNothing()); auth.SetAuthForTesting("success_token"); Navigate(GURL("https://a.test/email_aliases/inputs.html")); @@ -467,9 +468,9 @@ IN_PROC_BROWSER_TEST_F(EmailAliasesBrowserTest, ContextMenuAuthorizedCancel) { } IN_PROC_BROWSER_TEST_F(EmailAliasesBrowserTest, LogInLogOut) { // Prepare auth token - EmailAliasesAuth auth( - browser()->profile()->GetPrefs(), - test::GetEncryptor(g_browser_process->os_crypt_async())); + EmailAliasesAuth auth(browser()->profile()->GetPrefs(), + test::GetEncryptor(g_browser_process->os_crypt_async()), + base::DoNothing()); auth.SetAuthForTesting("success_token"); // Settings in logged-in state diff --git a/browser/extensions/manifest_v2/brave_extensions_manifest_v2_migrator.cc b/browser/extensions/manifest_v2/brave_extensions_manifest_v2_migrator.cc index fdcba4958cd..1e5ed3185c0 100644 --- a/browser/extensions/manifest_v2/brave_extensions_manifest_v2_migrator.cc +++ b/browser/extensions/manifest_v2/brave_extensions_manifest_v2_migrator.cc @@ -10,6 +10,7 @@ #include "base/files/file_enumerator.h" #include "base/files/file_path.h" #include "base/files/file_util.h" +#include "base/functional/callback_helpers.h" #include "base/strings/strcat.h" #include "base/strings/string_util.h" #include "brave/browser/extensions/manifest_v2/features.h" diff --git a/browser/extensions/manifest_v2/brave_extensions_manifest_v2_unittest.cc b/browser/extensions/manifest_v2/brave_extensions_manifest_v2_unittest.cc index 56e8e732329..576395808d8 100644 --- a/browser/extensions/manifest_v2/brave_extensions_manifest_v2_unittest.cc +++ b/browser/extensions/manifest_v2/brave_extensions_manifest_v2_unittest.cc @@ -6,6 +6,7 @@ #include "base/files/file_enumerator.h" #include "base/files/file_path.h" #include "base/files/file_util.h" +#include "base/functional/callback_helpers.h" #include "base/path_service.h" #include "base/test/scoped_feature_list.h" #include "brave/browser/extensions/manifest_v2/brave_extensions_manifest_v2_migrator.h" diff --git a/browser/misc_metrics/doh_metrics.cc b/browser/misc_metrics/doh_metrics.cc index 20fe6f6beb3..fc6d17f883f 100644 --- a/browser/misc_metrics/doh_metrics.cc +++ b/browser/misc_metrics/doh_metrics.cc @@ -9,6 +9,7 @@ #include #include +#include "base/functional/callback_helpers.h" #include "base/metrics/histogram_macros.h" #include "brave/components/misc_metrics/pref_names.h" #include "brave/components/p3a_utils/bucket.h" diff --git a/browser/net/brave_ad_block_tp_network_delegate_helper_unittest.cc b/browser/net/brave_ad_block_tp_network_delegate_helper_unittest.cc index 7dacf90d330..28549fbd90d 100644 --- a/browser/net/brave_ad_block_tp_network_delegate_helper_unittest.cc +++ b/browser/net/brave_ad_block_tp_network_delegate_helper_unittest.cc @@ -10,6 +10,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/memory/raw_ptr.h" #include "base/memory/scoped_refptr.h" #include "base/path_service.h" diff --git a/browser/permissions/permission_lifetime_manager_browsertest.cc b/browser/permissions/permission_lifetime_manager_browsertest.cc index 3eeb0540308..a1156491e8c 100644 --- a/browser/permissions/permission_lifetime_manager_browsertest.cc +++ b/browser/permissions/permission_lifetime_manager_browsertest.cc @@ -9,6 +9,7 @@ #include #include "base/command_line.h" +#include "base/functional/callback_helpers.h" #include "base/json/json_file_value_serializer.h" #include "base/notreached.h" #include "base/path_service.h" diff --git a/browser/permissions/permission_manager_browsertest.cc b/browser/permissions/permission_manager_browsertest.cc index dda78b3f75b..e49084d0d80 100644 --- a/browser/permissions/permission_manager_browsertest.cc +++ b/browser/permissions/permission_manager_browsertest.cc @@ -10,6 +10,7 @@ #include +#include "base/functional/callback_helpers.h" #include "base/memory/raw_ptr.h" #include "base/test/mock_callback.h" #include "base/test/scoped_feature_list.h" diff --git a/browser/playlist/test/playlist_active_tab_tracker_browsertest.cc b/browser/playlist/test/playlist_active_tab_tracker_browsertest.cc index 08260fadaee..b7ecdb049db 100644 --- a/browser/playlist/test/playlist_active_tab_tracker_browsertest.cc +++ b/browser/playlist/test/playlist_active_tab_tracker_browsertest.cc @@ -5,6 +5,7 @@ #include "brave/browser/ui/webui/playlist_active_tab_tracker.h" +#include "base/functional/callback_helpers.h" #include "base/run_loop.h" #include "base/test/mock_callback.h" #include "brave/components/playlist/content/browser/playlist_tab_helper.h" diff --git a/browser/playlist/test/playlist_browsertest.cc b/browser/playlist/test/playlist_browsertest.cc index d11913ba815..11262e366a5 100644 --- a/browser/playlist/test/playlist_browsertest.cc +++ b/browser/playlist/test/playlist_browsertest.cc @@ -7,6 +7,7 @@ #include #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/path_service.h" #include "base/run_loop.h" #include "base/test/bind.h" diff --git a/browser/playlist/test/playlist_service_unittest.cc b/browser/playlist/test/playlist_service_unittest.cc index da1b16a4c16..ca4cca08e36 100644 --- a/browser/playlist/test/playlist_service_unittest.cc +++ b/browser/playlist/test/playlist_service_unittest.cc @@ -10,6 +10,7 @@ #include "base/check.h" #include "base/files/file_util.h" #include "base/files/scoped_temp_dir.h" +#include "base/functional/callback_helpers.h" #include "base/gtest_prod_util.h" #include "base/run_loop.h" #include "base/strings/string_number_conversions.h" diff --git a/browser/sync/network_time_helper_browsertest.cc b/browser/sync/network_time_helper_browsertest.cc index ef6f927dff0..d1fa1135a2f 100644 --- a/browser/sync/network_time_helper_browsertest.cc +++ b/browser/sync/network_time_helper_browsertest.cc @@ -5,6 +5,7 @@ #include "brave/components/brave_sync/network_time_helper.h" +#include "base/functional/callback_helpers.h" #include "base/test/gtest_util.h" #include "brave/components/brave_sync/brave_sync_prefs.h" #include "build/build_config.h" diff --git a/browser/tor/tor_profile_manager.cc b/browser/tor/tor_profile_manager.cc index 84034023de9..a450e604a2c 100644 --- a/browser/tor/tor_profile_manager.cc +++ b/browser/tor/tor_profile_manager.cc @@ -10,6 +10,7 @@ #include "base/check.h" #include "base/feature_list.h" +#include "base/functional/callback_helpers.h" #include "brave/browser/tor/tor_profile_service_factory.h" #include "brave/components/constants/pref_names.h" #include "brave/components/tor/tor_constants.h" diff --git a/browser/ui/ai_rewriter/ai_rewriter_dialog_delegate_browsertest.cc b/browser/ui/ai_rewriter/ai_rewriter_dialog_delegate_browsertest.cc index e4d39034514..5c854976ed5 100644 --- a/browser/ui/ai_rewriter/ai_rewriter_dialog_delegate_browsertest.cc +++ b/browser/ui/ai_rewriter/ai_rewriter_dialog_delegate_browsertest.cc @@ -5,6 +5,7 @@ #include "brave/browser/ui/ai_rewriter/ai_rewriter_dialog_delegate.h" +#include "base/functional/callback_helpers.h" #include "base/path_service.h" #include "base/run_loop.h" #include "base/test/scoped_feature_list.h" diff --git a/browser/ui/speedreader/speedreader_tab_helper.cc b/browser/ui/speedreader/speedreader_tab_helper.cc index 8ae72e1e3e5..bea78070b86 100644 --- a/browser/ui/speedreader/speedreader_tab_helper.cc +++ b/browser/ui/speedreader/speedreader_tab_helper.cc @@ -14,6 +14,7 @@ #include "base/check_is_test.h" #include "base/feature_list.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/json/json_writer.h" #include "base/no_destructor.h" #include "base/strings/strcat.h" diff --git a/browser/ui/tabs/test/tree_tab_node_tab_collection_unittest.cc b/browser/ui/tabs/test/tree_tab_node_tab_collection_unittest.cc index 4d8f14e1e10..ef09d683790 100644 --- a/browser/ui/tabs/test/tree_tab_node_tab_collection_unittest.cc +++ b/browser/ui/tabs/test/tree_tab_node_tab_collection_unittest.cc @@ -5,6 +5,7 @@ #include "brave/components/tabs/public/tree_tab_node_tab_collection.h" +#include "base/functional/callback_helpers.h" #include "base/test/task_environment.h" #include "brave/components/tabs/public/tree_tab_node.h" #include "chrome/browser/ui/tabs/tab_group_desktop.h" diff --git a/browser/ui/views/permissions/permission_prompt_bubble_base_view_browsertest.cc b/browser/ui/views/permissions/permission_prompt_bubble_base_view_browsertest.cc index 7a803628bc1..5311f837ca6 100644 --- a/browser/ui/views/permissions/permission_prompt_bubble_base_view_browsertest.cc +++ b/browser/ui/views/permissions/permission_prompt_bubble_base_view_browsertest.cc @@ -5,6 +5,7 @@ #include "chrome/browser/ui/views/permissions/permission_prompt_bubble_base_view.h" +#include "base/functional/callback_helpers.h" #include "base/test/run_until.h" #include "build/build_config.h" #include "chrome/browser/ui/views/chrome_widget_sublevel.h" diff --git a/browser/ui/views/playlist/playlist_action_dialogs.cc b/browser/ui/views/playlist/playlist_action_dialogs.cc index 93a02a5b01d..921b7c8dff6 100644 --- a/browser/ui/views/playlist/playlist_action_dialogs.cc +++ b/browser/ui/views/playlist/playlist_action_dialogs.cc @@ -12,6 +12,7 @@ #include "base/check.h" #include "base/check_op.h" +#include "base/functional/callback_helpers.h" #include "base/logging.h" #include "base/notreached.h" #include "base/strings/utf_string_conversions.h" diff --git a/browser/ui/views/profiles/brave_profile_menu_view_browsertest.cc b/browser/ui/views/profiles/brave_profile_menu_view_browsertest.cc index fc8b96ae2ef..a7903feee22 100644 --- a/browser/ui/views/profiles/brave_profile_menu_view_browsertest.cc +++ b/browser/ui/views/profiles/brave_profile_menu_view_browsertest.cc @@ -4,6 +4,7 @@ * You can obtain one at https://mozilla.org/MPL/2.0/. */ #include "base/files/file_path.h" +#include "base/functional/callback_helpers.h" #include "base/logging.h" #include "build/build_config.h" #include "chrome/browser/browser_process.h" diff --git a/browser/ui/views/side_panel/playlist/playlist_side_panel_coordinator.cc b/browser/ui/views/side_panel/playlist/playlist_side_panel_coordinator.cc index c49242b848a..8411134bf33 100644 --- a/browser/ui/views/side_panel/playlist/playlist_side_panel_coordinator.cc +++ b/browser/ui/views/side_panel/playlist/playlist_side_panel_coordinator.cc @@ -10,6 +10,7 @@ #include "base/check.h" #include "base/check_is_test.h" #include "base/functional/callback.h" +#include "base/functional/callback_helpers.h" #include "brave/browser/ui/sidebar/sidebar_controller.h" #include "brave/browser/ui/sidebar/sidebar_model.h" #include "brave/components/constants/webui_url_constants.h" diff --git a/browser/ui/views/split_view/split_view_browsertest.cc b/browser/ui/views/split_view/split_view_browsertest.cc index 5d12cd4585d..315bd40aa9d 100644 --- a/browser/ui/views/split_view/split_view_browsertest.cc +++ b/browser/ui/views/split_view/split_view_browsertest.cc @@ -5,6 +5,7 @@ #include +#include "base/functional/callback_helpers.h" #include "base/test/run_until.h" #include "brave/browser/ui/bookmark/bookmark_helper.h" #include "brave/browser/ui/browser_commands.h" diff --git a/browser/ui/webui/brave_education/brave_education_page_handler_unittest.cc b/browser/ui/webui/brave_education/brave_education_page_handler_unittest.cc index 2950bc9b551..8c8a670c1c5 100644 --- a/browser/ui/webui/brave_education/brave_education_page_handler_unittest.cc +++ b/browser/ui/webui/brave_education/brave_education_page_handler_unittest.cc @@ -7,6 +7,7 @@ #include #include +#include "base/functional/callback_helpers.h" #include "base/test/bind.h" #include "base/test/test_future.h" #include "brave/browser/ui/webui/brave_browser_command/brave_browser_command_handler.h" diff --git a/browser/ui/webui/brave_new_tab_page_refresh/background_facade.cc b/browser/ui/webui/brave_new_tab_page_refresh/background_facade.cc index f5ea2fcdd1a..daea15c78b6 100644 --- a/browser/ui/webui/brave_new_tab_page_refresh/background_facade.cc +++ b/browser/ui/webui/brave_new_tab_page_refresh/background_facade.cc @@ -11,6 +11,7 @@ #include "base/barrier_callback.h" #include "base/check.h" #include "base/containers/contains.h" +#include "base/functional/callback_helpers.h" #include "brave/browser/ntp_background/custom_background_file_manager.h" #include "brave/browser/ntp_background/ntp_background_prefs.h" #include "brave/components/ntp_background_images/browser/ntp_background_images_data.h" diff --git a/browser/ui/webui/brave_new_tab_page_refresh/new_tab_page_handler.cc b/browser/ui/webui/brave_new_tab_page_refresh/new_tab_page_handler.cc index ac99e707219..619a24466af 100644 --- a/browser/ui/webui/brave_new_tab_page_refresh/new_tab_page_handler.cc +++ b/browser/ui/webui/brave_new_tab_page_refresh/new_tab_page_handler.cc @@ -8,6 +8,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/strings/utf_string_conversions.h" #include "base/types/to_address.h" #include "brave/browser/ntp_background/new_tab_takeover_infobar_delegate.h" diff --git a/browser/ui/webui/brave_wallet/wallet_panel_ui_browsertest.cc b/browser/ui/webui/brave_wallet/wallet_panel_ui_browsertest.cc index bba7dbc81bc..ce155612eb4 100644 --- a/browser/ui/webui/brave_wallet/wallet_panel_ui_browsertest.cc +++ b/browser/ui/webui/brave_wallet/wallet_panel_ui_browsertest.cc @@ -8,6 +8,7 @@ #include #include +#include "base/functional/callback_helpers.h" #include "base/memory/raw_ptr.h" #include "base/memory/scoped_refptr.h" #include "base/run_loop.h" diff --git a/browser/ui/webui/new_tab_page/brave_new_tab_page_handler.cc b/browser/ui/webui/new_tab_page/brave_new_tab_page_handler.cc index 5bed850c46e..434fb9d2e9a 100644 --- a/browser/ui/webui/new_tab_page/brave_new_tab_page_handler.cc +++ b/browser/ui/webui/new_tab_page/brave_new_tab_page_handler.cc @@ -12,6 +12,7 @@ #include "base/check.h" #include "base/files/file_path.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/logging.h" #include "base/strings/utf_string_conversions.h" #include "base/values.h" diff --git a/browser/web_discovery/content_scraper_browsertest.cc b/browser/web_discovery/content_scraper_browsertest.cc index 8751ac2d1f7..93f19180805 100644 --- a/browser/web_discovery/content_scraper_browsertest.cc +++ b/browser/web_discovery/content_scraper_browsertest.cc @@ -10,6 +10,7 @@ #include "base/files/file_path.h" #include "base/files/file_util.h" +#include "base/functional/callback_helpers.h" #include "base/path_service.h" #include "base/test/bind.h" #include "base/test/scoped_feature_list.h" diff --git a/chromium_src/chrome/browser/component_updater/widevine_cdm_component_installer.h b/chromium_src/chrome/browser/component_updater/widevine_cdm_component_installer.h index 6c4bf251934..583e48ad0ec 100644 --- a/chromium_src/chrome/browser/component_updater/widevine_cdm_component_installer.h +++ b/chromium_src/chrome/browser/component_updater/widevine_cdm_component_installer.h @@ -10,7 +10,7 @@ #define RegisterWidevineCdmComponent(cus) \ RegisterWidevineCdmComponent( \ - cus, base::OnceCallback callback = base::DoNothing()) + cus, base::OnceCallback callback = base::OnceClosure()) #include // IWYU pragma: export diff --git a/chromium_src/chrome/browser/download/download_item_model.cc b/chromium_src/chrome/browser/download/download_item_model.cc index f49f7df336e..72c82f049b6 100644 --- a/chromium_src/chrome/browser/download/download_item_model.cc +++ b/chromium_src/chrome/browser/download/download_item_model.cc @@ -5,6 +5,7 @@ #include "chrome/browser/download/download_item_model.h" +#include "base/functional/callback_helpers.h" #include "chrome/browser/download/download_commands.h" #include "ui/base/clipboard/scoped_clipboard_writer.h" diff --git a/chromium_src/chrome/browser/ui/views/incognito_clear_browsing_data_dialog.cc b/chromium_src/chrome/browser/ui/views/incognito_clear_browsing_data_dialog.cc index aef8b188776..7f59d3f644d 100644 --- a/chromium_src/chrome/browser/ui/views/incognito_clear_browsing_data_dialog.cc +++ b/chromium_src/chrome/browser/ui/views/incognito_clear_browsing_data_dialog.cc @@ -3,6 +3,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this file, * You can obtain one at http://mozilla.org/MPL/2.0/. */ +#include "base/functional/callback_helpers.h" #include "ui/views/bubble/bubble_dialog_delegate_view.h" #define SetShowCloseButton(...) SetShowCloseButton(false) diff --git a/chromium_src/components/optimization_guide/core/delivery/prediction_manager.cc b/chromium_src/components/optimization_guide/core/delivery/prediction_manager.cc index 00b3c329dc2..5ee2e38d6d6 100644 --- a/chromium_src/components/optimization_guide/core/delivery/prediction_manager.cc +++ b/chromium_src/components/optimization_guide/core/delivery/prediction_manager.cc @@ -12,6 +12,7 @@ #include "base/containers/flat_map.h" #include "base/containers/flat_set.h" +#include "base/functional/callback_helpers.h" #include "base/path_service.h" #include "components/optimization_guide/core/delivery/optimization_target_model_observer.h" #include "components/optimization_guide/core/delivery/prediction_model_download_manager.h" diff --git a/chromium_src/components/update_client/update_checker.cc b/chromium_src/components/update_client/update_checker.cc index dba7a670b91..c5fddd00527 100644 --- a/chromium_src/components/update_client/update_checker.cc +++ b/chromium_src/components/update_client/update_checker.cc @@ -9,6 +9,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/logging.h" #include "base/task/single_thread_task_runner.h" #include "components/update_client/update_client.h" diff --git a/components/ai_chat/content/browser/full_screenshotter.cc b/components/ai_chat/content/browser/full_screenshotter.cc index 8299a7224ae..9f4f1d2d2fd 100644 --- a/components/ai_chat/content/browser/full_screenshotter.cc +++ b/components/ai_chat/content/browser/full_screenshotter.cc @@ -9,6 +9,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/logging.h" #include "base/task/sequenced_task_runner.h" #include "base/task/task_traits.h" diff --git a/components/ai_chat/core/browser/associated_content_delegate_unittest.cc b/components/ai_chat/core/browser/associated_content_delegate_unittest.cc index a92e015a3e8..a942a6b3f4a 100644 --- a/components/ai_chat/core/browser/associated_content_delegate_unittest.cc +++ b/components/ai_chat/core/browser/associated_content_delegate_unittest.cc @@ -7,6 +7,7 @@ #include +#include "base/functional/callback_helpers.h" #include "base/scoped_observation.h" #include "brave/components/ai_chat/core/browser/test/mock_associated_content.h" #include "testing/gmock/include/gmock/gmock.h" diff --git a/components/brave_ads/core/internal/catalog/catalog.cc b/components/brave_ads/core/internal/catalog/catalog.cc index c3b248a0fb7..267db64ec66 100644 --- a/components/brave_ads/core/internal/catalog/catalog.cc +++ b/components/brave_ads/core/internal/catalog/catalog.cc @@ -7,6 +7,7 @@ #include "base/check.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/time/time.h" #include "brave/components/brave_ads/core/internal/ads_client/ads_client_util.h" #include "brave/components/brave_ads/core/internal/catalog/catalog_info.h" diff --git a/components/brave_rewards/core/engine/contribution/contribution.cc b/components/brave_rewards/core/engine/contribution/contribution.cc index 99fa18642fc..75cf932b12f 100644 --- a/components/brave_rewards/core/engine/contribution/contribution.cc +++ b/components/brave_rewards/core/engine/contribution/contribution.cc @@ -18,6 +18,7 @@ #include "base/check.h" #include "base/functional/bind.h" #include "base/functional/callback.h" +#include "base/functional/callback_helpers.h" #include "base/strings/string_number_conversions.h" #include "base/time/time.h" #include "base/uuid.h" diff --git a/components/brave_rewards/core/engine/contribution/contribution_monthly.cc b/components/brave_rewards/core/engine/contribution/contribution_monthly.cc index 073e47f82ec..821d5c8b827 100644 --- a/components/brave_rewards/core/engine/contribution/contribution_monthly.cc +++ b/components/brave_rewards/core/engine/contribution/contribution_monthly.cc @@ -12,6 +12,7 @@ #include "base/check.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/uuid.h" #include "brave/components/brave_rewards/core/engine/contribution/contribution.h" #include "brave/components/brave_rewards/core/engine/database/database.h" diff --git a/components/brave_rewards/core/engine/parameters/rewards_parameters_provider.cc b/components/brave_rewards/core/engine/parameters/rewards_parameters_provider.cc index 40acd65d330..af37307c014 100644 --- a/components/brave_rewards/core/engine/parameters/rewards_parameters_provider.cc +++ b/components/brave_rewards/core/engine/parameters/rewards_parameters_provider.cc @@ -8,6 +8,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/json/values_util.h" #include "brave/components/brave_rewards/core/engine/endpoints/request_for.h" #include "brave/components/brave_rewards/core/engine/util/callback_helpers.h" diff --git a/components/brave_rewards/core/engine/publisher/media/youtube.cc b/components/brave_rewards/core/engine/publisher/media/youtube.cc index 9c05d990935..e397da0ff66 100644 --- a/components/brave_rewards/core/engine/publisher/media/youtube.cc +++ b/components/brave_rewards/core/engine/publisher/media/youtube.cc @@ -11,6 +11,7 @@ #include "base/check.h" #include "base/containers/map_util.h" +#include "base/functional/callback_helpers.h" #include "base/json/json_reader.h" #include "base/strings/escape.h" #include "base/strings/string_number_conversions.h" diff --git a/components/brave_rewards/core/engine/publisher/publisher.cc b/components/brave_rewards/core/engine/publisher/publisher.cc index 5b163bbc262..3a8428ce936 100644 --- a/components/brave_rewards/core/engine/publisher/publisher.cc +++ b/components/brave_rewards/core/engine/publisher/publisher.cc @@ -15,6 +15,7 @@ #include "base/check.h" #include "base/containers/map_util.h" #include "base/feature_list.h" +#include "base/functional/callback_helpers.h" #include "base/uuid.h" #include "brave/components/brave_rewards/core/engine/constants.h" #include "brave/components/brave_rewards/core/engine/contribution/contribution.h" diff --git a/components/brave_rewards/core/engine/publisher/server_publisher_fetcher.cc b/components/brave_rewards/core/engine/publisher/server_publisher_fetcher.cc index 61b4c698111..f6509dcaf9f 100644 --- a/components/brave_rewards/core/engine/publisher/server_publisher_fetcher.cc +++ b/components/brave_rewards/core/engine/publisher/server_publisher_fetcher.cc @@ -10,6 +10,7 @@ #include "base/big_endian.h" #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/json/json_reader.h" #include "base/time/time.h" #include "brave/components/brave_rewards/core/engine/database/database.h" diff --git a/components/brave_rewards/core/engine/wallet/wallet_util.cc b/components/brave_rewards/core/engine/wallet/wallet_util.cc index 75d82feac14..ab44dccd1e6 100644 --- a/components/brave_rewards/core/engine/wallet/wallet_util.cc +++ b/components/brave_rewards/core/engine/wallet/wallet_util.cc @@ -12,6 +12,7 @@ #include "base/base64.h" #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/json/json_reader.h" #include "base/json/json_writer.h" #include "base/notreached.h" diff --git a/components/brave_rewards/core/engine/wallet_provider/linkage_checker.cc b/components/brave_rewards/core/engine/wallet_provider/linkage_checker.cc index a420346f998..a62bced19cf 100644 --- a/components/brave_rewards/core/engine/wallet_provider/linkage_checker.cc +++ b/components/brave_rewards/core/engine/wallet_provider/linkage_checker.cc @@ -9,6 +9,7 @@ #include "base/check.h" #include "base/feature_list.h" +#include "base/functional/callback_helpers.h" #include "brave/components/brave_rewards/core/engine/endpoints/request_for.h" #include "brave/components/brave_rewards/core/engine/notifications/notification_keys.h" #include "brave/components/brave_rewards/core/engine/util/rewards_prefs.h" diff --git a/components/brave_shields/content/browser/ad_block_subscription_service_manager.cc b/components/brave_shields/content/browser/ad_block_subscription_service_manager.cc index 696c0141ee7..4e772998492 100644 --- a/components/brave_shields/content/browser/ad_block_subscription_service_manager.cc +++ b/components/brave_shields/content/browser/ad_block_subscription_service_manager.cc @@ -16,6 +16,7 @@ #include "base/containers/map_util.h" #include "base/files/file_util.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/json/json_value_converter.h" #include "base/json/values_util.h" #include "base/task/thread_pool.h" diff --git a/components/brave_shields/core/browser/ad_block_component_service_manager.cc b/components/brave_shields/core/browser/ad_block_component_service_manager.cc index d76b4ec6364..78e0438162f 100644 --- a/components/brave_shields/core/browser/ad_block_component_service_manager.cc +++ b/components/brave_shields/core/browser/ad_block_component_service_manager.cc @@ -13,6 +13,7 @@ #include "base/check.h" #include "base/feature_list.h" #include "base/files/file_path.h" +#include "base/functional/callback_helpers.h" #include "base/memory/raw_ptr_exclusion.h" #include "base/memory/raw_ref.h" #include "base/metrics/histogram_macros.h" diff --git a/components/brave_sync/sync_service_impl_helper.cc b/components/brave_sync/sync_service_impl_helper.cc index ca0c1ee5334..dedf8ee07e8 100644 --- a/components/brave_sync/sync_service_impl_helper.cc +++ b/components/brave_sync/sync_service_impl_helper.cc @@ -9,6 +9,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "brave/components/sync/service/brave_sync_service_impl.h" #include "components/sync_device_info/device_info_sync_service.h" #include "components/sync_device_info/device_info_tracker.h" diff --git a/components/brave_wallet/browser/brave_wallet_p3a_unittest.cc b/components/brave_wallet/browser/brave_wallet_p3a_unittest.cc index b7a681c3305..b9386462e72 100644 --- a/components/brave_wallet/browser/brave_wallet_p3a_unittest.cc +++ b/components/brave_wallet/browser/brave_wallet_p3a_unittest.cc @@ -11,6 +11,7 @@ #include #include "base/command_line.h" +#include "base/functional/callback_helpers.h" #include "base/strings/string_number_conversions.h" #include "base/strings/string_util.h" #include "base/test/bind.h" diff --git a/components/brave_wallet/browser/keyring_service_migrations_unittest.cc b/components/brave_wallet/browser/keyring_service_migrations_unittest.cc index 8b5eec3bca5..ef9ab946276 100644 --- a/components/brave_wallet/browser/keyring_service_migrations_unittest.cc +++ b/components/brave_wallet/browser/keyring_service_migrations_unittest.cc @@ -3,6 +3,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this file, * You can obtain one at https://mozilla.org/MPL/2.0/. */ +#include "base/functional/callback_helpers.h" #include "base/test/bind.h" #include "base/test/mock_callback.h" #include "base/test/scoped_feature_list.h" diff --git a/components/brave_wallet/browser/solana_tx_manager.cc b/components/brave_wallet/browser/solana_tx_manager.cc index c4263578213..fb952b3be67 100644 --- a/components/brave_wallet/browser/solana_tx_manager.cc +++ b/components/brave_wallet/browser/solana_tx_manager.cc @@ -15,6 +15,7 @@ #include "base/barrier_callback.h" #include "base/base64.h" #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/logging.h" #include "base/notimplemented.h" #include "brave/components/brave_wallet/browser/account_resolver_delegate.h" diff --git a/components/brave_wallet/browser/wallet_data_files_installer.cc b/components/brave_wallet/browser/wallet_data_files_installer.cc index 90094d6530c..e829b9267f9 100644 --- a/components/brave_wallet/browser/wallet_data_files_installer.cc +++ b/components/brave_wallet/browser/wallet_data_files_installer.cc @@ -15,6 +15,7 @@ #include "base/compiler_specific.h" #include "base/containers/to_vector.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/values.h" #include "brave/components/brave_component_updater/browser/brave_on_demand_updater.h" #include "brave/components/brave_wallet/browser/blockchain_registry.h" diff --git a/components/brave_wallet/browser/zcash/zcash_auto_sync_manager.cc b/components/brave_wallet/browser/zcash/zcash_auto_sync_manager.cc index 8cf44df5e68..06e8cdab4c8 100644 --- a/components/brave_wallet/browser/zcash/zcash_auto_sync_manager.cc +++ b/components/brave_wallet/browser/zcash/zcash_auto_sync_manager.cc @@ -8,6 +8,7 @@ #include #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "brave/components/brave_wallet/browser/zcash/zcash_wallet_service.h" namespace brave_wallet { diff --git a/components/brave_wallet/browser/zcash/zcash_create_orchard_to_orchard_transaction_task_unittest.cc b/components/brave_wallet/browser/zcash/zcash_create_orchard_to_orchard_transaction_task_unittest.cc index 09cf62380b6..4148909e393 100644 --- a/components/brave_wallet/browser/zcash/zcash_create_orchard_to_orchard_transaction_task_unittest.cc +++ b/components/brave_wallet/browser/zcash/zcash_create_orchard_to_orchard_transaction_task_unittest.cc @@ -9,6 +9,7 @@ #include #include "base/files/scoped_temp_dir.h" +#include "base/functional/callback_helpers.h" #include "base/task/sequenced_task_runner.h" #include "base/task/thread_pool.h" #include "base/test/bind.h" diff --git a/components/brave_wallet/browser/zcash/zcash_create_orchard_to_transparent_transaction_task_unittest.cc b/components/brave_wallet/browser/zcash/zcash_create_orchard_to_transparent_transaction_task_unittest.cc index 37aedc0580e..41b45c34cb3 100644 --- a/components/brave_wallet/browser/zcash/zcash_create_orchard_to_transparent_transaction_task_unittest.cc +++ b/components/brave_wallet/browser/zcash/zcash_create_orchard_to_transparent_transaction_task_unittest.cc @@ -9,6 +9,7 @@ #include #include "base/files/scoped_temp_dir.h" +#include "base/functional/callback_helpers.h" #include "base/task/sequenced_task_runner.h" #include "base/task/thread_pool.h" #include "base/test/bind.h" diff --git a/components/brave_wallet/browser/zcash/zcash_create_transparent_to_orchard_transaction_task_unittest.cc b/components/brave_wallet/browser/zcash/zcash_create_transparent_to_orchard_transaction_task_unittest.cc index 7913ae720c6..646abdacbac 100644 --- a/components/brave_wallet/browser/zcash/zcash_create_transparent_to_orchard_transaction_task_unittest.cc +++ b/components/brave_wallet/browser/zcash/zcash_create_transparent_to_orchard_transaction_task_unittest.cc @@ -9,6 +9,7 @@ #include #include "base/files/scoped_temp_dir.h" +#include "base/functional/callback_helpers.h" #include "base/task/sequenced_task_runner.h" #include "base/task/thread_pool.h" #include "base/test/bind.h" diff --git a/components/brave_wallet/browser/zcash/zcash_create_transparent_transaction_task_unittest.cc b/components/brave_wallet/browser/zcash/zcash_create_transparent_transaction_task_unittest.cc index 34752802e45..e510af63e93 100644 --- a/components/brave_wallet/browser/zcash/zcash_create_transparent_transaction_task_unittest.cc +++ b/components/brave_wallet/browser/zcash/zcash_create_transparent_transaction_task_unittest.cc @@ -10,6 +10,7 @@ #include #include "base/files/scoped_temp_dir.h" +#include "base/functional/callback_helpers.h" #include "base/task/thread_pool.h" #include "base/test/bind.h" #include "base/test/gmock_callback_support.h" diff --git a/components/brave_wallet/browser/zcash/zcash_get_chaintip_status_task_unittest.cc b/components/brave_wallet/browser/zcash/zcash_get_chaintip_status_task_unittest.cc index 283d3c6cac4..c2d391533e5 100644 --- a/components/brave_wallet/browser/zcash/zcash_get_chaintip_status_task_unittest.cc +++ b/components/brave_wallet/browser/zcash/zcash_get_chaintip_status_task_unittest.cc @@ -8,6 +8,7 @@ #include #include "base/files/scoped_temp_dir.h" +#include "base/functional/callback_helpers.h" #include "base/task/thread_pool.h" #include "base/test/mock_callback.h" #include "base/test/scoped_feature_list.h" diff --git a/components/brave_wallet/browser/zcash/zcash_resolve_transaction_status_task_unittest.cc b/components/brave_wallet/browser/zcash/zcash_resolve_transaction_status_task_unittest.cc index d390d042119..d673818cfd6 100644 --- a/components/brave_wallet/browser/zcash/zcash_resolve_transaction_status_task_unittest.cc +++ b/components/brave_wallet/browser/zcash/zcash_resolve_transaction_status_task_unittest.cc @@ -10,6 +10,7 @@ #include #include "base/files/scoped_temp_dir.h" +#include "base/functional/callback_helpers.h" #include "base/test/mock_callback.h" #include "base/test/task_environment.h" #include "brave/components/brave_wallet/browser/keyring_service.h" diff --git a/components/brave_wallet/browser/zcash/zcash_wallet_service.cc b/components/brave_wallet/browser/zcash/zcash_wallet_service.cc index 08ae123a505..574718ba60b 100644 --- a/components/brave_wallet/browser/zcash/zcash_wallet_service.cc +++ b/components/brave_wallet/browser/zcash/zcash_wallet_service.cc @@ -13,6 +13,7 @@ #include "base/check.h" #include "base/check_is_test.h" #include "base/containers/span.h" +#include "base/functional/callback_helpers.h" #include "base/task/thread_pool.h" #include "brave/components/brave_wallet/browser/brave_wallet_utils.h" #include "brave/components/brave_wallet/browser/zcash/zcash_create_transparent_transaction_task.h" diff --git a/components/brave_wallet/browser/zcash/zcash_wallet_service_unittest.cc b/components/brave_wallet/browser/zcash/zcash_wallet_service_unittest.cc index f4b9176ff99..d196a6f773d 100644 --- a/components/brave_wallet/browser/zcash/zcash_wallet_service_unittest.cc +++ b/components/brave_wallet/browser/zcash/zcash_wallet_service_unittest.cc @@ -11,6 +11,7 @@ #include #include +#include "base/functional/callback_helpers.h" #include "base/memory/scoped_refptr.h" #include "base/strings/string_number_conversions.h" #include "base/test/bind.h" diff --git a/components/email_aliases/email_aliases_auth.h b/components/email_aliases/email_aliases_auth.h index 92072a41741..918ef1384f4 100644 --- a/components/email_aliases/email_aliases_auth.h +++ b/components/email_aliases/email_aliases_auth.h @@ -21,7 +21,7 @@ class EmailAliasesAuth { explicit EmailAliasesAuth(PrefService* prefs_service, os_crypt_async::Encryptor encryptor, - OnChangedCallback on_changed = base::DoNothing()); + OnChangedCallback on_changed); ~EmailAliasesAuth(); static void RegisterProfilePrefs(PrefRegistrySimple* registry); diff --git a/components/email_aliases/email_aliases_service_unittest.cc b/components/email_aliases/email_aliases_service_unittest.cc index 5510d48d052..6a854a3d153 100644 --- a/components/email_aliases/email_aliases_service_unittest.cc +++ b/components/email_aliases/email_aliases_service_unittest.cc @@ -12,6 +12,7 @@ #include "base/containers/contains.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/test/bind.h" #include "base/test/run_until.h" #include "base/test/scoped_feature_list.h" @@ -170,7 +171,8 @@ class EmailAliasesAPITest : public ::testing::Test { } void SetupAuth(bool auth = true) { - EmailAliasesAuth settings(&prefs_, test::GetEncryptor(os_crypt_.get())); + EmailAliasesAuth settings(&prefs_, test::GetEncryptor(os_crypt_.get()), + base::DoNothing()); if (auth) { settings.SetAuthForTesting("token456"); } else { diff --git a/components/ntp_background_images/browser/ntp_sponsored_rich_media_ad_event_handler.cc b/components/ntp_background_images/browser/ntp_sponsored_rich_media_ad_event_handler.cc index 61d77550c31..ac3d91807b1 100644 --- a/components/ntp_background_images/browser/ntp_sponsored_rich_media_ad_event_handler.cc +++ b/components/ntp_background_images/browser/ntp_sponsored_rich_media_ad_event_handler.cc @@ -7,6 +7,7 @@ #include +#include "base/functional/callback_helpers.h" #include "base/notreached.h" #include "base/types/cxx23_to_underlying.h" #include "brave/components/brave_ads/core/browser/service/ads_service.h" diff --git a/components/playlist/content/browser/playlist_media_file_downloader.cc b/components/playlist/content/browser/playlist_media_file_downloader.cc index a60f0b98864..e107fd5b403 100644 --- a/components/playlist/content/browser/playlist_media_file_downloader.cc +++ b/components/playlist/content/browser/playlist_media_file_downloader.cc @@ -13,6 +13,7 @@ #include "base/check_op.h" #include "base/files/file_util.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/logging.h" #include "base/notreached.h" #include "base/task/thread_pool.h" diff --git a/components/sync/service/brave_sync_service_impl_unittest.cc b/components/sync/service/brave_sync_service_impl_unittest.cc index 3a973716da6..6844af4d4f3 100644 --- a/components/sync/service/brave_sync_service_impl_unittest.cc +++ b/components/sync/service/brave_sync_service_impl_unittest.cc @@ -9,6 +9,7 @@ #include "base/base64.h" #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/memory/raw_ptr.h" #include "base/notreached.h" #include "base/run_loop.h" diff --git a/components/web_discovery/browser/credential_manager_unittest.cc b/components/web_discovery/browser/credential_manager_unittest.cc index 9a993f83bb0..b8ee9582ac2 100644 --- a/components/web_discovery/browser/credential_manager_unittest.cc +++ b/components/web_discovery/browser/credential_manager_unittest.cc @@ -11,6 +11,7 @@ #include "base/base64.h" #include "base/files/file_util.h" +#include "base/functional/callback_helpers.h" #include "base/json/json_writer.h" #include "base/path_service.h" #include "base/test/bind.h" diff --git a/components/web_discovery/browser/reporter_unittest.cc b/components/web_discovery/browser/reporter_unittest.cc index 80ca8611628..57a30f698a7 100644 --- a/components/web_discovery/browser/reporter_unittest.cc +++ b/components/web_discovery/browser/reporter_unittest.cc @@ -9,6 +9,7 @@ #include #include "base/base64.h" +#include "base/functional/callback_helpers.h" #include "base/strings/string_number_conversions.h" #include "base/test/task_environment.h" #include "base/time/time.h" diff --git a/ios/app/brave_profile_controller.mm b/ios/app/brave_profile_controller.mm index ad2a3b44fd0..29c7e00c140 100644 --- a/ios/app/brave_profile_controller.mm +++ b/ios/app/brave_profile_controller.mm @@ -6,6 +6,7 @@ #include "brave/ios/app/brave_profile_controller.h" #include "base/check.h" +#include "base/functional/callback_helpers.h" #include "base/memory/raw_ptr.h" #include "brave/components/ai_chat/ios/browser/ai_chat+private.h" #include "brave/components/ai_chat/ios/browser/ai_chat_delegate.h" diff --git a/ios/browser/api/brave_rewards/brave_rewards_api.mm b/ios/browser/api/brave_rewards/brave_rewards_api.mm index 9696bad81eb..f03f09c0e9a 100644 --- a/ios/browser/api/brave_rewards/brave_rewards_api.mm +++ b/ios/browser/api/brave_rewards/brave_rewards_api.mm @@ -12,6 +12,7 @@ #include "base/apple/foundation_util.h" #include "base/check.h" #include "base/containers/flat_map.h" +#include "base/functional/callback_helpers.h" #include "base/ios/ios_util.h" #include "base/json/json_reader.h" #include "base/logging.h" diff --git a/ios/browser/api/history/brave_history_api.mm b/ios/browser/api/history/brave_history_api.mm index ef0e39d9b75..0da031be346 100644 --- a/ios/browser/api/history/brave_history_api.mm +++ b/ios/browser/api/history/brave_history_api.mm @@ -9,6 +9,7 @@ #include "base/check.h" #include "base/functional/bind.h" +#include "base/functional/callback_helpers.h" #include "base/memory/raw_ptr.h" #include "base/strings/sys_string_conversions.h" #include "brave/ios/browser/api/history/brave_history_observer.h" diff --git a/ios/browser/api/ntp_background_images/ntp_background_images_service_ios.mm b/ios/browser/api/ntp_background_images/ntp_background_images_service_ios.mm index d5cc980dd66..52a38310e26 100644 --- a/ios/browser/api/ntp_background_images/ntp_background_images_service_ios.mm +++ b/ios/browser/api/ntp_background_images/ntp_background_images_service_ios.mm @@ -7,6 +7,7 @@ #include +#include "base/functional/callback_helpers.h" #include "base/memory/raw_ptr.h" #include "brave/components/brave_ads/core/browser/service/ads_service.h" #include "brave/components/brave_ads/core/browser/service/ads_service_observer.h" diff --git a/ios/browser/ui/webui/ai_chat/associated_url_content.mm b/ios/browser/ui/webui/ai_chat/associated_url_content.mm index 94f39c6ed76..8523b202c9d 100644 --- a/ios/browser/ui/webui/ai_chat/associated_url_content.mm +++ b/ios/browser/ui/webui/ai_chat/associated_url_content.mm @@ -5,6 +5,7 @@ #include "brave/ios/browser/ui/webui/ai_chat/associated_url_content.h" +#include "base/functional/callback_helpers.h" #include "base/strings/string_number_conversions.h" #include "base/strings/sys_string_conversions.h" #include "base/time/time.h" diff --git a/renderer/test/js_ethereum_provider_browsertest.cc b/renderer/test/js_ethereum_provider_browsertest.cc index 85ccc3cb1bd..31c4ddc3a46 100644 --- a/renderer/test/js_ethereum_provider_browsertest.cc +++ b/renderer/test/js_ethereum_provider_browsertest.cc @@ -6,6 +6,7 @@ #include #include +#include "base/functional/callback_helpers.h" #include "base/metrics/statistics_recorder.h" #include "base/path_service.h" #include "base/test/metrics/histogram_tester.h"