From c341c734e9a322c22ca613c4a71d703d28f94853 Mon Sep 17 00:00:00 2001 From: Brian Johnson <34129+bridiver@users.noreply.github.com> Date: Mon, 10 Nov 2025 08:44:03 -0700 Subject: [PATCH] Run components/brave_wallet/browser tests on ios (#32230) Tests that failed for non-obvious reasons are set for follow-up https://github.com/brave/brave-browser/issues/50734 --- components/BUILD.gn | 2 +- components/brave_wallet/browser/BUILD.gn | 57 +++++++++++++----- .../data/brave_wallet/1.0.1/images/logo.png | Bin 0 -> 4498 bytes 3 files changed, 43 insertions(+), 16 deletions(-) create mode 100644 components/test/data/brave_wallet/1.0.1/images/logo.png diff --git a/components/BUILD.gn b/components/BUILD.gn index 98ed212d941..ccef929ec5b 100644 --- a/components/BUILD.gn +++ b/components/BUILD.gn @@ -32,6 +32,7 @@ test("brave_components_unittests") { "//brave/components/brave_policy/ad_block_only_mode:unit_tests", "//brave/components/brave_shields/core/browser:unit_tests", "//brave/components/brave_shields/core/common:unit_tests", + "//brave/components/brave_wallet/browser:unit_tests", "//brave/components/brave_wallet/common:unit_tests", "//brave/components/component_updater:unit_tests", "//brave/components/email_aliases:unit_tests", @@ -60,7 +61,6 @@ test("brave_components_unittests") { if (use_blink) { deps += [ "//brave/components/ai_chat/content/browser:unit_tests", - "//brave/components/brave_wallet/browser:unit_tests", "//brave/components/brave_wallet/renderer/test:unit_tests", ] } diff --git a/components/brave_wallet/browser/BUILD.gn b/components/brave_wallet/browser/BUILD.gn index 481a87d8f73..42b4c726aa2 100644 --- a/components/brave_wallet/browser/BUILD.gn +++ b/components/brave_wallet/browser/BUILD.gn @@ -639,16 +639,30 @@ generated_types("meld_integration_responses") { ] } +if (is_ios) { + bundle_data("unit_tests_bundle_data") { + testonly = true + visibility = [ ":unit_tests" ] + sources = [ + "//brave/components/test/data/brave_wallet/1.0.1/images/logo.png", + "//brave/components/test/data/brave_wallet/cardano/cardano_sdk_cip30/index.mts", + "//brave/components/test/data/brave_wallet/cardano/cardano_sdk_cip30/test_vectors.json", + "//brave/components/test/data/brave_wallet/cardano/cardano_sdk_crypto_slip23/index.mts", + "//brave/components/test/data/brave_wallet/cardano/cardano_sdk_crypto_slip23/test_vectors.json", + "//brave/third_party/bitcoin-core/src/src/test/data/key_io_valid.json", + ] + outputs = [ "{{bundle_resources_dir}}/" + + "{{source_root_relative_dir}}/{{source_file_part}}" ] + } +} + source_set("unit_tests") { testonly = true sources = [ "account_discovery_manager_unittest.cc", "account_resolver_delegate_impl_unittest.cc", - "asset_ratio_response_parser_unittest.cc", - "asset_ratio_service_unittest.cc", "bip39_unittest.cc", "bitcoin/bitcoin_block_tracker_unittest.cc", - "bitcoin/bitcoin_hardware_keyring_unittest.cc", "bitcoin/bitcoin_hd_keyring_unittest.cc", "bitcoin/bitcoin_import_keyring_unittest.cc", "bitcoin/bitcoin_knapsack_solver_unittest.cc", @@ -661,11 +675,8 @@ source_set("unit_tests") { "bitcoin/bitcoin_tx_state_manager_unittest.cc", "bitcoin/bitcoin_wallet_service_unittest.cc", "blockchain_list_parser_unittest.cc", - "blockchain_registry_unittest.cc", "brave_wallet_p3a_unittest.cc", "brave_wallet_prefs_unittest.cc", - "brave_wallet_utils_unittest.cc", - "cardano/cardano_api_impl_unittest.cc", "cardano/cardano_block_tracker_unittest.cc", "cardano/cardano_cip30_serializer_unittest.cc", "cardano/cardano_create_transaction_task_unittest.cc", @@ -673,9 +684,7 @@ source_set("unit_tests") { "cardano/cardano_hd_keyring_unittest.cc", "cardano/cardano_knapsack_solver_unittest.cc", "cardano/cardano_max_send_solver_unittest.cc", - "cardano/cardano_provider_impl_unittest.cc", "cardano/cardano_rpc_schema_unittest.cc", - "cardano/cardano_rpc_unittest.cc", "cardano/cardano_transaction_serializer_unittest.cc", "cardano/cardano_transaction_unittest.cc", "cardano/cardano_tx_manager_unittest.cc", @@ -685,7 +694,6 @@ source_set("unit_tests") { "eip1559_transaction_unittest.cc", "eip2930_transaction_unittest.cc", "eth_abi_decoder_unittest.cc", - "eth_block_tracker_unittest.cc", "eth_data_builder_unittest.cc", "eth_data_parser_unittest.cc", "eth_gas_utils_unittest.cc", @@ -694,10 +702,8 @@ source_set("unit_tests") { "eth_response_parser_unittest.cc", "eth_topics_builder_unittest.cc", "eth_transaction_unittest.cc", - "eth_tx_manager_unittest.cc", "eth_tx_meta_unittest.cc", "eth_tx_state_manager_unittest.cc", - "ethereum_keyring_unittest.cc", "fil_block_tracker_unittest.cc", "fil_nonce_tracker_unittest.cc", "fil_requests_unittest.cc", @@ -712,7 +718,6 @@ source_set("unit_tests") { "internal/hd_key_ed25519_slip23_unittest.cc", "internal/hd_key_ed25519_unittest.cc", "internal/hd_key_sr25519_unittest.cc", - "internal/hd_key_unittest.cc", "internal/secp256k1_signature_unittest.cc", "json_keystore_parser_unittest.cc", "json_rpc_requests_helper_unittest.cc", @@ -721,7 +726,6 @@ source_set("unit_tests") { "json_rpc_service_unittest.cc", "keyring_service_migrations_unittest.cc", "keyring_service_prefs_unittest.cc", - "keyring_service_unittest.cc", "meld_integration_response_parser_unittest.cc", "meld_integration_service_unittest.cc", "network_manager_unittest.cc", @@ -764,8 +768,6 @@ source_set("unit_tests") { "tx_storage_delegate_impl_unittest.cc", "unstoppable_domains_dns_resolve_unittest.cc", "unstoppable_domains_multichain_calls_unittest.cc", - "wallet_data_files_installer_unittest.cc", - "zcash/zcash_create_transparent_transaction_task_unittest.cc", "zcash/zcash_grpc_utils_unittest.cc", "zcash/zcash_keyring_unittest.cc", "zcash/zcash_resolve_transaction_status_task_unittest.cc", @@ -775,6 +777,27 @@ source_set("unit_tests") { "zcash/zcash_wallet_service_unittest.cc", ] + if (!is_ios) { + # TODO(https://github.com/brave/brave-browser/issues/50734) Investigate why these tests fail on ios + sources += [ + "asset_ratio_response_parser_unittest.cc", + "asset_ratio_service_unittest.cc", + "bitcoin/bitcoin_hardware_keyring_unittest.cc", + "blockchain_registry_unittest.cc", + "brave_wallet_utils_unittest.cc", + "cardano/cardano_api_impl_unittest.cc", + "cardano/cardano_provider_impl_unittest.cc", + "cardano/cardano_rpc_unittest.cc", + "eth_block_tracker_unittest.cc", + "eth_tx_manager_unittest.cc", + "ethereum_keyring_unittest.cc", + "internal/hd_key_unittest.cc", + "keyring_service_unittest.cc", + "wallet_data_files_installer_unittest.cc", + "zcash/zcash_create_transparent_transaction_task_unittest.cc", + ] + } + deps = [ ":browser", ":constants", @@ -850,6 +873,10 @@ source_set("unit_tests") { ] } + if (is_ios) { + deps += [ ":unit_tests_bundle_data" ] + } + data = [ "//brave/components/test/data/brave_wallet", "//brave/components/test/data/brave_wallet/cardano/cardano_sdk_cip30/test_vectors.json", diff --git a/components/test/data/brave_wallet/1.0.1/images/logo.png b/components/test/data/brave_wallet/1.0.1/images/logo.png new file mode 100644 index 0000000000000000000000000000000000000000..44ddb41fe95ad2a158eea6ba4259338289ba9e18 GIT binary patch literal 4498 zcmV;D5pC{?P)k#T0wYcYq9PC-fuIOXMPN9Bfi{7KA{a7)p(0o@ z0xe1^*ex0$0kFHP8o2iy4DFF^fQ|aP9{u|8^70ZvvikG>WmbHgwfHOR|J;0dM$7rv z2LR&~glX|XR|!POz#y21_ z0}?BOqm3SmD=)6B0BDUj3SeA>S988DdiM1wtjidn93BY3oDya&7?R0=zWRpYN#T6} zOcPJC;A?^wdCh@RhGz?401QEL#$II6!*I)X-b3J|0A{$}WXYh6!9%N@hoD&v&Fc&j z7_M*;D3`GPll6nWP7YxD2g(9rm(y@9={q=s0ER(H0!ZR1!7f9bt?_FbtuL!p<&1$k zm9q)xItMrarfukzDDx;AHvTPtKD#t7V|tEx#U473UV_t0V0ipwr2rK27&(KHYZ}ww z%3#bMsr(!}0%y^e;y|x}VIv?=u7n<8$ADx}fFtI{d^oyn7ewya<2(Zx9WQ&y;g|37 z@RI>Z*0ausz$vE#jV*O3%aF%$f(M3s#nf|xTh6^2OgWVcCv!`lC)hA8SYWsZB(HMo z@wS5>={9CXEKlsDsMDc=&ji5u@ha5A`zRBa-Xy_Xs>=7UJTYes%G(47O!1NuPhMrm z1%wq=EjIS{%Z|BDFu6@I!0>oN<{?)BD5r;ONk{Mhz~1H=z?}9X=A77%0ZLFsf-c}} z7@9SJ>DKUM#5ay_a|cjVg=%U;G_}BRV^av`aLjyJID zD%cad{T$}({k^uGvZN}nQ3ni9n9LmJD+s@ISS`D zVH)KqO=k{JR4|u*e`(%rM?@uY_Dhzqe^x z;1PvJ92keNJTffERl)&>Dq`O>Ln8`|Ls$@kg$oT;(((o&ng}#vz&L_s$BBIg(+fUC zBWTXGK_dc;BUn^aQ6TSj;uRY2z&L_MO`RUHZZC`I_)r5uGxITHV)*RT5Qfdrg4@f%mk`|rcM{!aqG=t*bQziCixhYgpS!9MIPUMUfGqOy&?PKsTHw0xY!Vh?}?>ZmxXubiz;4b4WDsHRZN*8X9yTOi@RLmfl2=cvAN zMxj|E8j?AvihV}j0$J+B>y|rruA15KFg8Q6JHP^2ECM{#g=Qil8E=tet17m^I(*2o z7B%_IIgj1=1IE~h&E}VbAlv!O+-3pb6c5w&@En97MM0a5#H`*e72%`$-NV<$I%Y~fvOO@YC*ecc)xolE(7 z%XUB?j|>nQTpqB8q7dxA6)8t*BZsk-obMvL(`g|8x?q6*F0TKP_okV_+^L3?%j68d zsR?i3axyRrOV62MeSR+iqG|O1GCYfbo;_)6>qm1K%bSRQl8A$m!-(WT6nd*a-o3C5 zvd8@?Gqok=CLYFCkMYo_q!Bur2T|CzrEw1*$52@IGV@L$8ONozdS)d1!v;rXsK!;X zr>0Kgn1`{I>~C=N_u#?#&N+_8;y}8em(@MzF<@-<3h*vaSs+;RN?lD_H4V!~N0NP8 z3&e1$F=Tq1zisb%d}3He3I30hfH{=-bV&A5N{04z%LfE&QC1O_oizf6|KO#g2Z5kc zS6ZOq9WkGdIgOEH?*d?;V4$h6)wn4zF~Tv(Gc+0sL#Z?{@GekO-AIqs@XkeMST^CM zA@#uUAD93bNI)wE<1`1uvXMjYvOzcowUm={DQ$*jBZmopj`t6B&^d1;t|ct156QTk zd;wq}VM$Ne%=hw`X`P3OE#4Gcze1;kW{DDD-gy~Uz&v3pKXjsQ1PcIJQ($KBE|4NE zgz^|FR&A;r$v!a1Um#7A-00D?;oozZ{Q(+y7)V1dBRH7(F7dDOFxG&-5XrWJXnP=hTEB?-;VEONkOQ7p+WNetm|IRf)}s+TtCDb&Lmx<5RYQd1P;Dlua*_ z3VE4{5rJhN9e5bzFM)|ix9OsC>XHGXg!@X#BgTTjT$+50suG(Mh52JW0I0Yq+5QyO zAKmR680kFb7cj@R$3#drSa4_qatep8qw0f*d}$&yRc5`P!;CD4V*sX~;H2EkOF}b~ z=rD}mo&y-DZJrYgK7!P}%@Ke5z+etp@1glBbo;5$eShZUR16sjKMWKeG^_nyx97m* zW*#$w2|yjR91t*3RY+zlp~5KtFuY7I@UEo>Q@2&Xj9vWWP_H$V{jw{8fuK`j`@v|W z{IDBHZ&>Di3Y6s~D4jjb46h&Rs7KHDlbW@RkPL!4g=A;~$X2)lU?AwQe9ugmS~{|G z1rC)F$7V?A!oys^w0a2(b%d$Ft#?JIuHiK9cfjl{H|`WB z);rHak;qu!_R_GF5!06b^UtH++*azNQH8MSVPcqEuz3oBqUFeoM8PwhnbFcmco-*|a``m`o$>pc z3FRntdQftb-C1OmwM`FWvs_4L6V4P2Hc4p`$&_FFq@|MQI5$0AnZvkPn1iqk>Z&^p zdvqH!vfnQtbL0sC4Ae!N!XCARvjohO39nft+W;6ySi4B>)Z{u~-sMpyFt%ObSZL!l zC|u2z9hdTY5NsVVF2b?}YyfJgYb8}NQx}IkjEjdwSOztPCDrsmJn3??zf+BC4|9%r zWl(6au%=Z`spl8c==maqvZFj&gyD60j=p_iG%E}%V8HSCLGSY8wUs+?*c7#DfW z#8`v_K?F;zFu^zTmua2z@Bs{I0Xuc>^jl%5nUW}k z!m+dsFs{~6Pn5^4kgP5_w~>ZsdT288Z@}<)%*N5f02t_yXzj^Xcn;$B&=2d@^rx<3 zR+N~b1|eE50S((`)&&@sTiYbC2}mO}G&XeXl(SLIU)(wj%iv|8rqHC?h9eGbvy?i# zFT4!YG^fcz0mkKnUZ7$IwXl^$Jun=WJ-YNV9^EaC0qtOW!Rl5^7=LW%OP68UB=R(v z$#r#jw6LWjpE(9h=D25G`kG6`bAzs7cfrbA2YW~#US3`f{(-`v$;(_hd9&Lvh2 zj7Kj+N+nm`72kCQZ__vd-vOAzUdBf$R(w5#;cdPEoccEM*olS*411Zx)AP}Kh+KhD zRky--(J;H+@h0AD!@b7apJUN((e) zhr#0!G?0h!n>R_VjGP7m3~wg=FjQ!`4c0s+@kjJlRU53=@i}=mNMKmLS2C)DrVL4_ zs>WXDlVB1oEs4U&EEr&fDkLhQG22A2x0RN}8lbaafMEkkBL9^m)zA!B&wc-bBTN6z zLg3i}jXrG!?s*X$FkAq*7lJ0o*)xL%CP)uMk_gSp9wx_W%}`Ll@Zgoy0kAaUyB6N{ z9r9e_4c)_(D;V#Dz6;Gg`$yAhRsaUTG=YXfGs%gHbedI)yhcPZfa#`1B)gX6DiS(l zWT@f}N@8oKP4K|*faXH@9iAgZ^D3$Q^*MN87@ABlpV<%5P(^dE1i;wIXC4&1Om)Xw z_beQvc9q(4cHJ9bjC@AJEZ(uZMf3dNmcTMY963LCN zdy?qqk-*AFLteLy^#Y916XnXFA>A`L&p;qJSa!vG3v0G=i+qMWjK&<|CVD#?KEc>c zP_U4^FQXXwyczEWpz%;6@_M%brx7f1^ft-zT*2eyzHjI)B-?9r@-*L++Xm%0DbK`) z-rifn9g7zI;X9NT0frl&yvCnhXgrPVFNyac3QT~|3<4fLN@5Y|J+|+O_lJuH2TZ`wnDFEb(3-1(Awn`^Naz|X zf81-S5LpEW3Z~B7!H^IL5=3Knl6${29t=%3|I{6)-)7=G{w<-b%3q(R1`` zI>*-LD0RiQspjv=gOug+i-6nmTCxD63K#>LRRCduD{Z2~GjPf1&j;Ez;-^!q1ICD_ z^8rHxRqL~KjyTfTD#nrE*dZS(b*G`AqSC|cC8k;6F*jr(Oyzy6BLLG39Li~KU^jyl zmF;I*mSF?|42l8BTeLh(Fu)kafHWFzm1t{nC9Tj+1nsQ z11tchg}0%Gy@ZVc768*6oH)|AUIS_;s)jAKuRH1mFow6Gm7KS*z2HQ1?dBoO^zIEX z1~^mpHW=&-Lyrtg5WDvD4w${7zzSiSYTfbfsKKbW!0d%-bfKE2M>I!p5#nOIUIViS z4)tW1UL&8_uR`-Gg98R0M}=rp`eo=_^9~9afFqXFCw1`K81H( k_uqOB_2ht%^nU>c08H4uWlB>TdH?_b07*qoM6N<$g0Co7Pyhe` literal 0 HcmV?d00001