From c74b5da1ecd77c1a19fb1340ea7497073ee06a7a Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Thu, 23 Apr 2026 16:17:18 +0100 Subject: [PATCH] [cr149] `BrowserList` was deleted Chromium changes: https://chromium.googlesource.com/chromium/src/+/499cfaea23ab8386461cbfeec1c4a2dcbd8ca8f6 commit 499cfaea23ab8386461cbfeec1c4a2dcbd8ca8f6 Author: Thomas Lukaszewicz Date: Wed Apr 22 11:19:07 2026 -0700 [bedrock] Remove BrowserList There are no remaining clients of BrowserList and no behavior changes in this CL. The changes involve removing the files and cleaning up any remaining includes / comments. Bug: 431671320 Change-Id: Ie61bbd3f8371cd5777d179d08ac4f47b9e29dd01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7744394 Commit-Queue: Thomas Lukaszewicz Reviewed-by: Qikai Zhong Cr-Commit-Position: refs/heads/main@{#1618978} --- browser/ai_chat/BUILD.gn | 1 - browser/ai_chat/ai_chat_sidepanel_behavior_browsertest.cc | 1 - browser/brave_ads/BUILD.gn | 4 ---- browser/brave_ads/tabs/BUILD.gn | 4 ---- .../browsing_data/brave_clear_browsing_data_browsertest.cc | 1 - .../brave_ephemeral_storage_service_delegate.cc | 1 - .../search_engine_provider_service_browsertest.cc | 1 - browser/speedreader/speedreader_browsertest.cc | 1 - browser/tor/tor_profile_manager.cc | 1 - browser/ui/brave_browser_command_controller_browsertest.cc | 1 - browser/ui/commander/entity_match_unittest.cc | 1 - browser/ui/toolbar/brave_app_menu_model_browsertest.cc | 1 - browser/ui/views/frame/vertical_tabs/BUILD.gn | 1 - browser/ui/views/profiles/brave_incognito_menu_view.cc | 1 - browser/ui/webui/brave_vpn/vpn_panel_ui.cc | 1 - browser/ui/webui/psst/brave_psst_dialog_ui.cc | 1 - browser/ui/window_closing_confirm_browsertest.cc | 1 - .../ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc | 1 - 18 files changed, 24 deletions(-) diff --git a/browser/ai_chat/BUILD.gn b/browser/ai_chat/BUILD.gn index 80d6e12e152..f8f94881670 100644 --- a/browser/ai_chat/BUILD.gn +++ b/browser/ai_chat/BUILD.gn @@ -219,7 +219,6 @@ if (enable_brave_ai_chat_agent_profile) { "//chrome/browser/profiles:profile", "//chrome/browser/profiles:profile_util", "//chrome/browser/ui", - "//chrome/browser/ui:browser_list", "//components/optimization_guide/content/browser", ] diff --git a/browser/ai_chat/ai_chat_sidepanel_behavior_browsertest.cc b/browser/ai_chat/ai_chat_sidepanel_behavior_browsertest.cc index 873cd197814..b82e352692f 100644 --- a/browser/ai_chat/ai_chat_sidepanel_behavior_browsertest.cc +++ b/browser/ai_chat/ai_chat_sidepanel_behavior_browsertest.cc @@ -11,7 +11,6 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_finder.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_window/public/browser_window_features.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/ui/views/frame/browser_view.h" diff --git a/browser/brave_ads/BUILD.gn b/browser/brave_ads/BUILD.gn index 571c08b9806..2398b3d1f27 100644 --- a/browser/brave_ads/BUILD.gn +++ b/browser/brave_ads/BUILD.gn @@ -28,10 +28,6 @@ source_set("brave_ads") { "//components/sessions:session_id", "//content/public/browser", ] - - if (!is_android) { - public_deps += [ "//chrome/browser/ui:browser_list" ] - } } source_set("impl") { diff --git a/browser/brave_ads/tabs/BUILD.gn b/browser/brave_ads/tabs/BUILD.gn index 6389ee33a69..682a96f06f3 100644 --- a/browser/brave_ads/tabs/BUILD.gn +++ b/browser/brave_ads/tabs/BUILD.gn @@ -19,10 +19,6 @@ source_set("tabs") { "//content/public/browser", ] - if (!is_android) { - public_deps += [ "//chrome/browser/ui:browser_list" ] - } - deps = [ "//brave/browser/brave_ads", "//brave/components/brave_ads/browser", diff --git a/browser/browsing_data/brave_clear_browsing_data_browsertest.cc b/browser/browsing_data/brave_clear_browsing_data_browsertest.cc index 7273e8b46b6..8ddfa4ab48f 100644 --- a/browser/browsing_data/brave_clear_browsing_data_browsertest.cc +++ b/browser/browsing_data/brave_clear_browsing_data_browsertest.cc @@ -27,7 +27,6 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_commands.h" #include "chrome/browser/ui/browser_finder.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/common/chrome_paths.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/search_test_utils.h" diff --git a/browser/ephemeral_storage/brave_ephemeral_storage_service_delegate.cc b/browser/ephemeral_storage/brave_ephemeral_storage_service_delegate.cc index 9cb3062a5b8..62e004e50ff 100644 --- a/browser/ephemeral_storage/brave_ephemeral_storage_service_delegate.cc +++ b/browser/ephemeral_storage/brave_ephemeral_storage_service_delegate.cc @@ -46,7 +46,6 @@ #if !BUILDFLAG(IS_ANDROID) #include "brave/browser/ui/brave_browser.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #else #include "chrome/browser/android/tab_android.h" diff --git a/browser/search_engines/search_engine_provider_service_browsertest.cc b/browser/search_engines/search_engine_provider_service_browsertest.cc index a0d44deefdd..aeaae5e62ad 100644 --- a/browser/search_engines/search_engine_provider_service_browsertest.cc +++ b/browser/search_engines/search_engine_provider_service_browsertest.cc @@ -27,7 +27,6 @@ #include "chrome/browser/regional_capabilities/regional_capabilities_service_factory.h" #include "chrome/browser/search_engines/template_url_service_factory.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" diff --git a/browser/speedreader/speedreader_browsertest.cc b/browser/speedreader/speedreader_browsertest.cc index 512a290713f..4aa561b9ffa 100644 --- a/browser/speedreader/speedreader_browsertest.cc +++ b/browser/speedreader/speedreader_browsertest.cc @@ -40,7 +40,6 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_command_controller.h" #include "chrome/browser/ui/browser_commands.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window/public/browser_window_features.h" #include "chrome/browser/ui/side_panel/side_panel_ui.h" diff --git a/browser/tor/tor_profile_manager.cc b/browser/tor/tor_profile_manager.cc index adbdbccd8b6..4c6f51a04c0 100644 --- a/browser/tor/tor_profile_manager.cc +++ b/browser/tor/tor_profile_manager.cc @@ -21,7 +21,6 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_commands.h" #include "chrome/browser/ui/browser_finder.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/browser_window/public/browser_collection_observer.h" #include "chrome/browser/ui/browser_window/public/browser_window_interface.h" diff --git a/browser/ui/brave_browser_command_controller_browsertest.cc b/browser/ui/brave_browser_command_controller_browsertest.cc index 4044e5782c9..fc2803d5d3b 100644 --- a/browser/ui/brave_browser_command_controller_browsertest.cc +++ b/browser/ui/brave_browser_command_controller_browsertest.cc @@ -31,7 +31,6 @@ #include "chrome/browser/tab_group_sync/tab_group_sync_service_factory.h" #include "chrome/browser/ui/browser_command_controller.h" #include "chrome/browser/ui/browser_commands.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window/public/browser_window_features.h" #include "chrome/browser/ui/ui_features.h" diff --git a/browser/ui/commander/entity_match_unittest.cc b/browser/ui/commander/entity_match_unittest.cc index 16e035d7765..8940ab7202d 100644 --- a/browser/ui/commander/entity_match_unittest.cc +++ b/browser/ui/commander/entity_match_unittest.cc @@ -15,7 +15,6 @@ #include "base/strings/utf_string_conversions.h" #include "brave/browser/ui/commander/command_source.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/test/base/browser_with_test_window_test.h" #include "chrome/test/base/test_browser_window.h" #include "chrome/test/base/testing_profile.h" diff --git a/browser/ui/toolbar/brave_app_menu_model_browsertest.cc b/browser/ui/toolbar/brave_app_menu_model_browsertest.cc index c9d98f42b97..8116f530b50 100644 --- a/browser/ui/toolbar/brave_app_menu_model_browsertest.cc +++ b/browser/ui/toolbar/brave_app_menu_model_browsertest.cc @@ -25,7 +25,6 @@ #include "chrome/app/chrome_command_ids.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_window.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/tabs/recent_tabs_sub_menu_model.h" #include "chrome/browser/ui/views/frame/browser_view.h" #include "chrome/browser/ui/views/toolbar/toolbar_view.h" diff --git a/browser/ui/views/frame/vertical_tabs/BUILD.gn b/browser/ui/views/frame/vertical_tabs/BUILD.gn index 1c4d38617c8..a52333f5e2c 100644 --- a/browser/ui/views/frame/vertical_tabs/BUILD.gn +++ b/browser/ui/views/frame/vertical_tabs/BUILD.gn @@ -31,7 +31,6 @@ source_set("vertical_tabs") { "//chrome/app:command_ids", "//chrome/browser/profiles", "//chrome/browser/themes", - "//chrome/browser/ui:browser_list", "//chrome/browser/ui:ui_features", "//chrome/browser/ui/color:color_headers", "//chrome/browser/ui/color:mixers", diff --git a/browser/ui/views/profiles/brave_incognito_menu_view.cc b/browser/ui/views/profiles/brave_incognito_menu_view.cc index d455abc4975..b9f805424e5 100644 --- a/browser/ui/views/profiles/brave_incognito_menu_view.cc +++ b/browser/ui/views/profiles/brave_incognito_menu_view.cc @@ -18,7 +18,6 @@ #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/profiles/profile_window.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/views/chrome_layout_provider.h" #include "chrome/grit/generated_resources.h" #include "components/vector_icons/vector_icons.h" diff --git a/browser/ui/webui/brave_vpn/vpn_panel_ui.cc b/browser/ui/webui/brave_vpn/vpn_panel_ui.cc index 1f4693f65d3..2bd08a490f8 100644 --- a/browser/ui/webui/brave_vpn/vpn_panel_ui.cc +++ b/browser/ui/webui/brave_vpn/vpn_panel_ui.cc @@ -17,7 +17,6 @@ #include "brave/components/constants/webui_url_constants.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/ui/webui/favicon_source.h" #include "chrome/browser/ui/webui/theme_source.h" diff --git a/browser/ui/webui/psst/brave_psst_dialog_ui.cc b/browser/ui/webui/psst/brave_psst_dialog_ui.cc index ccb3ba13920..a40957a28c9 100644 --- a/browser/ui/webui/psst/brave_psst_dialog_ui.cc +++ b/browser/ui/webui/psst/brave_psst_dialog_ui.cc @@ -15,7 +15,6 @@ #include "brave/components/psst/resources/grit/brave_psst_dialog_generated_map.h" #include "brave/components/psst/resources/grit/brave_psst_resources.h" #include "chrome/browser/profiles/profile.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_window/public/browser_window_interface.h" #include "chrome/browser/ui/browser_window/public/browser_window_interface_iterator.h" #include "components/grit/brave_components_webui_strings.h" diff --git a/browser/ui/window_closing_confirm_browsertest.cc b/browser/ui/window_closing_confirm_browsertest.cc index 5ce1eb53403..9d5a3ecddee 100644 --- a/browser/ui/window_closing_confirm_browsertest.cc +++ b/browser/ui/window_closing_confirm_browsertest.cc @@ -19,7 +19,6 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_commands.h" #include "chrome/browser/ui/browser_finder.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_window/public/global_browser_collection.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/ui/webui/profile_helper.h" diff --git a/chromium_src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc b/chromium_src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc index 11f12df6ff1..d6c59a66bb4 100644 --- a/chromium_src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc +++ b/chromium_src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc @@ -9,7 +9,6 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_command_controller.h" #include "chrome/browser/ui/browser_commands.h" -#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/tabs/tab_data.h" #include "chrome/browser/ui/test/test_browser_dialog.h" #include "chrome/browser/ui/views/tabs/hovercard/tab_hover_card_test_util.h"