From cd77ff9ee73cf4649c809bf2a201c48060cbf073 Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Wed, 29 Apr 2026 01:12:16 +0100 Subject: [PATCH] [cr149] `FindBrowserWithWebContents` renamed upstream. Follow up to: commit 72f140e852315b09d9e07c9d0cbd546bac00949a Author: Claudio DeSouza Date: Wed Oct 11 17:42:49 2023 +0100 `FindBrowserWithWebContents` renamed upstream This is a simple function rename with no other effects. Chromium change: https://chromium.googlesource.com/chromium/src/+/82d9bb0f98d7c88a1b2af2e267cf36125fba17c6 commit 82d9bb0f98d7c88a1b2af2e267cf36125fba17c6 Author: Avi Drissman Date: Mon Oct 9 21:05:45 2023 +0000 Rename FindBrowserWithWebContents to FindBrowserWithTab "WebContents" hasn't been synonymous with "tab" since the content split. It's confusing to have a function that says it finds a browser by "web contents" yet only looks at the tabs. Rename the function so that its name accurately reflects its function. Bug: none --- .../browser/ui/views/permissions/permission_prompt_factory.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chromium_src/chrome/browser/ui/views/permissions/permission_prompt_factory.cc b/chromium_src/chrome/browser/ui/views/permissions/permission_prompt_factory.cc index cd7bc1d4574..19df69bcd7f 100644 --- a/chromium_src/chrome/browser/ui/views/permissions/permission_prompt_factory.cc +++ b/chromium_src/chrome/browser/ui/views/permissions/permission_prompt_factory.cc @@ -5,6 +5,7 @@ #include "base/logging.h" #include "brave/components/brave_wallet/common/buildflags/buildflags.h" +#include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/permission_bubble/permission_prompt.h" #include "components/permissions/request_type.h" @@ -19,6 +20,7 @@ std::unique_ptr CreatePermissionPrompt( content::WebContents* web_contents, permissions::PermissionPrompt::Delegate* delegate) { +#if BUILDFLAG(ENABLE_BRAVE_WALLET) Browser* browser = chrome::FindBrowserWithTab(web_contents); if (!browser) { DLOG(WARNING) << "Permission prompt suppressed because the WebContents is " @@ -26,7 +28,6 @@ std::unique_ptr CreatePermissionPrompt( return nullptr; } -#if BUILDFLAG(ENABLE_BRAVE_WALLET) if (delegate->Requests()[0]->request_type() == permissions::RequestType::kBraveEthereum || delegate->Requests()[0]->request_type() ==